From nobody@FreeBSD.org  Thu Jun 20 11:08:52 2013
Return-Path: <nobody@FreeBSD.org>
Received: from mx1.freebsd.org (mx1.freebsd.org [8.8.178.115])
	by hub.freebsd.org (Postfix) with ESMTP id 4693F93F
	for <freebsd-gnats-submit@FreeBSD.org>; Thu, 20 Jun 2013 11:08:52 +0000 (UTC)
	(envelope-from nobody@FreeBSD.org)
Received: from oldred.freebsd.org (oldred.freebsd.org [8.8.178.121])
	by mx1.freebsd.org (Postfix) with ESMTP id 39CA11D3C
	for <freebsd-gnats-submit@FreeBSD.org>; Thu, 20 Jun 2013 11:08:52 +0000 (UTC)
Received: from oldred.freebsd.org ([127.0.1.6])
	by oldred.freebsd.org (8.14.5/8.14.7) with ESMTP id r5KB8oMn066453
	for <freebsd-gnats-submit@FreeBSD.org>; Thu, 20 Jun 2013 11:08:50 GMT
	(envelope-from nobody@oldred.freebsd.org)
Received: (from nobody@localhost)
	by oldred.freebsd.org (8.14.5/8.14.5/Submit) id r5KB8omS066452;
	Thu, 20 Jun 2013 11:08:50 GMT
	(envelope-from nobody)
Message-Id: <201306201108.r5KB8omS066452@oldred.freebsd.org>
Date: Thu, 20 Jun 2013 11:08:50 GMT
From: Trond Endrestl <Trond.Endrestol@ximalas.info>
To: freebsd-gnats-submit@FreeBSD.org
Subject: The commit log message for r251614 contains non-printable characters
X-Send-Pr-Version: www-3.1
X-GNATS-Notify:

>Number:         179760
>Category:       misc
>Synopsis:       The commit log message for r251614 contains non-printable characters
>Confidential:   no
>Severity:       non-critical
>Priority:       low
>Responsible:    hselasky
>State:          open
>Quarter:        
>Keywords:       
>Date-Required:  
>Class:          change-request
>Submitter-Id:   current-users
>Arrival-Date:   Thu Jun 20 11:10:00 UTC 2013
>Closed-Date:    
>Last-Modified:  Tue Jun 25 17:40:01 UTC 2013
>Originator:     Trond Endrestl
>Release:        N/A
>Organization:
Private
>Environment:
N/A
>Description:
The commit log message for r251614 contains non-printable characters making svnsync from subversion-1.8.0_1 complain as follows:

svnsync: E000022: Safe data 'MFC r251249, r251251, r251252, r' was followed by non-ASCII byte 24: unable to convert to/from UTF-8

The commit log message for r251614 reads:

MFC r251249, r251251, r251252, r.2512, r251254 and r251515:
Correct XHCI DMA descriptor programming.
Correct maximum IRQ rate.

Notice the fourth revision number the log message is incomplete.
>How-To-Repeat:
Synchronise a repo mirror using current svn tools from a snapshot prior to r251614.
>Fix:
Edit the commit log message for both technical and practical reasons.

>Release-Note:
>Audit-Trail:
Responsible-Changed-From-To: freebsd-bugs->hselasky 
Responsible-Changed-By: linimon 
Responsible-Changed-When: Sun Jun 23 20:06:27 UTC 2013 
Responsible-Changed-Why:  
over to committer. 

http://www.freebsd.org/cgi/query-pr.cgi?pr=179760 

From: olli hauer <ohauer@gmx.de>
To: bug-followup@FreeBSD.org
Cc: Trond.Endrestol@ximalas.info, Hans Petter Selasky <hps@bitfrost.no>, 
 Olli Hauer <ohauer@FreeBSD.org>
Subject: Re: misc/179760: The commit log message for r251614 contains non-printable
 characters
Date: Tue, 25 Jun 2013 16:58:19 +0200

 Hi Trond,
 
 it seems this is a subversion 1.8 issue (I had no issues with subversion 1.7.10).
 
 I've send parts of your PR to the subversion user mailing list to see if others are also affected and got some feedback from Daniel Shahaf.
 
 Pls. can you take a look on this thread and come back or directly answer to the thread (as fas as I know no subscription is required)
 
 List : users@subversion.apache.org
 
 Web archive thread:
 http://mail-archives.apache.org/mod_mbox/subversion-users/201306.mbox/%3C51C88223.6070705@gmx.de%3E
 
 http://svn.haxx.se/users/archive-2013-06/0263.shtml
 
 or
 http://article.gmane.org/gmane.comp.version-control.subversion.user/113737
 
 
 Reference FreeBSD PR:
 http://www.freebsd.org/cgi/query-pr.cgi?pr=179760
 
 
 --
 Regards,
 olli

From: =?ISO-8859-1?Q?Trond_Endrest=F8l?= <Trond.Endrestol@ximalas.info>
To: olli hauer <ohauer@gmx.de>
Cc: bug-followup@FreeBSD.org, Trond.Endrestol@ximalas.info,
        Hans Petter Selasky <hps@bitfrost.no>, Olli Hauer <ohauer@FreeBSD.org>
Subject: Re: misc/179760: The commit log message for r251614 contains
 non-printable characters
Date: Tue, 25 Jun 2013 18:55:34 +0200 (CEST)

   This message is in MIME format.  The first part should be readable text,
   while the remaining parts are likely unreadable without MIME-aware tools.
 
 --598627194-156250755-1372179334=:1293
 Content-Type: TEXT/PLAIN; charset=ISO-8859-1
 Content-Transfer-Encoding: 8BIT
 
 On Tue, 25 Jun 2013 16:58+0200, olli hauer wrote:
 
 > Hi Trond,
 > 
 > it seems this is a subversion 1.8 issue (I had no issues with subversion 1.7.10).
 > 
 > I've send parts of your PR to the subversion user mailing list to see if others are also affected and got some feedback from Daniel Shahaf.
 
 Actually I wasn't thinking clearly enough when I wrote the PR, the 
 language is messed up on my part, I'm deeply sorry.
 
 I was setting up a local svn mirror on a useless laptop running head 
 (10.0-CURRENT i386) and I thought it would be nice to try svnlitesync 
 synchronising the laptop's svn mirror from the local svn mirror at 
 work.
 
 I began using a seed file generated on the local svn mirror at work. 
 The seed file contains everything from base up to r250823. Next, after 
 adjusting the svn:sync-from-url property, I ran svnlitesync hoping it 
 would catch up the missing revisions.
 
 It turns out svnsync from devel/subversion (1.8.0) didn't bother with 
 the commit log for r251614 and its non-printable characters. It ran 
 straight through to the latest revision available whereas svnlitesync 
 complained loudly when it reached r251614.
 
 I guess svnlitesync is unsuitable for maintaining a svn mirror unless 
 you start from a seed file beyond r251614, and svnsync from 
 devel/subversion is the way to go. But then, why bother with 
 installing svnlitesync when it's clearly inferior to the real deal? I 
 think it will be well worth the effort to make svnlitesync just as 
 robust as svnsync is. That way FreeBSD can be self-serviced.
 
 By the way, /usr/src/sys/conf/newvers.sh ought to be on the lookout 
 for svnliteversion if svnversion is unavailable.
 
 > Pls. can you take a look on this thread and come back or directly answer to the thread (as fas as I know no subscription is required)
 > 
 > List : users@subversion.apache.org
 > 
 > Web archive thread:
 > http://mail-archives.apache.org/mod_mbox/subversion-users/201306.mbox/%3C51C88223.6070705@gmx.de%3E
 > 
 > http://svn.haxx.se/users/archive-2013-06/0263.shtml
 > 
 > or
 > http://article.gmane.org/gmane.comp.version-control.subversion.user/113737
 > 
 > Reference FreeBSD PR:
 > http://www.freebsd.org/cgi/query-pr.cgi?pr=179760
 > 
 > --
 > Regards,
 > olli
 
 -- 
 ----------------------------------------------------------------------
 Trond Endrestl                     |     Trond.Endrestol@ximalas.info
 ACM, NAS, NUUG, SAGE, USENIX        |   FreeBSD 9.1-S & re-Alpine 2.03
 --598627194-156250755-1372179334=:1293--

From: olli hauer <ohauer@gmx.de>
To: =?ISO-8859-1?Q?Trond_Endrest=F8l?= <Trond.Endrestol@ximalas.info>
Cc: bug-followup@FreeBSD.org, Hans Petter Selasky <hps@bitfrost.no>, 
 Olli Hauer <ohauer@FreeBSD.org>
Subject: Re: misc/179760: The commit log message for r251614 contains non-printable
 characters
Date: Tue, 25 Jun 2013 19:36:36 +0200

 On 2013-06-25 18:55, Trond Endrestl wrote:
 > On Tue, 25 Jun 2013 16:58+0200, olli hauer wrote:
 > 
 >> Hi Trond,
 >>
 >> it seems this is a subversion 1.8 issue (I had no issues with subversion 1.7.10).
 >>
 >> I've send parts of your PR to the subversion user mailing list to see if others are also affected and got some feedback from Daniel Shahaf.
 > 
 > Actually I wasn't thinking clearly enough when I wrote the PR, the 
 > language is messed up on my part, I'm deeply sorry.
 > 
 > I was setting up a local svn mirror on a useless laptop running head 
 > (10.0-CURRENT i386) and I thought it would be nice to try svnlitesync 
 > synchronising the laptop's svn mirror from the local svn mirror at 
 > work.
 > 
 > I began using a seed file generated on the local svn mirror at work. 
 > The seed file contains everything from base up to r250823. Next, after 
 > adjusting the svn:sync-from-url property, I ran svnlitesync hoping it 
 > would catch up the missing revisions.
 > 
 > It turns out svnsync from devel/subversion (1.8.0) didn't bother with 
 > the commit log for r251614 and its non-printable characters. It ran 
 > straight through to the latest revision available whereas svnlitesync 
 > complained loudly when it reached r251614.
 > 
 > I guess svnlitesync is unsuitable for maintaining a svn mirror unless 
 > you start from a seed file beyond r251614, and svnsync from 
 > devel/subversion is the way to go. But then, why bother with 
 > installing svnlitesync when it's clearly inferior to the real deal? I 
 > think it will be well worth the effort to make svnlitesync just as 
 > robust as svnsync is. That way FreeBSD can be self-serviced.
 > 
 > By the way, /usr/src/sys/conf/newvers.sh ought to be on the lookout 
 > for svnliteversion if svnversion is unavailable.
 
 
 Ah OK, it was not devel/subversion from the ports!
 
 Anyway, if this happens with the latest svnlite version there is something
 broken. Given an attacker prepares a repo and the tool executes lover ASCI
 signs ... <bang>. (here it was only a CANCEL sign)
 
>Unformatted:
