From nobody@FreeBSD.org  Wed Dec 12 21:14:37 2012
Return-Path: <nobody@FreeBSD.org>
Received: from mx1.freebsd.org (mx1.freebsd.org [69.147.83.52])
	by hub.freebsd.org (Postfix) with ESMTP id CF97DB0C
	for <freebsd-gnats-submit@FreeBSD.org>; Wed, 12 Dec 2012 21:14:37 +0000 (UTC)
	(envelope-from nobody@FreeBSD.org)
Received: from red.freebsd.org (red.freebsd.org [IPv6:2001:4f8:fff6::22])
	by mx1.freebsd.org (Postfix) with ESMTP id B4F718FC0A
	for <freebsd-gnats-submit@FreeBSD.org>; Wed, 12 Dec 2012 21:14:37 +0000 (UTC)
Received: from red.freebsd.org (localhost [127.0.0.1])
	by red.freebsd.org (8.14.5/8.14.5) with ESMTP id qBCLEbbS007101
	for <freebsd-gnats-submit@FreeBSD.org>; Wed, 12 Dec 2012 21:14:37 GMT
	(envelope-from nobody@red.freebsd.org)
Received: (from nobody@localhost)
	by red.freebsd.org (8.14.5/8.14.5/Submit) id qBCLEbUV007100;
	Wed, 12 Dec 2012 21:14:37 GMT
	(envelope-from nobody)
Message-Id: <201212122114.qBCLEbUV007100@red.freebsd.org>
Date: Wed, 12 Dec 2012 21:14:37 GMT
From: "Wojciech A. Koszek" <wkoszek@FreeBSD.org>
To: freebsd-gnats-submit@FreeBSD.org
Subject: make installkernel shouldn't check for existence of user accounts
X-Send-Pr-Version: www-3.1
X-GNATS-Notify:

>Number:         174405
>Category:       misc
>Synopsis:       [build] make installkernel shouldn't check for existence of user accounts
>Confidential:   no
>Severity:       non-critical
>Priority:       low
>Responsible:    bdrewery
>State:          closed
>Quarter:        
>Keywords:       
>Date-Required:  
>Class:          sw-bug
>Submitter-Id:   current-users
>Arrival-Date:   Wed Dec 12 21:20:00 UTC 2012
>Closed-Date:    Tue Apr 23 08:08:27 CDT 2013
>Last-Modified:  Fri May 10 13:10:01 UTC 2013
>Originator:     Wojciech A. Koszek
>Release:        FreeBSD 10-CURRENT
>Organization:
FreeBSD
>Environment:
FreeBSD XXXXXX.XXXXXX.XXXX 10.0-CURRENT FreeBSD 10.0-CURRENT #0 r230923M: Thu Feb  2 20:11:19 PST 2012     wkoszek@freebsd:/usr/obj/data/head/sys/T7400  amd64
>Description:
I'm updating from older FreeBSD 10-CURRENT. Src/ is from svn.freebsd.org/base/head.

I did:

make -j4 buildkernel KERNCONF=GENERIC
make -j4 buildworld
make -j4 installkernel KERNCONF=GENERIC

I got an error message about non-existing user. I think make shouldn't be checking for existing users at installkernel stage, since I may never want to do installworld stage, if my kernel doesn't work.

ib32/usr/lib32 -O2 -pipe -std=gnu99 -Qunused-arguments -fstack-protector -Wsystem-headers -Werror -Wall -Wno-format-y2k -W -Wno-unused-parameter -Wstrict-prototypes -Wmissing-prototypes -Wpointer-arith -Wreturn-type -Wcast-qual -Wwrite-strings -Wswitch -Wshadow -Wunused-parameter -Wcast-align -Wchar-subscripts -Winline -Wnested-externs -Wredundant-decls -Wold-style-definition -Wno-pointer-sign -Wno-empty-body -Wno-string-plus-int  -o ldd32 ldd.o sods.o 
--------------------------------------------------------------
>How-To-Repeat:
On the system without "auditdistd" user, try:

svn co http://svn.freebsd.org/base/head
make -j4 buildkernel KERNCONF=GENERIC
make -j4 buildworld
make -j4 installkernel KERNCONF=GENERIC
>Fix:


>Release-Note:
>Audit-Trail:
Responsible-Changed-From-To: freebsd-bugs->bdrewery 
Responsible-Changed-By: bdrewery 
Responsible-Changed-When: Tue Apr 23 07:28:30 CDT 2013 
Responsible-Changed-Why:  
I'll work on fixing this. 

http://www.freebsd.org/cgi/query-pr.cgi?pr=174405 
State-Changed-From-To: open->closed 
State-Changed-By: bdrewery 
State-Changed-When: Tue Apr 23 08:08:26 CDT 2013 
State-Changed-Why:  
Fixed in r249807 

http://www.freebsd.org/cgi/query-pr.cgi?pr=174405 

From: dfilter@FreeBSD.ORG (dfilter service)
To: bug-followup@FreeBSD.org
Cc:  
Subject: Re: misc/174405: commit references a PR
Date: Tue, 23 Apr 2013 13:08:06 +0000 (UTC)

 Author: bdrewery (ports committer)
 Date: Tue Apr 23 13:07:58 2013
 New Revision: 249807
 URL: http://svnweb.freebsd.org/changeset/base/249807
 
 Log:
   Fix installkernel requiring users/groups defined in CHECK_UIDS
   and CHECK_GIDS to exist since r152680. This is only needed for
   installworld. The documented procedure of running mergemaster -p
   to check for missing users is only needed for installworld, not
   for installkernel. This fixes auditdistd incorrectly being
   required for installkernel.
   
   PR:		misc/174405
   Approved by:	bapt
 
 Modified:
   head/Makefile.inc1
 
 Modified: head/Makefile.inc1
 ==============================================================================
 --- head/Makefile.inc1	Tue Apr 23 13:03:17 2013	(r249806)
 +++ head/Makefile.inc1	Tue Apr 23 13:07:58 2013	(r249807)
 @@ -647,7 +647,6 @@ CHECK_GIDS+=	smmsp
  CHECK_UIDS+=	proxy
  CHECK_GIDS+=	proxy authpf
  .endif
 -installcheck: installcheck_UGID
  installcheck_UGID:
  .for uid in ${CHECK_UIDS}
  	@if ! `id -u ${uid} >/dev/null 2>&1`; then \
 @@ -703,7 +702,7 @@ EXTRA_DISTRIBUTIONS+=	lib32
  
  MTREE_MAGIC?=	mtree 2.0
  
 -distributeworld installworld: installcheck
 +distributeworld installworld: installcheck installcheck_UGID
  	mkdir -p ${INSTALLTMP}
  	progs=$$(for prog in ${ITOOLS}; do \
  		if progpath=`which $$prog`; then \
 _______________________________________________
 svn-src-all@freebsd.org mailing list
 http://lists.freebsd.org/mailman/listinfo/svn-src-all
 To unsubscribe, send any mail to "svn-src-all-unsubscribe@freebsd.org"
 

From: dfilter@FreeBSD.ORG (dfilter service)
To: bug-followup@FreeBSD.org
Cc:  
Subject: Re: misc/174405: commit references a PR
Date: Fri, 10 May 2013 13:09:52 +0000 (UTC)

 Author: bdrewery (ports committer)
 Date: Fri May 10 13:09:44 2013
 New Revision: 250452
 URL: http://svnweb.freebsd.org/changeset/base/250452
 
 Log:
   MFC r249807,249893
   
     Fix installkernel requiring users/groups defined in CHECK_UIDS
     and CHECK_GIDS to exist since r152680. This is only needed for
     installworld. The documented procedure of running mergemaster -p
     to check for missing users is only needed for installworld, not
     for installkernel. This fixes auditdistd incorrectly being
     required for installkernel.
   
   PR:		misc/174405
 
 Modified:
   stable/9/Makefile.inc1   (contents, props changed)
 Directory Properties:
   stable/9/   (props changed)
 
 Modified: stable/9/Makefile.inc1
 ==============================================================================
 --- stable/9/Makefile.inc1	Fri May 10 12:49:16 2013	(r250451)
 +++ stable/9/Makefile.inc1	Fri May 10 13:09:44 2013	(r250452)
 @@ -600,6 +600,7 @@ kernel-toolchain: ${TOOLCHAIN_TGTS:N_inc
  # Checks to be sure system is ready for installworld/installkernel.
  #
  installcheck:
 +installcheck_UGID:
  
  #
  # Require DESTDIR to be set if installing for a different architecture or
 @@ -631,7 +632,6 @@ CHECK_GIDS+=	smmsp
  CHECK_UIDS+=	proxy
  CHECK_GIDS+=	proxy authpf
  .endif
 -installcheck: installcheck_UGID
  installcheck_UGID:
  .for uid in ${CHECK_UIDS}
  	@if ! `id -u ${uid} >/dev/null 2>&1`; then \
 @@ -685,7 +685,7 @@ EXTRA_DISTRIBUTIONS+=	games
  EXTRA_DISTRIBUTIONS+=	lib32
  .endif
  
 -distributeworld installworld: installcheck
 +distributeworld installworld: installcheck installcheck_UGID
  	mkdir -p ${INSTALLTMP}
  	progs=$$(for prog in ${ITOOLS}; do \
  		if progpath=`which $$prog`; then \
 _______________________________________________
 svn-src-all@freebsd.org mailing list
 http://lists.freebsd.org/mailman/listinfo/svn-src-all
 To unsubscribe, send any mail to "svn-src-all-unsubscribe@freebsd.org"
 
>Unformatted:
 >>> World build completed on Wed Dec 12 12:48:05 PST 2012
 --------------------------------------------------------------
 xaqbhill40# make -j4 installkernel KERNCONF=GENERIC KODIR=/boot/kernel.new
 ERROR: Required auditdistd user is missing, see /usr/src/UPDATING.
 
 
 
 
