From jack@germanium.xtalwind.net  Sun Feb 20 13:07:07 2000
Return-Path: <jack@germanium.xtalwind.net>
Received: from germanium.xtalwind.net (germanium.xtalwind.net [205.160.242.5])
	by hub.freebsd.org (Postfix) with ESMTP id 17F9D37BF1F
	for <FreeBSD-gnats-submit@freebsd.org>; Sun, 20 Feb 2000 13:07:05 -0800 (PST)
	(envelope-from jack@germanium.xtalwind.net)
Received: (from jack@localhost)
	by germanium.xtalwind.net (8.9.3/8.9.3) id QAA05185;
	Sun, 20 Feb 2000 16:06:58 -0500 (EST)
Message-Id: <200002202106.QAA05185@germanium.xtalwind.net>
Date: Sun, 20 Feb 2000 16:06:58 -0500 (EST)
From: jack@germanium.xtalwind.net
Reply-To: jack@germanium.xtalwind.net
To: FreeBSD-gnats-submit@freebsd.org
Subject: Knob for release/Makefile to prevent deleting docproj distfiles
X-Send-Pr-Version: 3.2

>Number:         16843
>Category:       misc
>Synopsis:       Knob for release/Makefile to prevent deleting docproj distfiles
>Confidential:   no
>Severity:       non-critical
>Priority:       low
>Responsible:    matusita
>State:          closed
>Quarter:        
>Keywords:       
>Date-Required:  
>Class:          change-request
>Submitter-Id:   current-users
>Arrival-Date:   Sun Feb 20 13:10:01 PST 2000
>Closed-Date:    Fri Feb 8 09:08:06 PST 2002
>Last-Modified:  Fri Feb 08 09:12:32 PST 2002
>Originator:     
>Release:        FreeBSD 4.0-CURRENT i386
>Organization:
>Environment:

	FreeBSD 4.0-CURRENT i386

>Description:

    Add NODISTCLEAN variable to prevent deleting distfiles needed for docproj,
	which seem to update frequently, from being deleted so they don't have to 
	be fetched again next time.
	Default action is unchanged.


>How-To-Repeat:


>Fix:
	
--- Makefile.orig	Fri Jan 28 20:15:52 2000
+++ Makefile	Sun Feb 20 15:59:13 2000
@@ -47,6 +47,9 @@
 DOCPORTS=	textproc/docproj
 # Set this to wherever the distfiles required by ${DOCPORTS} live.
 DISTFILES?=	${.CURDIR}/../../ports/distfiles
+# Uncomment this to prevent deleting distfiles in
+# ${CHROOTDIR}/usr/ports/distfiles
+#NODISTCLEAN= yes
 
 DIST_DOCS= ABOUT.TXT ERRATA.TXT LAYOUT.TXT README.TXT HARDWARE.TXT \
            RELNOTES.TXT TROUBLE.TXT UPGRADE.TXT INSTALL.TXT
@@ -578,7 +581,9 @@
 	@ln -f ${CD_DISC1}/kernel ${CD_DISC2}/kernel
 .endif
 .if !defined(NOPORTS)
+.if !defined(NODISTCLEAN)
 	@-rm -rf /usr/ports/distfiles/*
+.endif
 	@mkdir -p ${CD_DISC1}/ports && \
 	  tar --exclude CVS -czf ${CD_DISC1}/ports/ports.tgz -C /usr ports && \
 	  cp ${.CURDIR}/scripts/ports-install.sh ${CD_DISC1}/ports/install.sh \

>Release-Note:
>Audit-Trail:

From: Johan Karlsson <Johan.Karlsson@sm.luth.se>
To: freebsd-gnats-submit@FreeBSD.org
Cc:  
Subject: Re: misc/16843: Knob for release/Makefile to prevent deleting docproj 
 distfiles
Date: Wed, 02 Aug 2000 17:06:08 +0200

 Duplicate of PR 16842
 http://www.FreeBSD.org/cgi/query-pr.cgi?pr=16842
 
 Please close :-)
 /K
 -- 
 Johan Karlsson              Phone : +46 (0)920 720 16 
 Systemteknik, Datalogi      Fax   : +46 (0)920 721 91 
 Lule Tekniska Universitet  E-mail: Johan.Karlsson@SM.LuTH.SE
 S-971 87 LULE, SWEDEN
 

From: Johan Karlsson <k@numeri.campus.luth.se>
To: freebsd-gnats-submit@FreeBSD.org
Cc:  
Subject: Re: misc/16843: Knob for release/Makefile to prevent deleting docproj 
 distfiles
Date: Sat, 05 Aug 2000 10:54:28 +0200

 Do not close this one, PR 16842 has been closed.
 
 /K
 
 
 
Responsible-Changed-From-To: freebsd-bugs->freebsd-doc 
Responsible-Changed-By: sheldonh 
Responsible-Changed-When: Mon Aug 7 03:00:51 PDT 2000 
Responsible-Changed-Why:  
The doc folks will be interested in this one. 

http://www.freebsd.org/cgi/query-pr.cgi?pr=16843 
Responsible-Changed-From-To: freebsd-doc->jkh 
Responsible-Changed-By: nik 
Responsible-Changed-When: Sun Feb 11 09:30:33 PST 2001 
Responsible-Changed-Why:  
This affects release/Makefile, and adds a convenience knob.  I've got no 
objection to it going in, but the release process is your baby. 

http://www.freebsd.org/cgi/query-pr.cgi?pr=16843 
State-Changed-From-To: open->analyzed 
State-Changed-By: matusita 
State-Changed-When: Wed Jan 30 16:00:41 PST 2002 
State-Changed-Why:  
It's similar problem of PR: 34914.  Removing distfiles/ is (supporsed to) 
required to make a ports.tgz tarball, however, in some cases, 
we do *not* want to remove it.  There is already a proposed-fix for 
PR: 34914 -- this PR also can be closed if PR: 34914 is closed. 


Responsible-Changed-From-To: jkh->matusita 
Responsible-Changed-By: matusita 
Responsible-Changed-When: Wed Jan 30 16:00:41 PST 2002 
Responsible-Changed-Why:  
I'll take this since PR: 34914 is handled by me.  jkh was 
agreed to takeover. 

http://www.FreeBSD.org/cgi/query-pr.cgi?pr=16843 
State-Changed-From-To: analyzed->feedback 
State-Changed-By: matusita 
State-Changed-When: Wed Jan 30 17:05:59 PST 2002 
State-Changed-Why:  
I commited src/release/Makefile rev 1.655, which doesn't remove 
directory itself but exclude distfiles from ports.tgz. 

http://www.freebsd.org/cgi/cvsweb.cgi/src/release/Makefile.diff?r1=1.654&r2=1.655 

Even if there is no knob you proposed, but I hope you welcome 
this change.  How do you think about this?  If it is OK, may I 
close this PR? 

http://www.FreeBSD.org/cgi/query-pr.cgi?pr=16843 
State-Changed-From-To: feedback->closed 
State-Changed-By: matusita 
State-Changed-When: Fri Feb 8 09:08:06 PST 2002 
State-Changed-Why:  
The PR submitter already agreed (by private email) that this PR can be 
closed if MFCed.  Just a few minutes before, src/release/Makefile 
rev 1.655 is MFCed as rev 1.536.2.73, so I close this PR.  Thank you. 

http://www.FreeBSD.org/cgi/query-pr.cgi?pr=16843 
>Unformatted:
