From nobody@FreeBSD.org  Tue Apr 24 08:01:34 2012
Return-Path: <nobody@FreeBSD.org>
Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2001:4f8:fff6::34])
	by hub.freebsd.org (Postfix) with ESMTP id C0D33106566C
	for <freebsd-gnats-submit@FreeBSD.org>; Tue, 24 Apr 2012 08:01:34 +0000 (UTC)
	(envelope-from nobody@FreeBSD.org)
Received: from red.freebsd.org (red.freebsd.org [IPv6:2001:4f8:fff6::22])
	by mx1.freebsd.org (Postfix) with ESMTP id AC2348FC08
	for <freebsd-gnats-submit@FreeBSD.org>; Tue, 24 Apr 2012 08:01:34 +0000 (UTC)
Received: from red.freebsd.org (localhost [127.0.0.1])
	by red.freebsd.org (8.14.4/8.14.4) with ESMTP id q3O81YZJ097261
	for <freebsd-gnats-submit@FreeBSD.org>; Tue, 24 Apr 2012 08:01:34 GMT
	(envelope-from nobody@red.freebsd.org)
Received: (from nobody@localhost)
	by red.freebsd.org (8.14.4/8.14.4/Submit) id q3O81YX8097260;
	Tue, 24 Apr 2012 08:01:34 GMT
	(envelope-from nobody)
Message-Id: <201204240801.q3O81YX8097260@red.freebsd.org>
Date: Tue, 24 Apr 2012 08:01:34 GMT
From: Alberto Villa <avilla@FreeBSD.org>
To: freebsd-gnats-submit@FreeBSD.org
Subject: [patch] Remove etc/pam.d/kde module from base system
X-Send-Pr-Version: www-3.1
X-GNATS-Notify:

>Number:         167261
>Category:       misc
>Synopsis:       [patch] Remove etc/pam.d/kde module from base system
>Confidential:   no
>Severity:       non-critical
>Priority:       low
>Responsible:    miwi
>State:          closed
>Quarter:        
>Keywords:       
>Date-Required:  
>Class:          change-request
>Submitter-Id:   current-users
>Arrival-Date:   Tue Apr 24 08:10:08 UTC 2012
>Closed-Date:    Wed May 30 03:12:35 UTC 2012
>Last-Modified:  Wed May 30 03:20:01 UTC 2012
>Originator:     Alberto Villa
>Release:        
>Organization:
>Environment:
>Description:
FreeBSD ships a KDE PAM module (kde) in base, but it's missing support for passwordless login (kde-np), and it doesn't really belong in base system. We have been shipping both modules via security/pam_kde port for six months, so, with my kde@ hat on, I ask to remove the one in base.
>How-To-Repeat:

>Fix:
Well, it's quite trivial, nonetheless I attached a patch. Of course, etc/pam.d/kde has to be `svn rm`'d.

Patch attached with submission follows:

Index: Makefile
===================================================================
--- Makefile	(revision 234197)
+++ Makefile	(working copy)
@@ -7,7 +7,6 @@
 	cron \
 	ftpd \
 	imap \
-	kde \
 	login \
 	other \
 	passwd pop3 \
Index: kde
===================================================================
--- kde	(revision 234197)
+++ kde	(working copy)
@@ -1,19 +0,0 @@
-#
-# $FreeBSD$
-#
-# PAM configuration for the "kde" service
-#
-
-# auth
-#auth		sufficient	pam_krb5.so		no_warn try_first_pass
-#auth		sufficient	pam_ssh.so		no_warn try_first_pass
-auth		required	pam_unix.so		no_warn try_first_pass
-
-# account
-account		required	pam_nologin.so
-#account	required	pam_krb5.so
-account		required	pam_unix.so
-
-# session
-#session	optional	pam_ssh.so		want_agent
-session		required	pam_permit.so


>Release-Note:
>Audit-Trail:
Responsible-Changed-From-To: freebsd-bugs->miwi 
Responsible-Changed-By: miwi 
Responsible-Changed-When: Tue Apr 24 09:03:02 UTC 2012 
Responsible-Changed-Why:  
I'll take it. 

http://www.freebsd.org/cgi/query-pr.cgi?pr=167261 

From: Alberto Villa <avilla@freebsd.org>
To: bug-followup@freebsd.org, avilla@freebsd.org
Cc:  
Subject: Re: misc/167261: [patch] Remove etc/pam.d/kde module from base system
Date: Tue, 24 Apr 2012 11:14:53 +0200

 --nextPart13507627.WV5dC6XyM3
 Content-Transfer-Encoding: 7Bit
 Content-Type: text/plain; charset="us-ascii"
 
 Oops. I forgot to add the line to ObsoleteFiles.inc...
 -- 
 Alberto Villa, FreeBSD committer <avilla@FreeBSD.org>
 http://people.FreeBSD.org/~avilla
 
 Great American Axiom:
 	Some is good, more is better, too much is just right.
 
 --nextPart13507627.WV5dC6XyM3
 Content-Type: application/pgp-signature; name="signature.asc"
 Content-Description: This is a digitally signed message part.
 
 -----BEGIN PGP SIGNATURE-----
 Version: GnuPG v2.0.19 (FreeBSD)
 
 iJwEAAECAAYFAk+Wbw0ACgkQ3xiC6kQ1CosGIAP/YPT7cRehIa4kzcFztycndqM+
 eFmIGrYvD6nROUzUS+be3d8sxX1kMcq27Ei2UQ7k/HROZpdnXCiqMxsRe2FKvfal
 0MFOtlff0kXxUpUmWDyRMN5IqOHS6flZaaqtbvPgHr6xM0h+2+b+1ZdThO5PEdGn
 zb3zhyFQpHIo6e2Nwx8=
 =tJbT
 -----END PGP SIGNATURE-----
 
 --nextPart13507627.WV5dC6XyM3--
 
State-Changed-From-To: open->closed 
State-Changed-By: miwi 
State-Changed-When: Wed May 30 03:12:33 UTC 2012 
State-Changed-Why:  
Committed. Thanks! 

http://www.freebsd.org/cgi/query-pr.cgi?pr=167261 

From: dfilter@FreeBSD.ORG (dfilter service)
To: bug-followup@FreeBSD.org
Cc:  
Subject: Re: misc/167261: commit references a PR
Date: Wed, 30 May 2012 03:10:38 +0000 (UTC)

 Author: miwi
 Date: Wed May 30 03:10:22 2012
 New Revision: 236281
 URL: http://svn.freebsd.org/changeset/base/236281
 
 Log:
   - FreeBSD ships a KDE PAM module in base, but it's missing support for passwordless login (kde-np),
     and it doesn't really belong in base system.
   
   PR:		misc/167261
   Submitted by:	avilla@
   Approved by:	rwatson (mentor)
   MFC after:	3 days
 
 Deleted:
   head/etc/pam.d/kde
 Modified:
   head/ObsoleteFiles.inc
   head/etc/pam.d/Makefile
 
 Modified: head/ObsoleteFiles.inc
 ==============================================================================
 --- head/ObsoleteFiles.inc	Wed May 30 02:41:09 2012	(r236280)
 +++ head/ObsoleteFiles.inc	Wed May 30 03:10:22 2012	(r236281)
 @@ -38,6 +38,8 @@
  #   xargs -n1 | sort | uniq -d;
  # done
  
 +# 20120530: kde pam lives now in ports
 +OLD_FILES+=/etc/pam.d/kde
  # 20120505: new clang import installed a redundant internal header
  OLD_FILES+=usr/include/clang/3.1/stdalign.h
  # 20120428: MD2 removed from libmd
 
 Modified: head/etc/pam.d/Makefile
 ==============================================================================
 --- head/etc/pam.d/Makefile	Wed May 30 02:41:09 2012	(r236280)
 +++ head/etc/pam.d/Makefile	Wed May 30 03:10:22 2012	(r236281)
 @@ -7,7 +7,6 @@ FILES=	README \
  	cron \
  	ftpd \
  	imap \
 -	kde \
  	login \
  	other \
  	passwd pop3 \
 _______________________________________________
 svn-src-all@freebsd.org mailing list
 http://lists.freebsd.org/mailman/listinfo/svn-src-all
 To unsubscribe, send any mail to "svn-src-all-unsubscribe@freebsd.org"
 
>Unformatted:
