From nobody@FreeBSD.org  Fri Sep 30 22:15:20 2011
Return-Path: <nobody@FreeBSD.org>
Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2001:4f8:fff6::34])
	by hub.freebsd.org (Postfix) with ESMTP id D319E1065674
	for <freebsd-gnats-submit@FreeBSD.org>; Fri, 30 Sep 2011 22:15:20 +0000 (UTC)
	(envelope-from nobody@FreeBSD.org)
Received: from red.freebsd.org (red.freebsd.org [IPv6:2001:4f8:fff6::22])
	by mx1.freebsd.org (Postfix) with ESMTP id A9B268FC16
	for <freebsd-gnats-submit@FreeBSD.org>; Fri, 30 Sep 2011 22:15:20 +0000 (UTC)
Received: from red.freebsd.org (localhost [127.0.0.1])
	by red.freebsd.org (8.14.4/8.14.4) with ESMTP id p8UMFKwe038461
	for <freebsd-gnats-submit@FreeBSD.org>; Fri, 30 Sep 2011 22:15:20 GMT
	(envelope-from nobody@red.freebsd.org)
Received: (from nobody@localhost)
	by red.freebsd.org (8.14.4/8.14.4/Submit) id p8UMFKH2038460;
	Fri, 30 Sep 2011 22:15:20 GMT
	(envelope-from nobody)
Message-Id: <201109302215.p8UMFKH2038460@red.freebsd.org>
Date: Fri, 30 Sep 2011 22:15:20 GMT
From: Giovanni Trematerra <gianni@FreeBSD.org>
To: freebsd-gnats-submit@FreeBSD.org
Subject: uninitialized variables on some regression test programs
X-Send-Pr-Version: www-3.1
X-GNATS-Notify:

>Number:         161175
>Category:       misc
>Synopsis:       [tools] [patch] uninitialized variables on some regression test programs
>Confidential:   no
>Severity:       non-critical
>Priority:       low
>Responsible:    eadler
>State:          closed
>Quarter:        
>Keywords:       
>Date-Required:  
>Class:          sw-bug
>Submitter-Id:   current-users
>Arrival-Date:   Fri Sep 30 22:20:02 UTC 2011
>Closed-Date:    Thu Feb 16 19:55:33 UTC 2012
>Last-Modified:  Fri Mar 16 03:20:05 UTC 2012
>Originator:     Giovanni Trematerra
>Release:        10-CURRENT
>Organization:
>Environment:
>Description:
Some regression tests in tools/regression/pipe has some uninitialized variables that make the test fails.
>How-To-Repeat:
cd /usr/src/tools/regression/pipe
cc -O2 -o pipe-wraparound pipe-wraparound.c
cc -O2 -o pipe-reverse pipe-reverse.c
cc -O2 -o pipe-fstatbug pipe-fstatbug.c

./pipe-wraparound
./pipe-reverse
./pipe-fstatbug
>Fix:
Index: tools/regression/pipe/pipe-reverse.c
===================================================================
--- tools/regression/pipe/pipe-reverse.c	(revision 225817)
+++ tools/regression/pipe/pipe-reverse.c	(working copy)
@@ -44,6 +44,7 @@ struct stat status;
 pid_t new_pid;
 
 buggy = 0;
+total = 0;
 
 error = pipe(desc);
 
@@ -52,7 +53,7 @@ if (error)
 
 buffer[0] = 'A';
 
-for (i = 0; i < 65535; i++) {
+for (i = 1; i < 65535; i++) {
 	buffer[i] = buffer[i - 1] + 1;
 	if (buffer[i] > 'Z')
 		buffer[i] = 'A';
Index: tools/regression/pipe/pipe-fstatbug.c
===================================================================
--- tools/regression/pipe/pipe-fstatbug.c	(revision 225817)
+++ tools/regression/pipe/pipe-fstatbug.c	(working copy)
@@ -41,7 +41,7 @@ int main (void)
 {
 char buffer[32768], buffer2[32768];
 int desc[2];
-int error, successes;
+int error, successes = 0;
 struct stat status;
 pid_t new_pid;
 
Index: tools/regression/pipe/pipe-wraparound.c
===================================================================
--- tools/regression/pipe/pipe-wraparound.c	(revision 225817)
+++ tools/regression/pipe/pipe-wraparound.c	(working copy)
@@ -44,6 +44,7 @@ struct stat status;
 pid_t new_pid;
 
 buggy = 0;
+total = 0;
 
 error = pipe(desc);
 
@@ -52,7 +53,7 @@ if (error)
 
 buffer[0] = 'A';
 
-for (i = 0; i < 32768; i++) {
+for (i = 1; i < 32768; i++) {
 	buffer[i] = buffer[i - 1] + 1;
 	if (buffer[i] > 'Z')
 		buffer[i] = 'A';


>Release-Note:
>Audit-Trail:
Responsible-Changed-From-To: freebsd-bugs->eadler 
Responsible-Changed-By: eadler 
Responsible-Changed-When: Fri Dec 2 17:52:13 UTC 2011 
Responsible-Changed-Why:  
I'll take it. 

http://www.freebsd.org/cgi/query-pr.cgi?pr=161175 
State-Changed-From-To: open->patched 
State-Changed-By: eadler 
State-Changed-When: Mon Dec 5 04:24:02 UTC 2011 
State-Changed-Why:  
commited in r228274 

http://www.freebsd.org/cgi/query-pr.cgi?pr=161175 

From: dfilter@FreeBSD.ORG (dfilter service)
To: bug-followup@FreeBSD.org
Cc:  
Subject: Re: misc/161175: commit references a PR
Date: Mon,  5 Dec 2011 04:20:23 +0000 (UTC)

 Author: eadler (ports committer)
 Date: Mon Dec  5 04:20:13 2011
 New Revision: 228274
 URL: http://svn.freebsd.org/changeset/base/228274
 
 Log:
   Fix some uninitialized variables in pipe regression tests that result in
   failure.
   
   PR:		misc/161175
   Submitted by:	gianni@
   Approved by:	nwhitehorn@
   MFC after:	1 week
 
 Modified:
   head/tools/regression/pipe/pipe-fstatbug.c
   head/tools/regression/pipe/pipe-reverse.c
   head/tools/regression/pipe/pipe-wraparound.c
 
 Modified: head/tools/regression/pipe/pipe-fstatbug.c
 ==============================================================================
 --- head/tools/regression/pipe/pipe-fstatbug.c	Mon Dec  5 03:18:40 2011	(r228273)
 +++ head/tools/regression/pipe/pipe-fstatbug.c	Mon Dec  5 04:20:13 2011	(r228274)
 @@ -41,7 +41,7 @@ int main (void)
  {
  char buffer[32768], buffer2[32768];
  int desc[2];
 -int error, successes;
 +int error, successes = 0;
  struct stat status;
  pid_t new_pid;
  
 
 Modified: head/tools/regression/pipe/pipe-reverse.c
 ==============================================================================
 --- head/tools/regression/pipe/pipe-reverse.c	Mon Dec  5 03:18:40 2011	(r228273)
 +++ head/tools/regression/pipe/pipe-reverse.c	Mon Dec  5 04:20:13 2011	(r228274)
 @@ -44,6 +44,7 @@ struct stat status;
  pid_t new_pid;
  
  buggy = 0;
 +total = 0;
  
  error = pipe(desc);
  
 @@ -52,7 +53,7 @@ if (error)
  
  buffer[0] = 'A';
  
 -for (i = 0; i < 65535; i++) {
 +for (i = 1; i < 65535; i++) {
  	buffer[i] = buffer[i - 1] + 1;
  	if (buffer[i] > 'Z')
  		buffer[i] = 'A';
 
 Modified: head/tools/regression/pipe/pipe-wraparound.c
 ==============================================================================
 --- head/tools/regression/pipe/pipe-wraparound.c	Mon Dec  5 03:18:40 2011	(r228273)
 +++ head/tools/regression/pipe/pipe-wraparound.c	Mon Dec  5 04:20:13 2011	(r228274)
 @@ -44,6 +44,7 @@ struct stat status;
  pid_t new_pid;
  
  buggy = 0;
 +total = 0;
  
  error = pipe(desc);
  
 @@ -52,7 +53,7 @@ if (error)
  
  buffer[0] = 'A';
  
 -for (i = 0; i < 32768; i++) {
 +for (i = 1; i < 32768; i++) {
  	buffer[i] = buffer[i - 1] + 1;
  	if (buffer[i] > 'Z')
  		buffer[i] = 'A';
 _______________________________________________
 svn-src-all@freebsd.org mailing list
 http://lists.freebsd.org/mailman/listinfo/svn-src-all
 To unsubscribe, send any mail to "svn-src-all-unsubscribe@freebsd.org"
 

From: dfilter@FreeBSD.ORG (dfilter service)
To: bug-followup@FreeBSD.org
Cc:  
Subject: Re: misc/161175: commit references a PR
Date: Thu, 16 Feb 2012 19:40:15 +0000 (UTC)

 Author: eadler
 Date: Thu Feb 16 19:39:49 2012
 New Revision: 231832
 URL: http://svn.freebsd.org/changeset/base/231832
 
 Log:
   MFC r228274:
   	 - Fix some uninitialized variables in pipe regression tests that result in failure.
   
   PR:		misc/161175
   Approved by:	cperciva
 
 Modified:
   stable/9/tools/regression/pipe/pipe-fstatbug.c
   stable/9/tools/regression/pipe/pipe-reverse.c
   stable/9/tools/regression/pipe/pipe-wraparound.c
 Directory Properties:
   stable/9/tools/regression/pipe/   (props changed)
 
 Modified: stable/9/tools/regression/pipe/pipe-fstatbug.c
 ==============================================================================
 --- stable/9/tools/regression/pipe/pipe-fstatbug.c	Thu Feb 16 19:10:01 2012	(r231831)
 +++ stable/9/tools/regression/pipe/pipe-fstatbug.c	Thu Feb 16 19:39:49 2012	(r231832)
 @@ -41,7 +41,7 @@ int main (void)
  {
  char buffer[32768], buffer2[32768];
  int desc[2];
 -int error, successes;
 +int error, successes = 0;
  struct stat status;
  pid_t new_pid;
  
 
 Modified: stable/9/tools/regression/pipe/pipe-reverse.c
 ==============================================================================
 --- stable/9/tools/regression/pipe/pipe-reverse.c	Thu Feb 16 19:10:01 2012	(r231831)
 +++ stable/9/tools/regression/pipe/pipe-reverse.c	Thu Feb 16 19:39:49 2012	(r231832)
 @@ -44,6 +44,7 @@ struct stat status;
  pid_t new_pid;
  
  buggy = 0;
 +total = 0;
  
  error = pipe(desc);
  
 @@ -52,7 +53,7 @@ if (error)
  
  buffer[0] = 'A';
  
 -for (i = 0; i < 65535; i++) {
 +for (i = 1; i < 65535; i++) {
  	buffer[i] = buffer[i - 1] + 1;
  	if (buffer[i] > 'Z')
  		buffer[i] = 'A';
 
 Modified: stable/9/tools/regression/pipe/pipe-wraparound.c
 ==============================================================================
 --- stable/9/tools/regression/pipe/pipe-wraparound.c	Thu Feb 16 19:10:01 2012	(r231831)
 +++ stable/9/tools/regression/pipe/pipe-wraparound.c	Thu Feb 16 19:39:49 2012	(r231832)
 @@ -44,6 +44,7 @@ struct stat status;
  pid_t new_pid;
  
  buggy = 0;
 +total = 0;
  
  error = pipe(desc);
  
 @@ -52,7 +53,7 @@ if (error)
  
  buffer[0] = 'A';
  
 -for (i = 0; i < 32768; i++) {
 +for (i = 1; i < 32768; i++) {
  	buffer[i] = buffer[i - 1] + 1;
  	if (buffer[i] > 'Z')
  		buffer[i] = 'A';
 _______________________________________________
 svn-src-all@freebsd.org mailing list
 http://lists.freebsd.org/mailman/listinfo/svn-src-all
 To unsubscribe, send any mail to "svn-src-all-unsubscribe@freebsd.org"
 

From: dfilter@FreeBSD.ORG (dfilter service)
To: bug-followup@FreeBSD.org
Cc:  
Subject: Re: misc/161175: commit references a PR
Date: Thu, 16 Feb 2012 19:40:36 +0000 (UTC)

 Author: eadler
 Date: Thu Feb 16 19:40:17 2012
 New Revision: 231833
 URL: http://svn.freebsd.org/changeset/base/231833
 
 Log:
   MFC r228274:
   	 - Fix some uninitialized variables in pipe regression tests that result in failure.
   
   PR:		misc/161175
   Approved by:	cperciva
 
 Modified:
   stable/7/tools/regression/pipe/pipe-fstatbug.c
   stable/7/tools/regression/pipe/pipe-reverse.c
   stable/7/tools/regression/pipe/pipe-wraparound.c
 Directory Properties:
   stable/7/tools/regression/pipe/   (props changed)
 
 Modified: stable/7/tools/regression/pipe/pipe-fstatbug.c
 ==============================================================================
 --- stable/7/tools/regression/pipe/pipe-fstatbug.c	Thu Feb 16 19:39:49 2012	(r231832)
 +++ stable/7/tools/regression/pipe/pipe-fstatbug.c	Thu Feb 16 19:40:17 2012	(r231833)
 @@ -41,7 +41,7 @@ int main (void)
  {
  char buffer[32768], buffer2[32768];
  int desc[2];
 -int error, successes;
 +int error, successes = 0;
  struct stat status;
  pid_t new_pid;
  
 
 Modified: stable/7/tools/regression/pipe/pipe-reverse.c
 ==============================================================================
 --- stable/7/tools/regression/pipe/pipe-reverse.c	Thu Feb 16 19:39:49 2012	(r231832)
 +++ stable/7/tools/regression/pipe/pipe-reverse.c	Thu Feb 16 19:40:17 2012	(r231833)
 @@ -44,6 +44,7 @@ struct stat status;
  pid_t new_pid;
  
  buggy = 0;
 +total = 0;
  
  error = pipe(desc);
  
 @@ -52,7 +53,7 @@ if (error)
  
  buffer[0] = 'A';
  
 -for (i = 0; i < 65535; i++) {
 +for (i = 1; i < 65535; i++) {
  	buffer[i] = buffer[i - 1] + 1;
  	if (buffer[i] > 'Z')
  		buffer[i] = 'A';
 
 Modified: stable/7/tools/regression/pipe/pipe-wraparound.c
 ==============================================================================
 --- stable/7/tools/regression/pipe/pipe-wraparound.c	Thu Feb 16 19:39:49 2012	(r231832)
 +++ stable/7/tools/regression/pipe/pipe-wraparound.c	Thu Feb 16 19:40:17 2012	(r231833)
 @@ -44,6 +44,7 @@ struct stat status;
  pid_t new_pid;
  
  buggy = 0;
 +total = 0;
  
  error = pipe(desc);
  
 @@ -52,7 +53,7 @@ if (error)
  
  buffer[0] = 'A';
  
 -for (i = 0; i < 32768; i++) {
 +for (i = 1; i < 32768; i++) {
  	buffer[i] = buffer[i - 1] + 1;
  	if (buffer[i] > 'Z')
  		buffer[i] = 'A';
 _______________________________________________
 svn-src-all@freebsd.org mailing list
 http://lists.freebsd.org/mailman/listinfo/svn-src-all
 To unsubscribe, send any mail to "svn-src-all-unsubscribe@freebsd.org"
 
State-Changed-From-To: patched->closed 
State-Changed-By: eadler 
State-Changed-When: Thu Feb 16 19:55:32 UTC 2012 
State-Changed-Why:  
committed to 7 and 9; awaiting re approval for 8 

http://www.freebsd.org/cgi/query-pr.cgi?pr=161175 

From: dfilter@FreeBSD.ORG (dfilter service)
To: bug-followup@FreeBSD.org
Cc:  
Subject: Re: misc/161175: commit references a PR
Date: Fri, 16 Mar 2012 03:16:26 +0000 (UTC)

 Author: eadler
 Date: Fri Mar 16 03:16:10 2012
 New Revision: 233020
 URL: http://svn.freebsd.org/changeset/base/233020
 
 Log:
   MFC r228274:
   	 - Fix some uninitialized variables in pipe regression tests that result in failure.
   
   PR:		misc/161175
   Approved by:	cperciva
 
 Modified:
   stable/8/tools/regression/pipe/pipe-fstatbug.c
   stable/8/tools/regression/pipe/pipe-reverse.c
   stable/8/tools/regression/pipe/pipe-wraparound.c
 Directory Properties:
   stable/8/tools/regression/pipe/   (props changed)
 
 Modified: stable/8/tools/regression/pipe/pipe-fstatbug.c
 ==============================================================================
 --- stable/8/tools/regression/pipe/pipe-fstatbug.c	Thu Mar 15 23:53:24 2012	(r233019)
 +++ stable/8/tools/regression/pipe/pipe-fstatbug.c	Fri Mar 16 03:16:10 2012	(r233020)
 @@ -41,7 +41,7 @@ int main (void)
  {
  char buffer[32768], buffer2[32768];
  int desc[2];
 -int error, successes;
 +int error, successes = 0;
  struct stat status;
  pid_t new_pid;
  
 
 Modified: stable/8/tools/regression/pipe/pipe-reverse.c
 ==============================================================================
 --- stable/8/tools/regression/pipe/pipe-reverse.c	Thu Mar 15 23:53:24 2012	(r233019)
 +++ stable/8/tools/regression/pipe/pipe-reverse.c	Fri Mar 16 03:16:10 2012	(r233020)
 @@ -44,6 +44,7 @@ struct stat status;
  pid_t new_pid;
  
  buggy = 0;
 +total = 0;
  
  error = pipe(desc);
  
 @@ -52,7 +53,7 @@ if (error)
  
  buffer[0] = 'A';
  
 -for (i = 0; i < 65535; i++) {
 +for (i = 1; i < 65535; i++) {
  	buffer[i] = buffer[i - 1] + 1;
  	if (buffer[i] > 'Z')
  		buffer[i] = 'A';
 
 Modified: stable/8/tools/regression/pipe/pipe-wraparound.c
 ==============================================================================
 --- stable/8/tools/regression/pipe/pipe-wraparound.c	Thu Mar 15 23:53:24 2012	(r233019)
 +++ stable/8/tools/regression/pipe/pipe-wraparound.c	Fri Mar 16 03:16:10 2012	(r233020)
 @@ -44,6 +44,7 @@ struct stat status;
  pid_t new_pid;
  
  buggy = 0;
 +total = 0;
  
  error = pipe(desc);
  
 @@ -52,7 +53,7 @@ if (error)
  
  buffer[0] = 'A';
  
 -for (i = 0; i < 32768; i++) {
 +for (i = 1; i < 32768; i++) {
  	buffer[i] = buffer[i - 1] + 1;
  	if (buffer[i] > 'Z')
  		buffer[i] = 'A';
 _______________________________________________
 svn-src-all@freebsd.org mailing list
 http://lists.freebsd.org/mailman/listinfo/svn-src-all
 To unsubscribe, send any mail to "svn-src-all-unsubscribe@freebsd.org"
 
>Unformatted:
