From nobody@FreeBSD.org  Wed Sep 21 12:51:35 2011
Return-Path: <nobody@FreeBSD.org>
Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2001:4f8:fff6::34])
	by hub.freebsd.org (Postfix) with ESMTP id EF55F1065670
	for <freebsd-gnats-submit@FreeBSD.org>; Wed, 21 Sep 2011 12:51:35 +0000 (UTC)
	(envelope-from nobody@FreeBSD.org)
Received: from red.freebsd.org (red.freebsd.org [IPv6:2001:4f8:fff6::22])
	by mx1.freebsd.org (Postfix) with ESMTP id DF8E98FC15
	for <freebsd-gnats-submit@FreeBSD.org>; Wed, 21 Sep 2011 12:51:35 +0000 (UTC)
Received: from red.freebsd.org (localhost [127.0.0.1])
	by red.freebsd.org (8.14.4/8.14.4) with ESMTP id p8LCpZ3u003993
	for <freebsd-gnats-submit@FreeBSD.org>; Wed, 21 Sep 2011 12:51:35 GMT
	(envelope-from nobody@red.freebsd.org)
Received: (from nobody@localhost)
	by red.freebsd.org (8.14.4/8.14.4/Submit) id p8LCpZBa003992;
	Wed, 21 Sep 2011 12:51:35 GMT
	(envelope-from nobody)
Message-Id: <201109211251.p8LCpZBa003992@red.freebsd.org>
Date: Wed, 21 Sep 2011 12:51:35 GMT
From: Henning Petersen <henning.petersen@t-online.de>
To: freebsd-gnats-submit@FreeBSD.org
Subject: Swapped arguments in cap_test_capmode.c
X-Send-Pr-Version: www-3.1
X-GNATS-Notify:

>Number:         160867
>Category:       misc
>Synopsis:       [tools] [patch] Swapped arguments in cap_test_capmode.c
>Confidential:   no
>Severity:       non-critical
>Priority:       medium
>Responsible:    brueffer
>State:          closed
>Quarter:        
>Keywords:       
>Date-Required:  
>Class:          sw-bug
>Submitter-Id:   current-users
>Arrival-Date:   Wed Sep 21 13:00:17 UTC 2011
>Closed-Date:    Thu Mar 08 11:41:12 CET 2012
>Last-Modified:  Thu Mar 08 11:41:12 CET 2012
>Originator:     Henning Petersen
>Release:        
>Organization:
>Environment:
>Description:
Swapped arguments in cap_test_capmode.c .
>How-To-Repeat:

>Fix:
diff -u -r1.2 cap_test_capmode.c
--- tools/regression/security/cap_test/cap_test_capmode.c	4 Aug 2011 14:20:13 -0000	1.2
+++ tools/regression/security/cap_test/cap_test_capmode.c	21 Sep 2011 08:53:46 -0000
@@ -117,7 +117,7 @@
 	CHECK_SYSCALL_SUCCEEDS(close, fd_close);
 	CHECK_SYSCALL_SUCCEEDS(dup, fd_file);
 	CHECK_SYSCALL_SUCCEEDS(fstat, fd_file, &sb);
-	CHECK_SYSCALL_SUCCEEDS(lseek, fd_file, SEEK_SET, 0);
+	CHECK_SYSCALL_SUCCEEDS(lseek, fd_file, 0, SEEK_SET);
 	CHECK_SYSCALL_SUCCEEDS(msync, &fd_file, 8192, MS_ASYNC);
 	CHECK_SYSCALL_SUCCEEDS(profil, NULL, 0, 0, 0);
 	CHECK_SYSCALL_SUCCEEDS(read, fd_file, &ch, sizeof(ch));


Patch attached with submission follows:

diff -u -r1.2 cap_test_capmode.c
--- tools/regression/security/cap_test/cap_test_capmode.c	4 Aug 2011 14:20:13 -0000	1.2
+++ tools/regression/security/cap_test/cap_test_capmode.c	21 Sep 2011 08:53:46 -0000
@@ -117,7 +117,7 @@
 	CHECK_SYSCALL_SUCCEEDS(close, fd_close);
 	CHECK_SYSCALL_SUCCEEDS(dup, fd_file);
 	CHECK_SYSCALL_SUCCEEDS(fstat, fd_file, &sb);
-	CHECK_SYSCALL_SUCCEEDS(lseek, fd_file, SEEK_SET, 0);
+	CHECK_SYSCALL_SUCCEEDS(lseek, fd_file, 0, SEEK_SET);
 	CHECK_SYSCALL_SUCCEEDS(msync, &fd_file, 8192, MS_ASYNC);
 	CHECK_SYSCALL_SUCCEEDS(profil, NULL, 0, 0, 0);
 	CHECK_SYSCALL_SUCCEEDS(read, fd_file, &ch, sizeof(ch));


>Release-Note:
>Audit-Trail:
State-Changed-From-To: open->patched 
State-Changed-By: brueffer 
State-Changed-When: Wed Feb 29 20:50:58 CET 2012 
State-Changed-Why:  
Fixed, thanks! 


Responsible-Changed-From-To: freebsd-bugs->brueffer 
Responsible-Changed-By: brueffer 
Responsible-Changed-When: Wed Feb 29 20:50:58 CET 2012 
Responsible-Changed-Why:  
MFC reminder. 

http://www.freebsd.org/cgi/query-pr.cgi?pr=160867 

From: dfilter@FreeBSD.ORG (dfilter service)
To: bug-followup@FreeBSD.org
Cc:  
Subject: Re: misc/160867: commit references a PR
Date: Wed, 29 Feb 2012 19:51:37 +0000 (UTC)

 Author: brueffer
 Date: Wed Feb 29 19:50:49 2012
 New Revision: 232312
 URL: http://svn.freebsd.org/changeset/base/232312
 
 Log:
   Fix order of arguments to lseek().
   
   PR:		160867
   Submitted by:	Henning Petersen <henning.petersen@t-online.de>
   MFC after:	1 week
 
 Modified:
   head/tools/regression/security/cap_test/cap_test_capmode.c
 
 Modified: head/tools/regression/security/cap_test/cap_test_capmode.c
 ==============================================================================
 --- head/tools/regression/security/cap_test/cap_test_capmode.c	Wed Feb 29 19:18:32 2012	(r232311)
 +++ head/tools/regression/security/cap_test/cap_test_capmode.c	Wed Feb 29 19:50:49 2012	(r232312)
 @@ -117,7 +117,7 @@ test_capmode(void)
  	CHECK_SYSCALL_SUCCEEDS(close, fd_close);
  	CHECK_SYSCALL_SUCCEEDS(dup, fd_file);
  	CHECK_SYSCALL_SUCCEEDS(fstat, fd_file, &sb);
 -	CHECK_SYSCALL_SUCCEEDS(lseek, fd_file, SEEK_SET, 0);
 +	CHECK_SYSCALL_SUCCEEDS(lseek, fd_file, 0, SEEK_SET);
  	CHECK_SYSCALL_SUCCEEDS(msync, &fd_file, 8192, MS_ASYNC);
  	CHECK_SYSCALL_SUCCEEDS(profil, NULL, 0, 0, 0);
  	CHECK_SYSCALL_SUCCEEDS(read, fd_file, &ch, sizeof(ch));
 _______________________________________________
 svn-src-all@freebsd.org mailing list
 http://lists.freebsd.org/mailman/listinfo/svn-src-all
 To unsubscribe, send any mail to "svn-src-all-unsubscribe@freebsd.org"
 
State-Changed-From-To: patched->closed 
State-Changed-By: brueffer 
State-Changed-When: Thu Mar 8 11:40:41 CET 2012 
State-Changed-Why:  
MFC done. 

http://www.freebsd.org/cgi/query-pr.cgi?pr=160867 
>Unformatted:
