From nobody@FreeBSD.org  Wed Sep 21 12:46:53 2011
Return-Path: <nobody@FreeBSD.org>
Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2001:4f8:fff6::34])
	by hub.freebsd.org (Postfix) with ESMTP id 53FC5106564A
	for <freebsd-gnats-submit@FreeBSD.org>; Wed, 21 Sep 2011 12:46:53 +0000 (UTC)
	(envelope-from nobody@FreeBSD.org)
Received: from red.freebsd.org (red.freebsd.org [IPv6:2001:4f8:fff6::22])
	by mx1.freebsd.org (Postfix) with ESMTP id 4450E8FC08
	for <freebsd-gnats-submit@FreeBSD.org>; Wed, 21 Sep 2011 12:46:53 +0000 (UTC)
Received: from red.freebsd.org (localhost [127.0.0.1])
	by red.freebsd.org (8.14.4/8.14.4) with ESMTP id p8LCkqpg003231
	for <freebsd-gnats-submit@FreeBSD.org>; Wed, 21 Sep 2011 12:46:52 GMT
	(envelope-from nobody@red.freebsd.org)
Received: (from nobody@localhost)
	by red.freebsd.org (8.14.4/8.14.4/Submit) id p8LCkq3G003230;
	Wed, 21 Sep 2011 12:46:52 GMT
	(envelope-from nobody)
Message-Id: <201109211246.p8LCkq3G003230@red.freebsd.org>
Date: Wed, 21 Sep 2011 12:46:52 GMT
From: Henning Petersen <henning.petersen@t-online.de>
To: freebsd-gnats-submit@FreeBSD.org
Subject: Swapped arguments in fifo_misc.c
X-Send-Pr-Version: www-3.1
X-GNATS-Notify:

>Number:         160866
>Category:       misc
>Synopsis:       [tools] [patch] Swapped arguments in fifo_misc.c
>Confidential:   no
>Severity:       non-critical
>Priority:       medium
>Responsible:    jilles
>State:          closed
>Quarter:        
>Keywords:       
>Date-Required:  
>Class:          sw-bug
>Submitter-Id:   current-users
>Arrival-Date:   Wed Sep 21 12:50:05 UTC 2011
>Closed-Date:    Fri Jan 20 16:36:49 UTC 2012
>Last-Modified:  Fri Jan 20 16:40:13 UTC 2012
>Originator:     Henning Petersen
>Release:        FreeBSD-current
>Organization:
>Environment:
>Description:
Swapped arguments in fifo_misc.c .
>How-To-Repeat:

>Fix:
diff -u -r1.6 fifo_misc.c
--- tools/regression/fifo/fifo_misc/fifo_misc.c	31 Dec 2009 20:29:58 -0000	1.6
+++ tools/regression/fifo/fifo_misc/fifo_misc.c	21 Sep 2011 08:50:14 -0000
@@ -115,7 +115,7 @@
 		exit(-1);
 	}
 
-	if (lseek(reader_fd, SEEK_CUR, 1) >= 0) {
+	if (lseek(reader_fd, 1, SEEK_CUR) >= 0) {
 		warnx("%s: lseek succeeded instead of returning ESPIPE",
 		    __func__);
 		cleanfifo("testfifo", reader_fd, writer_fd);


Patch attached with submission follows:

diff -u -r1.6 fifo_misc.c
--- tools/regression/fifo/fifo_misc/fifo_misc.c	31 Dec 2009 20:29:58 -0000	1.6
+++ tools/regression/fifo/fifo_misc/fifo_misc.c	21 Sep 2011 08:50:14 -0000
@@ -115,7 +115,7 @@
 		exit(-1);
 	}
 
-	if (lseek(reader_fd, SEEK_CUR, 1) >= 0) {
+	if (lseek(reader_fd, 1, SEEK_CUR) >= 0) {
 		warnx("%s: lseek succeeded instead of returning ESPIPE",
 		    __func__);
 		cleanfifo("testfifo", reader_fd, writer_fd);

>Release-Note:
>Audit-Trail:
State-Changed-From-To: open->patched 
State-Changed-By: pluknet 
State-Changed-When: Mon Nov 7 14:36:24 UTC 2011 
State-Changed-Why:  
Committed to HEAD. 


Responsible-Changed-From-To: freebsd-bugs->jilles 
Responsible-Changed-By: pluknet 
Responsible-Changed-When: Mon Nov 7 14:36:24 UTC 2011 
Responsible-Changed-Why:  
Reassign to committer. 

http://www.freebsd.org/cgi/query-pr.cgi?pr=160866 

From: dfilter@FreeBSD.ORG (dfilter service)
To: bug-followup@FreeBSD.org
Cc:  
Subject: Re: misc/160866: commit references a PR
Date: Fri, 20 Jan 2012 16:29:26 +0000 (UTC)

 Author: jilles
 Date: Fri Jan 20 16:29:17 2012
 New Revision: 230384
 URL: http://svn.freebsd.org/changeset/base/230384
 
 Log:
   MFC r227124: fifo_misc test: Fix swapped lseek arguments.
   
   It worked regardless because SEEK_CUR happens to be 1.
   
   PR:		misc/160866
 
 Modified:
   stable/9/tools/regression/fifo/fifo_misc/fifo_misc.c
 Directory Properties:
   stable/9/tools/regression/fifo/   (props changed)
 
 Modified: stable/9/tools/regression/fifo/fifo_misc/fifo_misc.c
 ==============================================================================
 --- stable/9/tools/regression/fifo/fifo_misc/fifo_misc.c	Fri Jan 20 15:46:46 2012	(r230383)
 +++ stable/9/tools/regression/fifo/fifo_misc/fifo_misc.c	Fri Jan 20 16:29:17 2012	(r230384)
 @@ -115,7 +115,7 @@ test_lseek(void)
  		exit(-1);
  	}
  
 -	if (lseek(reader_fd, SEEK_CUR, 1) >= 0) {
 +	if (lseek(reader_fd, 1, SEEK_CUR) >= 0) {
  		warnx("%s: lseek succeeded instead of returning ESPIPE",
  		    __func__);
  		cleanfifo("testfifo", reader_fd, writer_fd);
 _______________________________________________
 svn-src-all@freebsd.org mailing list
 http://lists.freebsd.org/mailman/listinfo/svn-src-all
 To unsubscribe, send any mail to "svn-src-all-unsubscribe@freebsd.org"
 
State-Changed-From-To: patched->closed 
State-Changed-By: jilles 
State-Changed-When: Fri Jan 20 16:36:29 UTC 2012 
State-Changed-Why:  
Fixed in head, stable/9, stable/8, stable/7. 

http://www.freebsd.org/cgi/query-pr.cgi?pr=160866 

From: dfilter@FreeBSD.ORG (dfilter service)
To: bug-followup@FreeBSD.org
Cc:  
Subject: Re: misc/160866: commit references a PR
Date: Fri, 20 Jan 2012 16:32:00 +0000 (UTC)

 Author: jilles
 Date: Fri Jan 20 16:31:44 2012
 New Revision: 230385
 URL: http://svn.freebsd.org/changeset/base/230385
 
 Log:
   MFC r227124: fifo_misc test: Fix swapped lseek arguments.
   
   It worked regardless because SEEK_CUR happens to be 1.
   
   PR:		misc/160866
 
 Modified:
   stable/8/tools/regression/fifo/fifo_misc/fifo_misc.c
 Directory Properties:
   stable/8/tools/regression/fifo/   (props changed)
 
 Modified: stable/8/tools/regression/fifo/fifo_misc/fifo_misc.c
 ==============================================================================
 --- stable/8/tools/regression/fifo/fifo_misc/fifo_misc.c	Fri Jan 20 16:29:17 2012	(r230384)
 +++ stable/8/tools/regression/fifo/fifo_misc/fifo_misc.c	Fri Jan 20 16:31:44 2012	(r230385)
 @@ -115,7 +115,7 @@ test_lseek(void)
  		exit(-1);
  	}
  
 -	if (lseek(reader_fd, SEEK_CUR, 1) >= 0) {
 +	if (lseek(reader_fd, 1, SEEK_CUR) >= 0) {
  		warnx("%s: lseek succeeded instead of returning ESPIPE",
  		    __func__);
  		cleanfifo("testfifo", reader_fd, writer_fd);
 _______________________________________________
 svn-src-all@freebsd.org mailing list
 http://lists.freebsd.org/mailman/listinfo/svn-src-all
 To unsubscribe, send any mail to "svn-src-all-unsubscribe@freebsd.org"
 

From: dfilter@FreeBSD.ORG (dfilter service)
To: bug-followup@FreeBSD.org
Cc:  
Subject: Re: misc/160866: commit references a PR
Date: Fri, 20 Jan 2012 16:34:25 +0000 (UTC)

 Author: jilles
 Date: Fri Jan 20 16:34:14 2012
 New Revision: 230386
 URL: http://svn.freebsd.org/changeset/base/230386
 
 Log:
   MFC r227124: fifo_misc test: Fix swapped lseek arguments.
   
   It worked regardless because SEEK_CUR happens to be 1.
   
   PR:		misc/160866
 
 Modified:
   stable/7/tools/regression/fifo/fifo_misc/fifo_misc.c
 Directory Properties:
   stable/7/tools/regression/fifo/   (props changed)
 
 Modified: stable/7/tools/regression/fifo/fifo_misc/fifo_misc.c
 ==============================================================================
 --- stable/7/tools/regression/fifo/fifo_misc/fifo_misc.c	Fri Jan 20 16:31:44 2012	(r230385)
 +++ stable/7/tools/regression/fifo/fifo_misc/fifo_misc.c	Fri Jan 20 16:34:14 2012	(r230386)
 @@ -115,7 +115,7 @@ test_lseek(void)
  		exit(-1);
  	}
  
 -	if (lseek(reader_fd, SEEK_CUR, 1) >= 0) {
 +	if (lseek(reader_fd, 1, SEEK_CUR) >= 0) {
  		warnx("%s: lseek succeeded instead of returning ESPIPE",
  		    __func__);
  		cleanfifo("testfifo", reader_fd, writer_fd);
 _______________________________________________
 svn-src-all@freebsd.org mailing list
 http://lists.freebsd.org/mailman/listinfo/svn-src-all
 To unsubscribe, send any mail to "svn-src-all-unsubscribe@freebsd.org"
 
>Unformatted:
