From nobody@FreeBSD.org  Mon Sep 19 04:42:16 2011
Return-Path: <nobody@FreeBSD.org>
Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2001:4f8:fff6::34])
	by hub.freebsd.org (Postfix) with ESMTP id 1C06D106566B
	for <freebsd-gnats-submit@FreeBSD.org>; Mon, 19 Sep 2011 04:42:16 +0000 (UTC)
	(envelope-from nobody@FreeBSD.org)
Received: from red.freebsd.org (red.freebsd.org [IPv6:2001:4f8:fff6::22])
	by mx1.freebsd.org (Postfix) with ESMTP id 024958FC15
	for <freebsd-gnats-submit@FreeBSD.org>; Mon, 19 Sep 2011 04:42:16 +0000 (UTC)
Received: from red.freebsd.org (localhost [127.0.0.1])
	by red.freebsd.org (8.14.4/8.14.4) with ESMTP id p8J4gFf6071061
	for <freebsd-gnats-submit@FreeBSD.org>; Mon, 19 Sep 2011 04:42:15 GMT
	(envelope-from nobody@red.freebsd.org)
Received: (from nobody@localhost)
	by red.freebsd.org (8.14.4/8.14.4/Submit) id p8J4gFdI071060;
	Mon, 19 Sep 2011 04:42:15 GMT
	(envelope-from nobody)
Message-Id: <201109190442.p8J4gFdI071060@red.freebsd.org>
Date: Mon, 19 Sep 2011 04:42:15 GMT
From: Warren Block <wblock@wonkity.com>
To: freebsd-gnats-submit@FreeBSD.org
Subject: [patch] boot menu (/boot/menu.rc) clarity and readability improvements
X-Send-Pr-Version: www-3.1
X-GNATS-Notify:

>Number:         160818
>Category:       misc
>Synopsis:       [patch] boot menu (/boot/menu.rc) clarity and readability improvements
>Confidential:   no
>Severity:       non-critical
>Priority:       low
>Responsible:    pluknet
>State:          closed
>Quarter:        
>Keywords:       
>Date-Required:  
>Class:          update
>Submitter-Id:   current-users
>Arrival-Date:   Mon Sep 19 04:50:03 UTC 2011
>Closed-Date:    Wed Feb 01 15:13:05 UTC 2012
>Last-Modified:  Wed Feb 01 15:13:05 UTC 2012
>Originator:     Warren Block
>Release:        9.0-BETA2
>Organization:
>Environment:
FreeBSD amd 9.0-BETA2 FreeBSD 9.0-BETA2 #0: Tue Aug 30 22:06:12 MDT 2011     root@amd:/usr/obj/usr/src/sys/GENERIC  amd64
>Description:
Clarify and improve the boot menu with some small changes:

* Enter instead of ENTER

* Remove colons

* Line up option values

* Use dots to provide a line to visually connect the menu
  selections with their values

* Replace Enabled/Disabled with off/On
  (bigger inital cap for "On" is a visual indicator)

* Remove confusing "Boot" from selections that don't boot.

* With loader_color=1 in /boot/loader.conf, use reverse video to
  highlight enabled options
>How-To-Repeat:
Boot 9.0-BETA2.  Observe boot.
>Fix:
Apply patch.

Patch attached with submission follows:

--- /boot/menu.rc.orig	2011-08-30 11:47:10.000000000 -0600
+++ /boot/menu.rc	2011-09-05 09:09:05.000000000 -0600
@@ -18,9 +18,9 @@
 \ Initialize main menu constructs (see `menu.4th')
 \ NOTE: To use the `ansi' variants, add `loader_color=1' to loader.conf(5)
 
-set menu_caption[1]="Boot [ENTER]"
+set menu_caption[1]="Boot [Enter]"
 set menu_command[1]="boot"
-set ansi_caption[1]="[1mB[37moot [1m[ENTER][37m"
+set ansi_caption[1]="[1mB[37moot [1m[Enter][37m"
 set menu_keycode[1]="98"
 
 set menu_caption[2]="[Esc]ape to loader prompt"
@@ -38,34 +38,34 @@
 \ 
 set menu_options=4
 
-set menu_caption[4]="[A]CPI Support: Disabled"
-set toggled_text[4]="[A]CPI Support: Enabled"
+set menu_caption[4]="[A]CPI Support off"
+set toggled_text[4]="[A]CPI Support On"
 set menu_command[4]="toggle_acpi"
 set menu_keycode[4]="97"
 set menu_acpi=4
-set ansi_caption[4]="[1mA[37mCPI Support: [34;1mDisabled[37m"
-set toggled_ansi[4]="[1mA[37mCPI Support: [32mEnabled[37m"
+set ansi_caption[4]="[1mA[37mCPI Support [34;1mOff[37m"
+set toggled_ansi[4]="[1mA[37mCPI Support [32;7mOn[0;37m"
 
-set menu_caption[5]="Boot Safe [M]ode: NO"
-set toggled_text[5]="Boot Safe [M]ode: YES"
+set menu_caption[5]="Safe [M]ode... off"
+set toggled_text[5]="Safe [M]ode... On"
 set menu_command[5]="toggle_safemode"
 set menu_keycode[5]="109"
-set ansi_caption[5]="Boot Safe [1mM[37mode: [34;1mNO[37m"
-set toggled_ansi[5]="Boot Safe [1mM[37mode: [32mYES[37m"
+set ansi_caption[5]="Safe [1mM[37mode... [34;1mOff[37m"
+set toggled_ansi[5]="Safe [1mM[37mode... [32;7mOn[0;37m"
 
-set menu_caption[6]="Boot [S]ingle User: NO"
-set toggled_text[6]="Boot [S]ingle User: YES"
+set menu_caption[6]="[S]ingle User. off"
+set toggled_text[6]="[S]ingle User. On"
 set menu_command[6]="toggle_singleuser"
 set menu_keycode[6]="115"
-set ansi_caption[6]="Boot [1mS[37mingle User: [34;1mNO[37m"
-set toggled_ansi[6]="Boot [1mS[37mingle User: [32mYES[37m"
+set ansi_caption[6]="[1mS[37mingle User. [34;1mOff[37m"
+set toggled_ansi[6]="[1mS[37mingle User. [32;7mOn[0;37m"
 
-set menu_caption[7]="Boot [V]erbose: NO"
-set toggled_text[7]="Boot [V]erbose: YES"
+set menu_caption[7]="[V]erbose..... off"
+set toggled_text[7]="[V]erbose..... On"
 set menu_command[7]="toggle_verbose"
 set menu_keycode[7]="118"
-set ansi_caption[7]="Boot [1mV[37merbose: [34;1mNO[37m"
-set toggled_ansi[7]="Boot [1mV[37merbose: [32mYES[37m"
+set ansi_caption[7]="[1mV[37merbose..... [34;1mOff[37m"
+set toggled_ansi[7]="[1mV[37merbose..... [32;7mOn[0;37m"
 
 \ Enable automatic booting (add ``autoboot_delay=N'' to loader.conf(5) to
 \ customize the timeout; default is 10-seconds)


>Release-Note:
>Audit-Trail:

From: Devin Teske <devin.teske@fisglobal.com>
To: <bug-followup@FreeBSD.org>, <wblock@wonkity.com>
Cc:  
Subject: Re: misc/160818: [patch] boot menu (/boot/menu.rc) clarity and readability improvements
Date: Tue, 24 Jan 2012 01:57:58 -0800

 Please use ANSI code "27" to terminate inverse "7", instead of "0".
 
 For example, the following is preferred over what is in the patch:
 
 	set toggled_ansi[5]="Save  [1mM[37mode...  [32;7mOn[27;37m"
 
 Notice the trailing "27;37m" versus "0;37m".
 -- 
 Devin
 
 _____________
 The information contained in this message is proprietary and/or confidential. If you are not the intended recipient, please: (i) delete the message and all copies; (ii) do not disclose, distribute or use the message in any manner; and (iii) notify the sender immediately. In addition, please be aware that any message addressed to our domain is subject to archiving and review by persons other than the intended recipient. Thank you.

From: Devin Teske <devin.teske@fisglobal.com>
To: <bug-followup@FreeBSD.org>, <wblock@wonkity.com>
Cc:  
Subject: Re: misc/160818: [patch] boot menu (/boot/menu.rc) clarity and readability improvements
Date: Wed, 25 Jan 2012 08:10:29 -0800

 Oops! ANSI code "27" is not supported by loader(8).
 
 Go ahead and use the original [now preferred] "0;37".
 -- 
 Devin
 
 _____________
 The information contained in this message is proprietary and/or confidential. If you are not the intended recipient, please: (i) delete the message and all copies; (ii) do not disclose, distribute or use the message in any manner; and (iii) notify the sender immediately. In addition, please be aware that any message addressed to our domain is subject to archiving and review by persons other than the intended recipient. Thank you.

From: Devin Teske <devin.teske@fisglobal.com>
To: <bug-followup@FreeBSD.org>, <wblock@wonkity.com>
Cc:  
Subject: Re: misc/160818: [patch] boot menu (/boot/menu.rc) clarity and readability improvements
Date: Wed, 25 Jan 2012 08:12:19 -0800

 I tried this patch out on 9.0-RELEASE.
 
 I do think it's an improvement of the look-and-feel.
 
 Especially the lining-up of options.
 
 Must admit that at-first I didn't like the inversion, but now I do (after a=
  couple of reboots).
 
 Ship It!
 --=20
 Devin
 
 _____________
 The information contained in this message is proprietary and/or confidentia=
 l. If you are not the intended recipient, please: (i) delete the message an=
 d all copies; (ii) do not disclose, distribute or use the message in any ma=
 nner; and (iii) notify the sender immediately. In addition, please be aware=
  that any message addressed to our domain is subject to archiving and revie=
 w by persons other than the intended recipient. Thank you.
State-Changed-From-To: open->patched 
State-Changed-By: pluknet 
State-Changed-When: Wed Jan 25 18:36:27 UTC 2012 
State-Changed-Why:  
Patched in HEAD. MFC to stable/9 will follow in 1 week. 

http://www.freebsd.org/cgi/query-pr.cgi?pr=160818 
Responsible-Changed-From-To: freebsd-bugs->pluknet 
Responsible-Changed-By: pluknet 
Responsible-Changed-When: Wed Jan 25 18:38:02 UTC 2012 
Responsible-Changed-Why:  
Track. 

http://www.freebsd.org/cgi/query-pr.cgi?pr=160818 

From: dfilter@FreeBSD.ORG (dfilter service)
To: bug-followup@FreeBSD.org
Cc:  
Subject: Re: misc/160818: commit references a PR
Date: Wed, 25 Jan 2012 18:36:21 +0000 (UTC)

 Author: pluknet
 Date: Wed Jan 25 18:36:01 2012
 New Revision: 230545
 URL: http://svn.freebsd.org/changeset/base/230545
 
 Log:
   Clarify and improve the boot menu with some small changes:
   - Enter instead of ENTER
   - Remove colons
   - Line up option values
   - Use dots to provide a line to visually connect the menu
     selections with their values
   - Replace Enabled/Disabled with off/On
     (bigger inital cap for "On" is a visual indicator)
   - Remove confusing "Boot" from selections that don't boot.
   - With loader_color=1 in /boot/loader.conf, use reverse video to
     highlight enabled options
   
   PR:		misc/160818
   Submitted by:	Warren Block <wblock wonkity com>
   Reviewed by:	Devin Teske <devin dot teske fisglobal com>, current@
   MFC after:	1 week
 
 Modified:
   head/sys/boot/forth/menu.rc
 
 Modified: head/sys/boot/forth/menu.rc
 ==============================================================================
 --- head/sys/boot/forth/menu.rc	Wed Jan 25 17:58:47 2012	(r230544)
 +++ head/sys/boot/forth/menu.rc	Wed Jan 25 18:36:01 2012	(r230545)
 @@ -18,9 +18,9 @@ menu-init     \ initialize the menu area
  \ Initialize main menu constructs (see `menu.4th')
  \ NOTE: To use the `ansi' variants, add `loader_color=1' to loader.conf(5)
  
 -set menu_caption[1]="Boot [ENTER]"
 +set menu_caption[1]="Boot [Enter]"
  set menu_command[1]="boot"
 -set ansi_caption[1]="[1mB[37moot [1m[ENTER][37m"
 +set ansi_caption[1]="[1mB[37moot [1m[Enter][37m"
  set menu_keycode[1]="98"
  
  set menu_caption[2]="[Esc]ape to loader prompt"
 @@ -38,34 +38,34 @@ set menu_reboot
  \ 
  set menu_options=4
  
 -set menu_caption[4]="[A]CPI Support: Disabled"
 -set toggled_text[4]="[A]CPI Support: Enabled"
 +set menu_caption[4]="[A]CPI Support off"
 +set toggled_text[4]="[A]CPI Support On"
  set menu_command[4]="toggle_acpi"
  set menu_keycode[4]="97"
  set menu_acpi=4
 -set ansi_caption[4]="[1mA[37mCPI Support: [34;1mDisabled[37m"
 -set toggled_ansi[4]="[1mA[37mCPI Support: [32mEnabled[37m"
 +set ansi_caption[4]="[1mA[37mCPI Support [34;1mOff[37m"
 +set toggled_ansi[4]="[1mA[37mCPI Support [32;7mOn[0;37m"
  
 -set menu_caption[5]="Boot Safe [M]ode: NO"
 -set toggled_text[5]="Boot Safe [M]ode: YES"
 +set menu_caption[5]="Safe [M]ode... off"
 +set toggled_text[5]="Safe [M]ode... On"
  set menu_command[5]="toggle_safemode"
  set menu_keycode[5]="109"
 -set ansi_caption[5]="Boot Safe [1mM[37mode: [34;1mNO[37m"
 -set toggled_ansi[5]="Boot Safe [1mM[37mode: [32mYES[37m"
 +set ansi_caption[5]="Safe [1mM[37mode... [34;1mOff[37m"
 +set toggled_ansi[5]="Safe [1mM[37mode... [32;7mOn[0;37m"
  
 -set menu_caption[6]="Boot [S]ingle User: NO"
 -set toggled_text[6]="Boot [S]ingle User: YES"
 +set menu_caption[6]="[S]ingle User. off"
 +set toggled_text[6]="[S]ingle User. On"
  set menu_command[6]="toggle_singleuser"
  set menu_keycode[6]="115"
 -set ansi_caption[6]="Boot [1mS[37mingle User: [34;1mNO[37m"
 -set toggled_ansi[6]="Boot [1mS[37mingle User: [32mYES[37m"
 +set ansi_caption[6]="[1mS[37mingle User. [34;1mOff[37m"
 +set toggled_ansi[6]="[1mS[37mingle User. [32;7mOn[0;37m"
  
 -set menu_caption[7]="Boot [V]erbose: NO"
 -set toggled_text[7]="Boot [V]erbose: YES"
 +set menu_caption[7]="[V]erbose..... off"
 +set toggled_text[7]="[V]erbose..... On"
  set menu_command[7]="toggle_verbose"
  set menu_keycode[7]="118"
 -set ansi_caption[7]="Boot [1mV[37merbose: [34;1mNO[37m"
 -set toggled_ansi[7]="Boot [1mV[37merbose: [32mYES[37m"
 +set ansi_caption[7]="[1mV[37merbose..... [34;1mOff[37m"
 +set toggled_ansi[7]="[1mV[37merbose..... [32;7mOn[0;37m"
  
  \ Enable automatic booting (add ``autoboot_delay=N'' to loader.conf(5) to
  \ customize the timeout; default is 10-seconds)
 _______________________________________________
 svn-src-all@freebsd.org mailing list
 http://lists.freebsd.org/mailman/listinfo/svn-src-all
 To unsubscribe, send any mail to "svn-src-all-unsubscribe@freebsd.org"
 

From: dfilter@FreeBSD.ORG (dfilter service)
To: bug-followup@FreeBSD.org
Cc:  
Subject: Re: misc/160818: commit references a PR
Date: Wed,  1 Feb 2012 15:04:47 +0000 (UTC)

 Author: pluknet
 Date: Wed Feb  1 15:04:27 2012
 New Revision: 230867
 URL: http://svn.freebsd.org/changeset/base/230867
 
 Log:
   MFC r230545: Clarify and improve the boot menu with some small changes.
   
   PR:		misc/160818
   Submitted by:	Warren Block <wblock wonkity com>
 
 Modified:
   stable/9/sys/boot/forth/menu.rc
 Directory Properties:
   stable/9/sys/   (props changed)
   stable/9/sys/amd64/include/xen/   (props changed)
   stable/9/sys/boot/   (props changed)
   stable/9/sys/boot/i386/efi/   (props changed)
   stable/9/sys/boot/ia64/efi/   (props changed)
   stable/9/sys/boot/ia64/ski/   (props changed)
   stable/9/sys/boot/powerpc/boot1.chrp/   (props changed)
   stable/9/sys/boot/powerpc/ofw/   (props changed)
   stable/9/sys/cddl/contrib/opensolaris/   (props changed)
   stable/9/sys/conf/   (props changed)
   stable/9/sys/contrib/dev/acpica/   (props changed)
   stable/9/sys/contrib/octeon-sdk/   (props changed)
   stable/9/sys/contrib/pf/   (props changed)
   stable/9/sys/contrib/x86emu/   (props changed)
 
 Modified: stable/9/sys/boot/forth/menu.rc
 ==============================================================================
 --- stable/9/sys/boot/forth/menu.rc	Wed Feb  1 14:34:52 2012	(r230866)
 +++ stable/9/sys/boot/forth/menu.rc	Wed Feb  1 15:04:27 2012	(r230867)
 @@ -18,9 +18,9 @@ menu-init     \ initialize the menu area
  \ Initialize main menu constructs (see `menu.4th')
  \ NOTE: To use the `ansi' variants, add `loader_color=1' to loader.conf(5)
  
 -set menu_caption[1]="Boot [ENTER]"
 +set menu_caption[1]="Boot [Enter]"
  set menu_command[1]="boot"
 -set ansi_caption[1]="[1mB[37moot [1m[ENTER][37m"
 +set ansi_caption[1]="[1mB[37moot [1m[Enter][37m"
  set menu_keycode[1]="98"
  
  set menu_caption[2]="[Esc]ape to loader prompt"
 @@ -38,34 +38,34 @@ set menu_reboot
  \ 
  set menu_options=4
  
 -set menu_caption[4]="[A]CPI Support: Disabled"
 -set toggled_text[4]="[A]CPI Support: Enabled"
 +set menu_caption[4]="[A]CPI Support off"
 +set toggled_text[4]="[A]CPI Support On"
  set menu_command[4]="toggle_acpi"
  set menu_keycode[4]="97"
  set menu_acpi=4
 -set ansi_caption[4]="[1mA[37mCPI Support: [34;1mDisabled[37m"
 -set toggled_ansi[4]="[1mA[37mCPI Support: [32mEnabled[37m"
 +set ansi_caption[4]="[1mA[37mCPI Support [34;1mOff[37m"
 +set toggled_ansi[4]="[1mA[37mCPI Support [32;7mOn[0;37m"
  
 -set menu_caption[5]="Boot Safe [M]ode: NO"
 -set toggled_text[5]="Boot Safe [M]ode: YES"
 +set menu_caption[5]="Safe [M]ode... off"
 +set toggled_text[5]="Safe [M]ode... On"
  set menu_command[5]="toggle_safemode"
  set menu_keycode[5]="109"
 -set ansi_caption[5]="Boot Safe [1mM[37mode: [34;1mNO[37m"
 -set toggled_ansi[5]="Boot Safe [1mM[37mode: [32mYES[37m"
 +set ansi_caption[5]="Safe [1mM[37mode... [34;1mOff[37m"
 +set toggled_ansi[5]="Safe [1mM[37mode... [32;7mOn[0;37m"
  
 -set menu_caption[6]="Boot [S]ingle User: NO"
 -set toggled_text[6]="Boot [S]ingle User: YES"
 +set menu_caption[6]="[S]ingle User. off"
 +set toggled_text[6]="[S]ingle User. On"
  set menu_command[6]="toggle_singleuser"
  set menu_keycode[6]="115"
 -set ansi_caption[6]="Boot [1mS[37mingle User: [34;1mNO[37m"
 -set toggled_ansi[6]="Boot [1mS[37mingle User: [32mYES[37m"
 +set ansi_caption[6]="[1mS[37mingle User. [34;1mOff[37m"
 +set toggled_ansi[6]="[1mS[37mingle User. [32;7mOn[0;37m"
  
 -set menu_caption[7]="Boot [V]erbose: NO"
 -set toggled_text[7]="Boot [V]erbose: YES"
 +set menu_caption[7]="[V]erbose..... off"
 +set toggled_text[7]="[V]erbose..... On"
  set menu_command[7]="toggle_verbose"
  set menu_keycode[7]="118"
 -set ansi_caption[7]="Boot [1mV[37merbose: [34;1mNO[37m"
 -set toggled_ansi[7]="Boot [1mV[37merbose: [32mYES[37m"
 +set ansi_caption[7]="[1mV[37merbose..... [34;1mOff[37m"
 +set toggled_ansi[7]="[1mV[37merbose..... [32;7mOn[0;37m"
  
  \ Enable automatic booting (add ``autoboot_delay=N'' to loader.conf(5) to
  \ customize the timeout; default is 10-seconds)
 _______________________________________________
 svn-src-all@freebsd.org mailing list
 http://lists.freebsd.org/mailman/listinfo/svn-src-all
 To unsubscribe, send any mail to "svn-src-all-unsubscribe@freebsd.org"
 
State-Changed-From-To: patched->closed 
State-Changed-By: pluknet 
State-Changed-When: Wed Feb 1 15:12:48 UTC 2012 
State-Changed-Why:  
Merged to stable/9. 

http://www.freebsd.org/cgi/query-pr.cgi?pr=160818 
>Unformatted:
