From nobody@FreeBSD.org  Sun Sep  4 17:30:03 2011
Return-Path: <nobody@FreeBSD.org>
Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2001:4f8:fff6::34])
	by hub.freebsd.org (Postfix) with ESMTP id 0EF5D1065672
	for <freebsd-gnats-submit@FreeBSD.org>; Sun,  4 Sep 2011 17:30:03 +0000 (UTC)
	(envelope-from nobody@FreeBSD.org)
Received: from red.freebsd.org (red.freebsd.org [IPv6:2001:4f8:fff6::22])
	by mx1.freebsd.org (Postfix) with ESMTP id E7AA78FC0A
	for <freebsd-gnats-submit@FreeBSD.org>; Sun,  4 Sep 2011 17:30:02 +0000 (UTC)
Received: from red.freebsd.org (localhost [127.0.0.1])
	by red.freebsd.org (8.14.4/8.14.4) with ESMTP id p84HU2OO025782
	for <freebsd-gnats-submit@FreeBSD.org>; Sun, 4 Sep 2011 17:30:02 GMT
	(envelope-from nobody@red.freebsd.org)
Received: (from nobody@localhost)
	by red.freebsd.org (8.14.4/8.14.4/Submit) id p84HU2nn025780;
	Sun, 4 Sep 2011 17:30:02 GMT
	(envelope-from nobody)
Message-Id: <201109041730.p84HU2nn025780@red.freebsd.org>
Date: Sun, 4 Sep 2011 17:30:02 GMT
From: Garrett Cooper <yaneurabeya@gmail.com>
To: freebsd-gnats-submit@FreeBSD.org
Subject: [patch] fix build dependency for dtrace module
X-Send-Pr-Version: www-3.1
X-GNATS-Notify:

>Number:         160463
>Category:       misc
>Synopsis:       [build] [patch] fix build dependency for dtrace module
>Confidential:   no
>Severity:       serious
>Priority:       medium
>Responsible:    eadler
>State:          closed
>Quarter:        
>Keywords:       
>Date-Required:  
>Class:          sw-bug
>Submitter-Id:   current-users
>Arrival-Date:   Sun Sep 04 17:40:05 UTC 2011
>Closed-Date:    Mon Mar 19 01:24:07 UTC 2012
>Last-Modified:  Sun Feb 03 22:29:23 UTC 2013
>Originator:     Garrett Cooper
>Release:        9.0-BETA1
>Organization:
n/a
>Environment:
FreeBSD bayonetta.local 9.0-BETA1 FreeBSD 9.0-BETA1 #0 r224946M: Thu Aug 18 10:02:09 PDT 2011     gcooper@bayonetta.local:/usr/obj/usr/src/sys/BAYONETTA  amd64
>Description:
The ordering for the sources in dtrace's module file are wrong. This causes build errors like what are shown below. The fix is to reorder the dependencies to force assym.s to be built before trying to build dtrace_assym.S. It seems odd that this is required, given how make works, but it fixes the compilation issue.

cc -O2 -pipe -fno-strict-aliasing -pipe -O2 -march=core2 -DDIS_MEM -DSMP -DDEBUG -Werror -D_KERNEL -DKLD_MODULE -nostdinc  -I/usr/src/sys/modules/dtrace/dtrace/../../../cddl/contrib/opensolaris/uts/intel -I/usr/src/sys/modules/dtrace/dtrace/../../../cddl/compat/opensolaris -I/usr/src/sys/modules/dtrace/dtrace/../../../cddl/dev/dtrace -I/usr/src/sys/modules/dtrace/dtrace/../../../cddl/dev/dtrace/amd64 -I/usr/src/sys/modules/dtrace/dtrace/../../../cddl/contrib/opensolaris/uts/common -I/usr/src/sys/modules/dtrace/dtrace/../../.. -I. -I@ -I@/contrib/altq -finline-limit=8000 --param inline-unit-growth=100 --param large-function-growth=1000 -fno-common  -fno-omit-frame-pointer  -mno-sse -mcmodel=kernel -mno-red-zone -mno-mmx -msoft-float  -fno-asynchronous-unwind-tables -ffreestanding -fstack-protector -std=iso9899:1999 -fstack-protector -Wall -Wredundant-decls -Wnested-externs -Wstrict-prototypes  -Wmissing-prototypes -Wpointer-arith -Winline -Wcast-qual  -Wundef -Wno-pointer-sign
  -fformat-extensions  -Wmissing-include-dirs -fdiagnostics-show-option -Wno-unknown-pragmas -c /usr/src/sys/modules/dtrace/dtrace/../../../cddl/contrib/opensolaris/uts/common/dtrace/dtrace.c
cc -O2 -pipe -fno-strict-aliasing -pipe -O2 -march=core2 -DDIS_MEM -DSMP -DDEBUG -Werror -D_KERNEL -DKLD_MODULE -nostdinc  -I/usr/src/sys/modules/dtrace/dtrace/../../../cddl/contrib/opensolaris/uts/intel -I/usr/src/sys/modules/dtrace/dtrace/../../../cddl/compat/opensolaris -I/usr/src/sys/modules/dtrace/dtrace/../../../cddl/dev/dtrace -I/usr/src/sys/modules/dtrace/dtrace/../../../cddl/dev/dtrace/amd64 -I/usr/src/sys/modules/dtrace/dtrace/../../../cddl/contrib/opensolaris/uts/common -I/usr/src/sys/modules/dtrace/dtrace/../../.. -I. -I@ -I@/contrib/altq -finline-limit=8000 --param inline-unit-growth=100 --param large-function-growth=1000 -fno-common  -fno-omit-frame-pointer  -mno-sse -mcmodel=kernel -mno-red-zone -mno-mmx -msoft-float  -fno-asynchronous-unwind-tables -ffreestanding -fstack-protector -std=iso9899:1999 -fstack-protector -Wall -Wredundant-decls -Wnested-externs -Wstrict-prototypes  -Wmissing-prototypes -Wpointer-arith -Winline -Wcast-qual  -Wundef -Wno-pointer-sign
  -fformat-extensions  -Wmissing-include-dirs -fdiagnostics-show-option -Wno-unknown-pragmas  -c /usr/src/sys/modules/dtrace/dtrace/../../../cddl/dev/dtrace/amd64/dtrace_asm.S
/usr/src/sys/modules/dtrace/dtrace/../../../cddl/dev/dtrace/amd64/dtrace_asm.S:37:19: error: assym.s: No such file or directory
*** Error code 1

Stop in /usr/src/sys/modules/dtrace/dtrace.
*** Error code 1

Stop in /usr/src/sys/modules/dtrace.
>How-To-Repeat:
make -C /sys/modules/dtrace/ clean cleandir all
>Fix:


Patch attached with submission follows:

Index: sys/modules/dtrace/dtrace/Makefile
===================================================================
--- sys/modules/dtrace/dtrace/Makefile	(revision 224946)
+++ sys/modules/dtrace/dtrace/Makefile	(working copy)
@@ -8,7 +8,9 @@
 .PATH: ${.CURDIR}/../../../cddl/dev/dtrace/${ARCHDIR}
 
 KMOD=		dtrace
+# assym.s is needed for dtrace_asm.S
 SRCS=		dtrace.c \
+		assym.s \
 		dtrace_asm.S \
 		dtrace_subr.c
 
@@ -20,9 +22,6 @@
 
 SRCS+=		bus_if.h device_if.h vnode_if.h
 
-# Needed for dtrace_asm.S
-SRCS+=		assym.s
-
 # These are needed for assym.s
 SRCS+=		opt_compat.h opt_kstack_pages.h opt_nfs.h opt_hwpmc_hooks.h
 


>Release-Note:
>Audit-Trail:
Responsible-Changed-From-To: freebsd-bugs->eadler 
Responsible-Changed-By: eadler 
Responsible-Changed-When: Sun Jan 22 05:42:29 UTC 2012 
Responsible-Changed-Why:  
n1 

http://www.freebsd.org/cgi/query-pr.cgi?pr=160463 
State-Changed-From-To: open->patched 
State-Changed-By: eadler 
State-Changed-When: Sun Mar 4 01:06:17 UTC 2012 
State-Changed-Why:  
awaiting approval 

http://www.freebsd.org/cgi/query-pr.cgi?pr=160463 

From: dfilter@FreeBSD.ORG (dfilter service)
To: bug-followup@FreeBSD.org
Cc:  
Subject: Re: misc/160463: commit references a PR
Date: Sun,  4 Mar 2012 16:46:37 +0000 (UTC)

 Author: eadler
 Date: Sun Mar  4 16:46:27 2012
 New Revision: 232506
 URL: http://svn.freebsd.org/changeset/base/232506
 
 Log:
   Explicitly list dependency
   
   PR:		misc/160463
   Submitted by:	Garrett Cooper <yaneurabeya@gmail.com>
   Helped by:	kan
   Approved by:	cperciva
   MFC after:	3 days
 
 Modified:
   head/sys/modules/dtrace/dtrace/Makefile
 
 Modified: head/sys/modules/dtrace/dtrace/Makefile
 ==============================================================================
 --- head/sys/modules/dtrace/dtrace/Makefile	Sun Mar  4 16:44:04 2012	(r232505)
 +++ head/sys/modules/dtrace/dtrace/Makefile	Sun Mar  4 16:46:27 2012	(r232506)
 @@ -42,4 +42,6 @@ EXPORT_SYMS=	dtrace_register \
  		dtrace_unregister \
  		dtrace_probe_lookup
  
 +dtrace_asm.o:  assym.s
 +
  .include <bsd.kmod.mk>
 _______________________________________________
 svn-src-all@freebsd.org mailing list
 http://lists.freebsd.org/mailman/listinfo/svn-src-all
 To unsubscribe, send any mail to "svn-src-all-unsubscribe@freebsd.org"
 

From: dfilter@FreeBSD.ORG (dfilter service)
To: bug-followup@FreeBSD.org
Cc:  
Subject: Re: misc/160463: commit references a PR
Date: Mon, 19 Mar 2012 01:18:32 +0000 (UTC)

 Author: eadler
 Date: Mon Mar 19 01:18:22 2012
 New Revision: 233143
 URL: http://svn.freebsd.org/changeset/base/233143
 
 Log:
   MFC r232506:
   	Explicitly list dependency
   
   PR:		misc/160463
   Approved by:	cperciva
 
 Modified:
   stable/9/sys/modules/dtrace/dtrace/Makefile
 Directory Properties:
   stable/9/sys/   (props changed)
 
 Modified: stable/9/sys/modules/dtrace/dtrace/Makefile
 ==============================================================================
 --- stable/9/sys/modules/dtrace/dtrace/Makefile	Mon Mar 19 01:16:11 2012	(r233142)
 +++ stable/9/sys/modules/dtrace/dtrace/Makefile	Mon Mar 19 01:18:22 2012	(r233143)
 @@ -42,4 +42,6 @@ EXPORT_SYMS=	dtrace_register \
  		dtrace_unregister \
  		dtrace_probe_lookup
  
 +dtrace_asm.o:  assym.s
 +
  .include <bsd.kmod.mk>
 _______________________________________________
 svn-src-all@freebsd.org mailing list
 http://lists.freebsd.org/mailman/listinfo/svn-src-all
 To unsubscribe, send any mail to "svn-src-all-unsubscribe@freebsd.org"
 

From: dfilter@FreeBSD.ORG (dfilter service)
To: bug-followup@FreeBSD.org
Cc:  
Subject: Re: misc/160463: commit references a PR
Date: Mon, 19 Mar 2012 01:19:05 +0000 (UTC)

 Author: eadler
 Date: Mon Mar 19 01:18:46 2012
 New Revision: 233144
 URL: http://svn.freebsd.org/changeset/base/233144
 
 Log:
   MFC r232506:
   	Explicitly list dependency
   
   PR:		misc/160463
   Approved by:	cperciva
 
 Modified:
   stable/8/sys/modules/dtrace/dtrace/Makefile
 Directory Properties:
   stable/8/sys/   (props changed)
 
 Modified: stable/8/sys/modules/dtrace/dtrace/Makefile
 ==============================================================================
 --- stable/8/sys/modules/dtrace/dtrace/Makefile	Mon Mar 19 01:18:22 2012	(r233143)
 +++ stable/8/sys/modules/dtrace/dtrace/Makefile	Mon Mar 19 01:18:46 2012	(r233144)
 @@ -42,4 +42,6 @@ EXPORT_SYMS=	dtrace_register \
  		dtrace_unregister \
  		dtrace_probe_lookup
  
 +dtrace_asm.o:  assym.s
 +
  .include <bsd.kmod.mk>
 _______________________________________________
 svn-src-all@freebsd.org mailing list
 http://lists.freebsd.org/mailman/listinfo/svn-src-all
 To unsubscribe, send any mail to "svn-src-all-unsubscribe@freebsd.org"
 

From: dfilter@FreeBSD.ORG (dfilter service)
To: bug-followup@FreeBSD.org
Cc:  
Subject: Re: misc/160463: commit references a PR
Date: Mon, 19 Mar 2012 01:19:21 +0000 (UTC)

 Author: eadler
 Date: Mon Mar 19 01:19:04 2012
 New Revision: 233145
 URL: http://svn.freebsd.org/changeset/base/233145
 
 Log:
   MFC r232506:
   	Explicitly list dependency
   
   PR:		misc/160463
   Approved by:	cperciva
 
 Modified:
   stable/7/sys/modules/dtrace/dtrace/Makefile
 Directory Properties:
   stable/7/sys/   (props changed)
 
 Modified: stable/7/sys/modules/dtrace/dtrace/Makefile
 ==============================================================================
 --- stable/7/sys/modules/dtrace/dtrace/Makefile	Mon Mar 19 01:18:46 2012	(r233144)
 +++ stable/7/sys/modules/dtrace/dtrace/Makefile	Mon Mar 19 01:19:04 2012	(r233145)
 @@ -41,4 +41,6 @@ EXPORT_SYMS=	dtrace_register \
  		dtrace_unregister \
  		dtrace_probe_lookup
  
 +dtrace_asm.o:  assym.s
 +
  .include <bsd.kmod.mk>
 _______________________________________________
 svn-src-all@freebsd.org mailing list
 http://lists.freebsd.org/mailman/listinfo/svn-src-all
 To unsubscribe, send any mail to "svn-src-all-unsubscribe@freebsd.org"
 
State-Changed-From-To: patched->closed 
State-Changed-By: eadler 
State-Changed-When: Mon Mar 19 01:24:06 UTC 2012 
State-Changed-Why:  
Committed. Thanks! 

http://www.freebsd.org/cgi/query-pr.cgi?pr=160463 
>Unformatted:
