From nobody@FreeBSD.org  Tue May 24 05:14:44 2011
Return-Path: <nobody@FreeBSD.org>
Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2001:4f8:fff6::34])
	by hub.freebsd.org (Postfix) with ESMTP id 29D63106564A
	for <freebsd-gnats-submit@FreeBSD.org>; Tue, 24 May 2011 05:14:44 +0000 (UTC)
	(envelope-from nobody@FreeBSD.org)
Received: from red.freebsd.org (red.freebsd.org [IPv6:2001:4f8:fff6::22])
	by mx1.freebsd.org (Postfix) with ESMTP id 1A6D98FC14
	for <freebsd-gnats-submit@FreeBSD.org>; Tue, 24 May 2011 05:14:44 +0000 (UTC)
Received: from red.freebsd.org (localhost [127.0.0.1])
	by red.freebsd.org (8.14.4/8.14.4) with ESMTP id p4O5EhEm020506
	for <freebsd-gnats-submit@FreeBSD.org>; Tue, 24 May 2011 05:14:43 GMT
	(envelope-from nobody@red.freebsd.org)
Received: (from nobody@localhost)
	by red.freebsd.org (8.14.4/8.14.4/Submit) id p4O5EhjH020505;
	Tue, 24 May 2011 05:14:43 GMT
	(envelope-from nobody)
Message-Id: <201105240514.p4O5EhjH020505@red.freebsd.org>
Date: Tue, 24 May 2011 05:14:43 GMT
From: Marcus Reid <marcus@blazingdot.com>
To: freebsd-gnats-submit@FreeBSD.org
Subject: showmount omits white space when exported directory name is long
X-Send-Pr-Version: www-3.1
X-GNATS-Notify:

>Number:         157286
>Category:       misc
>Synopsis:       showmount omits white space when exported directory name is long
>Confidential:   no
>Severity:       serious
>Priority:       low
>Responsible:    ru
>State:          closed
>Quarter:        
>Keywords:       
>Date-Required:  
>Class:          sw-bug
>Submitter-Id:   current-users
>Arrival-Date:   Tue May 24 05:20:07 UTC 2011
>Closed-Date:    Fri May 27 09:52:02 UTC 2011
>Last-Modified:  Fri May 27 10:00:20 UTC 2011
>Originator:     Marcus Reid
>Release:        9.0-CURRENT
>Organization:
>Environment:
FreeBSD austin 9.0-CURRENT FreeBSD 9.0-CURRENT #0: Mon May  9 02:05:32 PDT 2011     root@austin:/usr/obj/usr/src/sys/FARK  amd64
>Description:
To put whitespace between the directory and the hostmask, the showmount command uses the following printf:

  printf("%-35s", exp->ex_dirp);

This results in no spaces being printed after the path if the path is long.  See example.
>How-To-Repeat:
[root@austin /root]# showmount -e
Exports list on localhost:
/long/long/long/long/long/long/long/long/long/long/long/long/pathEveryone
/export                            Everyone

>Fix:
printf("%-34s ", exp->ex_dirp);

This retains the same output as the original except for the error case.  I've attached a small diff with the change.

Patch attached with submission follows:

*** usr.bin/showmount/showmount.c.orig	Mon May 23 22:04:09 2011
--- usr.bin/showmount/showmount.c	Mon May 23 22:00:23 2011
***************
*** 185,191 ****
  		printf("Exports list on %s:\n", host);
  		exp = exportslist;
  		while (exp) {
! 			printf("%-35s", exp->ex_dirp);
  			grp = exp->ex_groups;
  			if (grp == NULL) {
  				printf("Everyone\n");
--- 185,191 ----
  		printf("Exports list on %s:\n", host);
  		exp = exportslist;
  		while (exp) {
! 			printf("%-34s ", exp->ex_dirp);
  			grp = exp->ex_groups;
  			if (grp == NULL) {
  				printf("Everyone\n");


>Release-Note:
>Audit-Trail:
State-Changed-From-To: open->patched 
State-Changed-By: ru 
State-Changed-When: Tue May 24 06:56:52 UTC 2011 
State-Changed-Why:  
Fixed in 9.0-CURRENT. 


Responsible-Changed-From-To: freebsd-bugs->ru 
Responsible-Changed-By: ru 
Responsible-Changed-When: Tue May 24 06:56:52 UTC 2011 
Responsible-Changed-Why:  

http://www.freebsd.org/cgi/query-pr.cgi?pr=157286 

From: dfilter@FreeBSD.ORG (dfilter service)
To: bug-followup@FreeBSD.org
Cc:  
Subject: Re: misc/157286: commit references a PR
Date: Tue, 24 May 2011 06:56:54 +0000 (UTC)

 Author: ru
 Date: Tue May 24 06:56:40 2011
 New Revision: 222245
 URL: http://svn.freebsd.org/changeset/base/222245
 
 Log:
   Ensure there is a whitespace after a mount point.
   
   PR:		157286
   Submitted by:	Marcus Reid
   MFC after:	3 days
 
 Modified:
   head/usr.bin/showmount/showmount.c
 
 Modified: head/usr.bin/showmount/showmount.c
 ==============================================================================
 --- head/usr.bin/showmount/showmount.c	Tue May 24 06:46:07 2011	(r222244)
 +++ head/usr.bin/showmount/showmount.c	Tue May 24 06:56:40 2011	(r222245)
 @@ -185,7 +185,7 @@ main(int argc, char **argv)
  		printf("Exports list on %s:\n", host);
  		exp = exportslist;
  		while (exp) {
 -			printf("%-35s", exp->ex_dirp);
 +			printf("%-34s ", exp->ex_dirp);
  			grp = exp->ex_groups;
  			if (grp == NULL) {
  				printf("Everyone\n");
 _______________________________________________
 svn-src-all@freebsd.org mailing list
 http://lists.freebsd.org/mailman/listinfo/svn-src-all
 To unsubscribe, send any mail to "svn-src-all-unsubscribe@freebsd.org"
 
State-Changed-From-To: patched->closed 
State-Changed-By: ru 
State-Changed-When: Fri May 27 09:50:56 UTC 2011 
State-Changed-Why:  
Fixed in 8.2-STABLE. 

http://www.freebsd.org/cgi/query-pr.cgi?pr=157286 

From: dfilter@FreeBSD.ORG (dfilter service)
To: bug-followup@FreeBSD.org
Cc:  
Subject: Re: misc/157286: commit references a PR
Date: Fri, 27 May 2011 09:50:39 +0000 (UTC)

 Author: ru
 Date: Fri May 27 09:50:29 2011
 New Revision: 222349
 URL: http://svn.freebsd.org/changeset/base/222349
 
 Log:
   MFC: r222245: Ensure there is a whitespace after a mount point.
   
   PR:		157286
 
 Modified:
   stable/8/usr.bin/showmount/showmount.c
 Directory Properties:
   stable/8/usr.bin/showmount/   (props changed)
 
 Modified: stable/8/usr.bin/showmount/showmount.c
 ==============================================================================
 --- stable/8/usr.bin/showmount/showmount.c	Fri May 27 09:15:56 2011	(r222348)
 +++ stable/8/usr.bin/showmount/showmount.c	Fri May 27 09:50:29 2011	(r222349)
 @@ -191,7 +191,7 @@ main(argc, argv)
  		printf("Exports list on %s:\n", host);
  		exp = exportslist;
  		while (exp) {
 -			printf("%-35s", exp->ex_dirp);
 +			printf("%-34s ", exp->ex_dirp);
  			grp = exp->ex_groups;
  			if (grp == NULL) {
  				printf("Everyone\n");
 _______________________________________________
 svn-src-all@freebsd.org mailing list
 http://lists.freebsd.org/mailman/listinfo/svn-src-all
 To unsubscribe, send any mail to "svn-src-all-unsubscribe@freebsd.org"
 
>Unformatted:
