From nobody@FreeBSD.org  Sat Mar 12 23:37:41 2011
Return-Path: <nobody@FreeBSD.org>
Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2001:4f8:fff6::34])
	by hub.freebsd.org (Postfix) with ESMTP id 7377E1065670
	for <freebsd-gnats-submit@FreeBSD.org>; Sat, 12 Mar 2011 23:37:41 +0000 (UTC)
	(envelope-from nobody@FreeBSD.org)
Received: from red.freebsd.org (red.freebsd.org [IPv6:2001:4f8:fff6::22])
	by mx1.freebsd.org (Postfix) with ESMTP id 6199A8FC13
	for <freebsd-gnats-submit@FreeBSD.org>; Sat, 12 Mar 2011 23:37:41 +0000 (UTC)
Received: from red.freebsd.org (localhost [127.0.0.1])
	by red.freebsd.org (8.14.4/8.14.4) with ESMTP id p2CNbfK2004389
	for <freebsd-gnats-submit@FreeBSD.org>; Sat, 12 Mar 2011 23:37:41 GMT
	(envelope-from nobody@red.freebsd.org)
Received: (from nobody@localhost)
	by red.freebsd.org (8.14.4/8.14.4/Submit) id p2CNbfJH004388;
	Sat, 12 Mar 2011 23:37:41 GMT
	(envelope-from nobody)
Message-Id: <201103122337.p2CNbfJH004388@red.freebsd.org>
Date: Sat, 12 Mar 2011 23:37:41 GMT
From: Eitan Adler <lists@eitanadler.com>
To: freebsd-gnats-submit@FreeBSD.org
Subject: [patch] remove sanity check for X_WINDOW_SYSTEM
X-Send-Pr-Version: www-3.1
X-GNATS-Notify:

>Number:         155503
>Category:       misc
>Synopsis:       [patch] remove sanity check for X_WINDOW_SYSTEM
>Confidential:   no
>Severity:       non-critical
>Priority:       low
>Responsible:    freebsd-bugs
>State:          closed
>Quarter:        
>Keywords:       
>Date-Required:  
>Class:          sw-bug
>Submitter-Id:   current-users
>Arrival-Date:   Sat Mar 12 23:40:11 UTC 2011
>Closed-Date:    Sat Mar 12 18:45:05 EST 2011
>Last-Modified:  Sat Mar 12 18:45:05 EST 2011
>Originator:     Eitan Adler
>Release:        
>Organization:
>Environment:
>Description:
A check to see if X_WINDOW_SYSTEM is defined has been in b.p.m since 2008 when flz committed it. The variable is not used anywhere in the ports tree now and the check deserves to be removed. 

1.590        (flz      07-Mar-08): .if defined(X_WINDOW_SYSTEM) && ${X_WINDOW_SYSTEM:L} != "xorg"
1.590        (flz      07-Mar-08): IGNORE=              cannot be installed: bad X_WINDOW_SYSTEM setting; valid value is 'xorg'
1.566        (flz      19-May-07): .endif

>How-To-Repeat:

>Fix:
Index: bsd.port.mk
===================================================================
RCS file: /home/ncvs/ports/Mk/bsd.port.mk,v
retrieving revision 1.674
diff -u -r1.674 bsd.port.mk
--- bsd.port.mk	7 Mar 2011 07:32:05 -0000	1.674
+++ bsd.port.mk	12 Mar 2011 23:18:54 -0000
@@ -1396,10 +1396,6 @@
 .include "${PORTSDIR}/Mk/bsd.linux-apps.mk"
 .endif
 
-.if defined(X_WINDOW_SYSTEM) && ${X_WINDOW_SYSTEM:L} != "xorg"
-IGNORE=		cannot be installed: bad X_WINDOW_SYSTEM setting; valid value is 'xorg'
-.endif
-
 .if ${X11BASE} != ${LOCALBASE}
 .BEGIN:
 	@${ECHO_MSG} "X11BASE is now deprecated.  Unset X11BASE in make.conf and try again."


>Release-Note:
>Audit-Trail:
State-Changed-From-To: open->closed 
State-Changed-By: eadler 
State-Changed-When: Sat Mar 12 18:44:46 EST 2011 
State-Changed-Why:  
Duplicate - sorry 

http://www.freebsd.org/cgi/query-pr.cgi?pr=155503 
>Unformatted:
