From bugg@bugg.strangled.net Sun Dec  5 15:54:59 1999
Return-Path: <bugg@bugg.strangled.net>
Received: from bugg.strangled.net (c705742-a.htfdw1.ct.home.com [24.2.137.94])
	by hub.freebsd.org (Postfix) with ESMTP id 4B58614A2E
	for <FreeBSD-gnats-submit@freebsd.org>; Sun,  5 Dec 1999 15:54:54 -0800 (PST)
	(envelope-from bugg@bugg.strangled.net)
Received: (from root@localhost)
	by bugg.strangled.net (8.9.3/8.9.3) id SAA07598;
	Sun, 5 Dec 1999 18:54:51 -0500 (EST)
	(envelope-from bugg)
Message-Id: <199912052354.SAA07598@bugg.strangled.net>
Date: Sun, 5 Dec 1999 18:54:51 -0500 (EST)
From: bugg@bugg.strangled.net
Reply-To: bugg@bugg.strangled.net
To: FreeBSD-gnats-submit@freebsd.org
Subject: pkg_version -c output isn't safe for scripts to use 
X-Send-Pr-Version: 3.2

>Number:         15288
>Category:       misc
>Synopsis:       pkg_version -c output isn't safe for scripts to use
>Confidential:   no
>Severity:       non-critical
>Priority:       low
>Responsible:    jkh
>State:          closed
>Quarter:        
>Keywords:       
>Date-Required:  
>Class:          change-request
>Submitter-Id:   current-users
>Arrival-Date:   Sun Dec  5 16:00:01 PST 1999
>Closed-Date:    Mon Aug 7 07:02:04 PDT 2000
>Last-Modified:  Mon Aug 07 07:03:18 PDT 2000
>Originator:     dan
>Release:        FreeBSD 4.0-CURRENT i386
>Organization:
none   
>Environment:
Any with pkg_version (only -CURRENT now)
	

>Description:
pkg_version -c outputs commands to run to update your packages..
Before deleting the old version, it does nothing to ensure that the new
package can be installed.  Result: you can be stuck without your old version
and the new version not compiling.
	

>How-To-Repeat:
Run commands from pkg_version -c blindly (i.e. by a script) when one of the
ports that it is going to update is broken.
	

>Fix:
Patch follows:
*** pkg_version-old.pl  Fri Nov 26 15:38:18 1999
--- pkg_version.pl      Sun Dec  5 17:42:13 1999
***************
*** 293,304 ****
  $CommentChar, $Comment  
  @<
  $CommentChar
  cd @<<<<<<<<<<<<<<<<<<<<<<<<<<<<<<<<<<<<<<<<<<<<<<<<<<<<<<<<<<<<<<<<<<<<<<<<
  $packagePath
! make
! pkg_delete -f @<<<<<<<<<<<<<<<<<<<<<<<<<<<<<<<<<<<<<<<<<<<<<<<<<<<<<<<<<<<<<
                $packageNameVer
  make install
  
  .
    ;
--- 293,303 ----
  $CommentChar, $Comment  
  @<
  $CommentChar
  cd @<<<<<<<<<<<<<<<<<<<<<<<<<<<<<<<<<<<<<<<<<<<<<<<<<<<<<<<<<<<<<<<<<<<<<<<<
  $packagePath
! make && pkg_delete -f @<<<<<<<<<<<<<<<<<<<<<<<<<<<<<<<<<<<<<<<<<<<<<<<<<<<<<<<<<<<<<
                $packageNameVer
  make install
  
  .
    ;

	


>Release-Note:
>Audit-Trail:
Responsible-Changed-From-To: freebsd-bugs->billf  
Responsible-Changed-By: cpiazza 
Responsible-Changed-When: Sun Dec 5 16:04:12 PST 1999 
Responsible-Changed-Why:  
Over to maintainer 
State-Changed-From-To: open->closed 
State-Changed-By: sheldonh 
State-Changed-When: Mon Aug 7 07:02:04 PDT 2000 
State-Changed-Why:  
Fixed in HEAD and in RELENG_4 as far back as 4.0-RELEASE. 


Responsible-Changed-From-To: billf->jkh 
Responsible-Changed-By: sheldonh 
Responsible-Changed-When: Mon Aug 7 07:02:04 PDT 2000 
Responsible-Changed-Why:  
Jordan fixed this. 

http://www.freebsd.org/cgi/query-pr.cgi?pr=15288 
>Unformatted:
