From lev@ftp.translate.ru  Sun Oct 24 18:37:28 2010
Return-Path: <lev@ftp.translate.ru>
Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2001:4f8:fff6::34])
	by hub.freebsd.org (Postfix) with ESMTP id DF9211065694
	for <FreeBSD-gnats-submit@freebsd.org>; Sun, 24 Oct 2010 18:37:28 +0000 (UTC)
	(envelope-from lev@ftp.translate.ru)
Received: from ftp.translate.ru (ftp.translate.ru [80.249.188.42])
	by mx1.freebsd.org (Postfix) with ESMTP id A066F8FC08
	for <FreeBSD-gnats-submit@freebsd.org>; Sun, 24 Oct 2010 18:37:28 +0000 (UTC)
Received: by ftp.translate.ru (Postfix, from userid 1000)
	id 9876C13DF46; Sun, 24 Oct 2010 22:37:27 +0400 (MSD)
Message-Id: <20101024183727.9876C13DF46@ftp.translate.ru>
Date: Sun, 24 Oct 2010 22:37:27 +0400 (MSD)
From: Lev Serebryakov <lev@FreeBSD.org>
Reply-To: Lev Serebryakov <lev@FreeBSD.org>
To: FreeBSD-gnats-submit@freebsd.org
Cc:
Subject: [nanobsd] [patch] nanobsd.sh doesn't run "make_conf_build" if world build is supressed and kernel build is not
X-Send-Pr-Version: 3.113
X-GNATS-Notify:

>Number:         151696
>Category:       misc
>Synopsis:       [nanobsd] [patch] nanobsd.sh doesn't run "make_conf_build" if world build is supressed and kernel build is not
>Confidential:   no
>Severity:       serious
>Priority:       medium
>Responsible:    imp
>State:          closed
>Quarter:        
>Keywords:       
>Date-Required:  
>Class:          sw-bug
>Submitter-Id:   current-users
>Arrival-Date:   Sun Oct 24 18:40:10 UTC 2010
>Closed-Date:    Thu Mar 13 22:16:56 MDT 2014
>Last-Modified:  Thu Mar 13 22:16:56 MDT 2014
>Originator:     Lev Serebryakov
>Release:        FreeBSD 8.1-STABLE i386
>Organization:
>Environment:
System: FreeBSD vmware-8-32.home.serebryakov.spb.ru 8.1-STABLE FreeBSD 8.1-STABLE #1: Wed Oct 20 18:55:10 MSD 2010 root@vmware-8-32.home.serebryakov.spb.ru:/usr/obj/usr/src/sys/GENERIC i386

>Description:

   nanobsd.sh doesn't create build make.conf if world build is supressed (-w option) and kernel build is required.

>How-To-Repeat:

  Make full run of nanobsd.sh, remove make.conf.build, run "nanobsd.sh -w" to rebuild kernel.

>Fix:
--- nanobsd.sh.orig	2010-10-24 22:20:07.000000000 +0400
+++ nanobsd.sh.bugfix.cfg	2010-10-24 22:16:37.000000000 +0400
@@ -867,6 +867,9 @@
 fi
 
 if $do_kernel ; then
+	if ! $do_world ; then
+ 		make_conf_build
+	fi
 	build_kernel
 else
 	pprint 2 "Skipping buildkernel (as instructed)"
>Release-Note:
>Audit-Trail:
Responsible-Changed-From-To: freebsd-bugs->freebsd-embedded 
Responsible-Changed-By: lev 
Responsible-Changed-When: Sun Oct 24 18:46:01 UTC 2010 
Responsible-Changed-Why:  

Over to maintainer(s). 


http://www.freebsd.org/cgi/query-pr.cgi?pr=151696 
State-Changed-From-To: open->patched 
State-Changed-By: imp 
State-Changed-When: Tue Nov 9 17:57:09 MST 2010 
State-Changed-Why:  
Thanks for this fix! 

http://www.freebsd.org/cgi/query-pr.cgi?pr=151696 

From: dfilter@FreeBSD.ORG (dfilter service)
To: bug-followup@FreeBSD.org
Cc:  
Subject: Re: misc/151696: commit references a PR
Date: Wed, 10 Nov 2010 00:56:52 +0000 (UTC)

 Author: imp
 Date: Wed Nov 10 00:56:44 2010
 New Revision: 215070
 URL: http://svn.freebsd.org/changeset/base/215070
 
 Log:
   Build make.conf when the world is not selected to build, but the
   kernel is.
   
   PR:		151696
   Submitted by:	lev@
 
 Modified:
   head/tools/tools/nanobsd/nanobsd.sh
 
 Modified: head/tools/tools/nanobsd/nanobsd.sh
 ==============================================================================
 --- head/tools/tools/nanobsd/nanobsd.sh	Wed Nov 10 00:39:42 2010	(r215069)
 +++ head/tools/tools/nanobsd/nanobsd.sh	Wed Nov 10 00:56:44 2010	(r215070)
 @@ -917,6 +917,9 @@ else
  fi
  
  if $do_kernel ; then
 +	if ! $do_world ; then
 +		make_conf_build
 +	fi
  	build_kernel
  else
  	pprint 2 "Skipping buildkernel (as instructed)"
 _______________________________________________
 svn-src-all@freebsd.org mailing list
 http://lists.freebsd.org/mailman/listinfo/svn-src-all
 To unsubscribe, send any mail to "svn-src-all-unsubscribe@freebsd.org"
 
Responsible-Changed-From-To: freebsd-embedded->imp 
Responsible-Changed-By: linimon 
Responsible-Changed-When: Sun Jun 5 05:44:10 UTC 2011 
Responsible-Changed-Why:  
Over to committer as MFC reminder. 

http://www.freebsd.org/cgi/query-pr.cgi?pr=151696 

From: Garrett Cooper <yanegomi@gmail.com>
To: bug-followup@FreeBSD.org, lev@FreeBSD.org
Cc:  
Subject: Re: misc/151696: [nanobsd] [patch] nanobsd.sh doesn&#39;t run
 &quot;make_conf_build&quot; if world build is supressed and kernel build is not
Date: Mon, 9 Jan 2012 14:10:04 -0800

     It's been a year. Shouldn't this be MFCed?
 Thanks,
 -Garrett
State-Changed-From-To: patched->closed 
State-Changed-By: imp 
State-Changed-When: Thu Mar 13 22:16:30 MDT 2014 
State-Changed-Why:  
This is in 9 and 10, so can be closed. 


http://www.freebsd.org/cgi/query-pr.cgi?pr=151696 
>Unformatted:
