From nobody@FreeBSD.org  Fri Jun  4 08:37:14 2010
Return-Path: <nobody@FreeBSD.org>
Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2001:4f8:fff6::34])
	by hub.freebsd.org (Postfix) with ESMTP id 24E48106566C
	for <freebsd-gnats-submit@FreeBSD.org>; Fri,  4 Jun 2010 08:37:14 +0000 (UTC)
	(envelope-from nobody@FreeBSD.org)
Received: from www.freebsd.org (www.freebsd.org [IPv6:2001:4f8:fff6::21])
	by mx1.freebsd.org (Postfix) with ESMTP id 1472B8FC16
	for <freebsd-gnats-submit@FreeBSD.org>; Fri,  4 Jun 2010 08:37:14 +0000 (UTC)
Received: from www.freebsd.org (localhost [127.0.0.1])
	by www.freebsd.org (8.14.3/8.14.3) with ESMTP id o548bDku037608
	for <freebsd-gnats-submit@FreeBSD.org>; Fri, 4 Jun 2010 08:37:13 GMT
	(envelope-from nobody@www.freebsd.org)
Received: (from nobody@localhost)
	by www.freebsd.org (8.14.3/8.14.3/Submit) id o548bD4B037607;
	Fri, 4 Jun 2010 08:37:13 GMT
	(envelope-from nobody)
Message-Id: <201006040837.o548bD4B037607@www.freebsd.org>
Date: Fri, 4 Jun 2010 08:37:13 GMT
From: Erik Cederstrand <erik@cederstrand.dk>
To: freebsd-gnats-submit@FreeBSD.org
Subject: Patch for tools/regression/lib/libc/string/Makefile
X-Send-Pr-Version: www-3.1
X-GNATS-Notify:

>Number:         147463
>Category:       misc
>Synopsis:       [tools] [patch] Patch for tools/regression/lib/libc/string/Makefile
>Confidential:   no
>Severity:       non-critical
>Priority:       low
>Responsible:    freebsd-bugs
>State:          open
>Quarter:        
>Keywords:       
>Date-Required:  
>Class:          sw-bug
>Submitter-Id:   current-users
>Arrival-Date:   Fri Jun 04 08:40:01 UTC 2010
>Closed-Date:    
>Last-Modified:  Wed Oct 05 10:45:03 UTC 2011
>Originator:     Erik Cederstrand
>Release:        FreeBSD 9.0-CURRENT
>Organization:
>Environment:
FreeBSD clangbsd.local 9.0-CURRENT FreeBSD 9.0-CURRENT #0 r208730: Wed Jun  2 19:10:36 CEST 2010     erik@clangbsd.local:/usr/obj/usr/home/erik/freebsd/clang/src/sys/GENERIC  amd64
>Description:
tools/regression/lib/libc/string/Makefile is, in contrast to most other tests, dependent on devel/libtap. Not having ltap library gives an error when running 'make'.

Warn the user what's wrong.
>How-To-Repeat:
cd tools/regression/lib/libc/string/
make
>Fix:
Apply the patch to get better error message.

cd /usr/ports/devel/libtap && make install

to install libtap and be able to build the test

Patch attached with submission follows:

Index: tools/regression/lib/libc/string/Makefile
===================================================================
--- tools/regression/lib/libc/string/Makefile	(revision 208730)
+++ tools/regression/lib/libc/string/Makefile	(working copy)
@@ -6,6 +6,11 @@
 
 TESTS=	test-stpncpy test-strerror test-wcscasecmp test-wcsnlen
 
+LTAP_INSTALLED!= pkg_version | grep libtap
+.if ${LTAP_INSTALLED} == ""
+.error "devel/libtap not installed"
+.endif
+
 .PHONY: tests
 tests: ${TESTS}
 	for p in ${TESTS}; do ${.OBJDIR}/$$p; done


>Release-Note:
>Audit-Trail:
>Unformatted:
