From nobody@FreeBSD.org  Fri Feb 12 03:28:15 2010
Return-Path: <nobody@FreeBSD.org>
Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2001:4f8:fff6::34])
	by hub.freebsd.org (Postfix) with ESMTP id 793DA106566C
	for <freebsd-gnats-submit@FreeBSD.org>; Fri, 12 Feb 2010 03:28:15 +0000 (UTC)
	(envelope-from nobody@FreeBSD.org)
Received: from www.freebsd.org (www.freebsd.org [IPv6:2001:4f8:fff6::21])
	by mx1.freebsd.org (Postfix) with ESMTP id 6967F8FC0A
	for <freebsd-gnats-submit@FreeBSD.org>; Fri, 12 Feb 2010 03:28:15 +0000 (UTC)
Received: from www.freebsd.org (localhost [127.0.0.1])
	by www.freebsd.org (8.14.3/8.14.3) with ESMTP id o1C3SFLK019090
	for <freebsd-gnats-submit@FreeBSD.org>; Fri, 12 Feb 2010 03:28:15 GMT
	(envelope-from nobody@www.freebsd.org)
Received: (from nobody@localhost)
	by www.freebsd.org (8.14.3/8.14.3/Submit) id o1C3SFtm019082;
	Fri, 12 Feb 2010 03:28:15 GMT
	(envelope-from nobody)
Message-Id: <201002120328.o1C3SFtm019082@www.freebsd.org>
Date: Fri, 12 Feb 2010 03:28:15 GMT
From: Garrett Cooper <yaneurabeya@gmail.com>
To: freebsd-gnats-submit@FreeBSD.org
Subject: Fix missing atm -> bsnmp dependency
X-Send-Pr-Version: www-3.1
X-GNATS-Notify:

>Number:         143831
>Category:       misc
>Synopsis:       [bsd.own.mk] [patch] Fix missing atm -> bsnmp dependency
>Confidential:   no
>Severity:       non-critical
>Priority:       medium
>Responsible:    freebsd-bugs
>State:          closed
>Quarter:        
>Keywords:       
>Date-Required:  
>Class:          sw-bug
>Submitter-Id:   current-users
>Arrival-Date:   Fri Feb 12 03:30:01 UTC 2010
>Closed-Date:    Wed Oct 26 12:38:51 UTC 2011
>Last-Modified:  Sun Feb 03 22:28:01 UTC 2013
>Originator:     Garrett Cooper
>Release:        RELENG_8
>Organization:
Cisco Systems, Inc
>Environment:
FreeBSD garrcoop-fbsd.cisco.com 8.0-STABLE FreeBSD 8.0-STABLE #2: Wed Feb  3 16:57:07 PST 2010     garrcoop@garrcoop-fbsd.cisco.com:/usr/obj/usr/src/sys/LAPPY_X86  i386
>Description:
bsnmp is required by atm as it uses some of bsnmp's headers and the tools used generated OID data. This relationship isn't expressed in bsd.own.mk, and thus build failures occur, as seen in PR # 143830.

The patch attached properly addresses the dependency between atm and bsnmp.
>How-To-Repeat:
make -C sbin/atm WITHOUT_BSNMP=yes depend
>Fix:
Invoke with `WITHOUT_ATM=no WITHOUT_BSNMP=no' or `WITH_ATM=yes WITH_BSNMP=yes'.

Patch attached with submission follows:

Index: bsd.own.mk
===================================================================
--- bsd.own.mk	(revision 203532)
+++ bsd.own.mk	(working copy)
@@ -449,6 +449,10 @@
 MK_BIND_ETC:=	no
 .endif
 
+.if ${MK_BSNMP} == "no"
+MK_ATM:= no
+.endif
+
 .if ${MK_CDDL} == "no"
 MK_ZFS:=	no
 .endif


>Release-Note:
>Audit-Trail:

From: "Bjoern A. Zeeb" <bz@FreeBSD.org>
To: bug-followup@FreeBSD.org, gcooper@FreeBSD.org
Cc: miwi@FreeBSD.org
Subject: Re: misc/143831: [bsd.own.mk] [patch] Fix missing atm -> bsnmp
 dependency
Date: Mon, 21 Feb 2011 18:46:20 +0000 (UTC)

 Hi,
 
 I think the patch is too excessive, as is the following in bsd.own.mk:
 
 .if ${MK_NETGRAPH} == "no"
 MK_ATM:=        no
 MK_BLUETOOTH:=  no
 .endif
 
 To my understanding disabling all of atm if we don't have netgraph
 seems wrong but probably was an easy path at some point.
 
 Without testing I think the following patch should be enough:
 
 Index: rescue/rescue/Makefile
 ===================================================================
 --- rescue/rescue/Makefile      (revision 218757)
 +++ rescue/rescue/Makefile      (working copy)
 @@ -99,7 +99,7 @@ CRUNCH_PROGS_sbin= atacontrol badsect                         \
          restore rcorder route routed rtquery rtsol savecore     \
          spppcontrol swapon sysctl tunefs umount
 
 -.if ${MK_ATM} != "no"
 +.if ${MK_ATM} != "no" && ${MK_BSNMP} != "no"
   CRUNCH_PROGS_sbin+= atmconfig
   .endif
 
 Index: sbin/Makefile
 ===================================================================
 --- sbin/Makefile       (revision 218757)
 +++ sbin/Makefile       (working copy)
 @@ -73,7 +73,7 @@ SUBDIR=adjkerntz \
          tunefs \
          umount \
 
 -.if ${MK_ATM} != "no"
 +.if ${MK_ATM} != "no" && ${MK_BSNMP} != "no"
   SUBDIR+=       atm
   .endif
 
 
 BTw, the test case of `make -C sbin/atm WITHOUT_BSNMP=yes depend`
 seems wrong as well as that actually ignores some checks in place.
 
 /bz
 
 -- 
 Bjoern A. Zeeb                                 You have to have visions!
           Stop bit received. Insert coin for new address family.

From: Garrett Cooper <yaneurabeya@gmail.com>
To: bug-followup@FreeBSD.org,
 gcooper@FreeBSD.org
Cc:  
Subject: Re: misc/143831: [bsd.own.mk] [patch] Fix missing atm -&gt; bsnmp dependency
Date: Wed, 26 Oct 2011 00:55:17 -0700

 This PR should be closed in favor of the last patch that I submitted to =
 bin/143830 .
 Thanks!
 -Garrett=
State-Changed-From-To: open->closed 
State-Changed-By: linimon 
State-Changed-When: Wed Oct 26 12:38:34 UTC 2011 
State-Changed-Why:  
see bin/143830. 

http://www.freebsd.org/cgi/query-pr.cgi?pr=143831 
>Unformatted:
