From nobody@FreeBSD.org  Fri Jan 15 09:35:05 2010
Return-Path: <nobody@FreeBSD.org>
Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2001:4f8:fff6::34])
	by hub.freebsd.org (Postfix) with ESMTP id 0DAB81065696
	for <freebsd-gnats-submit@FreeBSD.org>; Fri, 15 Jan 2010 09:35:05 +0000 (UTC)
	(envelope-from nobody@FreeBSD.org)
Received: from www.freebsd.org (www.freebsd.org [IPv6:2001:4f8:fff6::21])
	by mx1.freebsd.org (Postfix) with ESMTP id 705BB8FC17
	for <freebsd-gnats-submit@FreeBSD.org>; Fri, 15 Jan 2010 09:35:04 +0000 (UTC)
Received: from www.freebsd.org (localhost [127.0.0.1])
	by www.freebsd.org (8.14.3/8.14.3) with ESMTP id o0F9Z4R6032601
	for <freebsd-gnats-submit@FreeBSD.org>; Fri, 15 Jan 2010 09:35:04 GMT
	(envelope-from nobody@www.freebsd.org)
Received: (from nobody@localhost)
	by www.freebsd.org (8.14.3/8.14.3/Submit) id o0F9Z4o0032599;
	Fri, 15 Jan 2010 09:35:04 GMT
	(envelope-from nobody)
Message-Id: <201001150935.o0F9Z4o0032599@www.freebsd.org>
Date: Fri, 15 Jan 2010 09:35:04 GMT
From: Nikolay Denev <ndenev@gmail.com>
To: freebsd-gnats-submit@FreeBSD.org
Subject: Mistaken comment in Makefile.inc1
X-Send-Pr-Version: www-3.1
X-GNATS-Notify:

>Number:         142854
>Category:       misc
>Synopsis:       [build] [patch] Mistaken comment in Makefile.inc1
>Confidential:   no
>Severity:       non-critical
>Priority:       low
>Responsible:    freebsd-bugs
>State:          closed
>Quarter:        
>Keywords:       
>Date-Required:  
>Class:          doc-bug
>Submitter-Id:   current-users
>Arrival-Date:   Fri Jan 15 09:40:01 UTC 2010
>Closed-Date:    Fri Jan 15 21:49:51 CET 2010
>Last-Modified:  Sun Jan 17 18:20:00 UTC 2010
>Originator:     Nikolay Denev
>Release:        8-STABLE
>Organization:
>Environment:
FreeBSD zoo.dev 8.0-STABLE FreeBSD 8.0-STABLE #13: Fri Jan  8 14:28:43 CET 2010     ndenev@zoo.dev:/usr/obj/usr/src/sys/ZOO  amd64
>Description:
The comment describing the KERNFAST kernel build options is mistaken. It mentions NO_KERNELCONFIG twice, and misses NO_KERNELDEPEND.
>How-To-Repeat:
less /usr/src/Makefile.inc1 :)
>Fix:
patch attached

Patch attached with submission follows:

--- .zfs/snapshot/orig/Makefile.inc1	2009-10-19 07:50:09.155942307 +0300
+++ Makefile.inc1	2010-01-15 11:29:44.912960900 +0200
@@ -5,7 +5,7 @@
 #	-DNO_CLEANDIR run ${MAKE} clean, instead of ${MAKE} cleandir
 #	-DNO_CLEAN do not clean at all
 #	-DNO_SHARE do not go into share subdir
-#	-DKERNFAST define NO_KERNELCONFIG, NO_KERNELCLEAN and NO_KERNELCONFIG
+#	-DKERNFAST define NO_KERNELCONFIG, NO_KERNELCLEAN and NO_KERNELDEPEND
 #	-DNO_KERNELCONFIG do not run config in ${MAKE} buildkernel
 #	-DNO_KERNELCLEAN do not run ${MAKE} clean in ${MAKE} buildkernel
 #	-DNO_KERNELDEPEND do not run ${MAKE} depend in ${MAKE} buildkernel


>Release-Note:
>Audit-Trail:
State-Changed-From-To: open->closed 
State-Changed-By: brueffer 
State-Changed-When: Fri Jan 15 21:28:07 CET 2010 
State-Changed-Why:  
This was fixed in HEAD but never MFCd, which I've done now. 
Thanks for the report! 

http://www.freebsd.org/cgi/query-pr.cgi?pr=142854 

From: dfilter@FreeBSD.ORG (dfilter service)
To: bug-followup@FreeBSD.org
Cc:  
Subject: Re: misc/142854: commit references a PR
Date: Sun, 17 Jan 2010 18:17:11 +0000 (UTC)

 Author: brueffer
 Date: Sun Jan 17 18:17:00 2010
 New Revision: 202501
 URL: http://svn.freebsd.org/changeset/base/202501
 
 Log:
   MFC: r197056 by des
   
   Fix comment about KERNFAST.
   
   PR:             142854
   Submitted by:   Nikolay Denev <ndenev@gmail.com>
 
 Modified:
   stable/8/Makefile.inc1
 Directory Properties:
   stable/8/   (props changed)
 
 Modified: stable/8/Makefile.inc1
 ==============================================================================
 --- stable/8/Makefile.inc1	Sun Jan 17 17:52:35 2010	(r202500)
 +++ stable/8/Makefile.inc1	Sun Jan 17 18:17:00 2010	(r202501)
 @@ -5,7 +5,7 @@
  #	-DNO_CLEANDIR run ${MAKE} clean, instead of ${MAKE} cleandir
  #	-DNO_CLEAN do not clean at all
  #	-DNO_SHARE do not go into share subdir
 -#	-DKERNFAST define NO_KERNELCONFIG, NO_KERNELCLEAN and NO_KERNELCONFIG
 +#	-DKERNFAST define NO_KERNELCONFIG, NO_KERNELCLEAN and NO_KERNELDEPEND
  #	-DNO_KERNELCONFIG do not run config in ${MAKE} buildkernel
  #	-DNO_KERNELCLEAN do not run ${MAKE} clean in ${MAKE} buildkernel
  #	-DNO_KERNELDEPEND do not run ${MAKE} depend in ${MAKE} buildkernel
 _______________________________________________
 svn-src-all@freebsd.org mailing list
 http://lists.freebsd.org/mailman/listinfo/svn-src-all
 To unsubscribe, send any mail to "svn-src-all-unsubscribe@freebsd.org"
 
>Unformatted:
