From nobody@FreeBSD.org  Wed Oct  7 16:57:39 2009
Return-Path: <nobody@FreeBSD.org>
Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2001:4f8:fff6::34])
	by hub.freebsd.org (Postfix) with ESMTP id 9CEDB1065676
	for <freebsd-gnats-submit@FreeBSD.org>; Wed,  7 Oct 2009 16:57:39 +0000 (UTC)
	(envelope-from nobody@FreeBSD.org)
Received: from www.freebsd.org (www.freebsd.org [IPv6:2001:4f8:fff6::21])
	by mx1.freebsd.org (Postfix) with ESMTP id 8C28D8FC1E
	for <freebsd-gnats-submit@FreeBSD.org>; Wed,  7 Oct 2009 16:57:39 +0000 (UTC)
Received: from www.freebsd.org (localhost [127.0.0.1])
	by www.freebsd.org (8.14.3/8.14.3) with ESMTP id n97Gvdo4004700
	for <freebsd-gnats-submit@FreeBSD.org>; Wed, 7 Oct 2009 16:57:39 GMT
	(envelope-from nobody@www.freebsd.org)
Received: (from nobody@localhost)
	by www.freebsd.org (8.14.3/8.14.3/Submit) id n97GvdsN004699;
	Wed, 7 Oct 2009 16:57:39 GMT
	(envelope-from nobody)
Message-Id: <200910071657.n97GvdsN004699@www.freebsd.org>
Date: Wed, 7 Oct 2009 16:57:39 GMT
From: Gleb Kurtsou <gk@FreeBSD.org>
To: freebsd-gnats-submit@FreeBSD.org
Subject: [patch] fix tools/regression/tmpfs compilation on amd64
X-Send-Pr-Version: www-3.1
X-GNATS-Notify:

>Number:         139409
>Category:       misc
>Synopsis:       [patch] fix tools/regression/tmpfs compilation on amd64
>Confidential:   no
>Severity:       non-critical
>Priority:       low
>Responsible:    delphij
>State:          closed
>Quarter:        
>Keywords:       
>Date-Required:  
>Class:          sw-bug
>Submitter-Id:   current-users
>Arrival-Date:   Wed Oct 07 17:00:02 UTC 2009
>Closed-Date:    Wed Oct 07 23:01:46 UTC 2009
>Last-Modified:  Wed Oct  7 23:10:01 UTC 2009
>Originator:     Gleb Kurtsou
>Release:        
>Organization:
>Environment:
FreeBSD tops 9.0-CURRENT FreeBSD 9.0-CURRENT #7 r197735+8fb35f6: Sat Oct  3 21:22:17 EEST 2009     root@tops:/usr/obj/usr/freebsd-src/local/sys/TOPS  amd64
>Description:
Fix incorrect printf format string. Compilation fails on amd64
>How-To-Repeat:

>Fix:


Patch attached with submission follows:

diff --git a/tools/regression/tmpfs/h_tools.c b/tools/regression/tmpfs/h_tools.c
index 1339060..6e8a236 100644
--- a/tools/regression/tmpfs/h_tools.c
+++ b/tools/regression/tmpfs/h_tools.c
@@ -50,6 +50,7 @@
 #include <sys/event.h>
 #include <sys/mount.h>
 #include <sys/statvfs.h>
+#include <sys/stdint.h>
 #include <sys/socket.h>
 #include <sys/time.h>
 #include <sys/un.h>
@@ -250,10 +251,10 @@ statvfs_main(int argc, char **argv)
 		return EXIT_FAILURE;
 	}
 
-	(void)printf("f_bsize=%llu\n", buf.f_bsize);
-	(void)printf("f_blocks=%llu\n", buf.f_blocks);
-	(void)printf("f_bfree=%llu\n", buf.f_bfree);
-	(void)printf("f_files=%llu\n", buf.f_files);
+	(void)printf("f_bsize=%ju\n", (uintmax_t)buf.f_bsize);
+	(void)printf("f_blocks=%ju\n", (uintmax_t)buf.f_blocks);
+	(void)printf("f_bfree=%ju\n", (uintmax_t)buf.f_bfree);
+	(void)printf("f_files=%ju\n", (uintmax_t)buf.f_files);
 
 	return EXIT_SUCCESS;
 }


>Release-Note:
>Audit-Trail:

From: Maxim Konovalov <maxim@macomnet.ru>
To: Gleb Kurtsou <gk@freebsd.org>
Cc: bug-followup@freebsd.org
Subject: Re: misc/139409: [patch] fix tools/regression/tmpfs compilation on
 amd64
Date: Wed, 7 Oct 2009 21:03:58 +0400 (MSD)

 Why not just commit this?
 
 -- 
 Maxim Konovalov

From: Gleb Kurtsou <gleb.kurtsou@gmail.com>
To: Maxim Konovalov <maxim@macomnet.ru>
Cc: Gleb Kurtsou <gk@freebsd.org>, bug-followup@freebsd.org
Subject: Re: misc/139409: [patch] fix tools/regression/tmpfs compilation on
 amd64
Date: Wed, 7 Oct 2009 20:48:59 +0300

 On (07/10/2009 21:03), Maxim Konovalov wrote:
 > Why not just commit this?
 I'm just trying to find one who can. I have no commiters bit.
 
 > -- 
 > Maxim Konovalov
Responsible-Changed-From-To: freebsd-bugs->delphij 
Responsible-Changed-By: delphij 
Responsible-Changed-When: Wed Oct 7 23:00:14 UTC 2009 
Responsible-Changed-Why:  
Take. 

http://www.freebsd.org/cgi/query-pr.cgi?pr=139409 
State-Changed-From-To: open->closed 
State-Changed-By: delphij 
State-Changed-When: Wed Oct 7 23:01:35 UTC 2009 
State-Changed-Why:  
Committed, thanks! 

http://www.freebsd.org/cgi/query-pr.cgi?pr=139409 

From: dfilter@FreeBSD.ORG (dfilter service)
To: bug-followup@FreeBSD.org
Cc:  
Subject: Re: misc/139409: commit references a PR
Date: Wed,  7 Oct 2009 23:01:52 +0000 (UTC)

 Author: delphij
 Date: Wed Oct  7 23:01:31 2009
 New Revision: 197849
 URL: http://svn.freebsd.org/changeset/base/197849
 
 Log:
   Fix build on amd64.
   
   PR:		misc/139409
   Submitted by:	gk
 
 Modified:
   head/tools/regression/tmpfs/h_tools.c
 
 Modified: head/tools/regression/tmpfs/h_tools.c
 ==============================================================================
 --- head/tools/regression/tmpfs/h_tools.c	Wed Oct  7 22:21:53 2009	(r197848)
 +++ head/tools/regression/tmpfs/h_tools.c	Wed Oct  7 23:01:31 2009	(r197849)
 @@ -50,6 +50,7 @@
  #include <sys/event.h>
  #include <sys/mount.h>
  #include <sys/statvfs.h>
 +#include <sys/stdint.h>
  #include <sys/socket.h>
  #include <sys/time.h>
  #include <sys/un.h>
 @@ -250,10 +251,10 @@ statvfs_main(int argc, char **argv)
  		return EXIT_FAILURE;
  	}
  
 -	(void)printf("f_bsize=%llu\n", buf.f_bsize);
 -	(void)printf("f_blocks=%llu\n", buf.f_blocks);
 -	(void)printf("f_bfree=%llu\n", buf.f_bfree);
 -	(void)printf("f_files=%llu\n", buf.f_files);
 +	(void)printf("f_bsize=%ju\n", (uintmax_t)buf.f_bsize);
 +	(void)printf("f_blocks=%ju\n", (uintmax_t)buf.f_blocks);
 +	(void)printf("f_bfree=%ju\n", (uintmax_t)buf.f_bfree);
 +	(void)printf("f_files=%ju\n", (uintmax_t)buf.f_files);
  
  	return EXIT_SUCCESS;
  }
 _______________________________________________
 svn-src-all@freebsd.org mailing list
 http://lists.freebsd.org/mailman/listinfo/svn-src-all
 To unsubscribe, send any mail to "svn-src-all-unsubscribe@freebsd.org"
 
>Unformatted:
