From nobody@FreeBSD.org  Wed Aug 12 07:46:20 2009
Return-Path: <nobody@FreeBSD.org>
Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2001:4f8:fff6::34])
	by hub.freebsd.org (Postfix) with ESMTP id 2B5881065670
	for <freebsd-gnats-submit@FreeBSD.org>; Wed, 12 Aug 2009 07:46:20 +0000 (UTC)
	(envelope-from nobody@FreeBSD.org)
Received: from www.freebsd.org (www.freebsd.org [IPv6:2001:4f8:fff6::21])
	by mx1.freebsd.org (Postfix) with ESMTP id 1B0518FC3E
	for <freebsd-gnats-submit@FreeBSD.org>; Wed, 12 Aug 2009 07:46:20 +0000 (UTC)
Received: from www.freebsd.org (localhost [127.0.0.1])
	by www.freebsd.org (8.14.3/8.14.3) with ESMTP id n7C7kJ6I035033
	for <freebsd-gnats-submit@FreeBSD.org>; Wed, 12 Aug 2009 07:46:19 GMT
	(envelope-from nobody@www.freebsd.org)
Received: (from nobody@localhost)
	by www.freebsd.org (8.14.3/8.14.3/Submit) id n7C7kJhF035032;
	Wed, 12 Aug 2009 07:46:19 GMT
	(envelope-from nobody)
Message-Id: <200908120746.n7C7kJhF035032@www.freebsd.org>
Date: Wed, 12 Aug 2009 07:46:19 GMT
From: Michael Leun <michael.leun@arcor.net>
To: freebsd-gnats-submit@FreeBSD.org
Subject: [patch] Release build fails, if build-system uses HTTP/FTP proxy
X-Send-Pr-Version: www-3.1
X-GNATS-Notify:

>Number:         137688
>Category:       misc
>Synopsis:       [build] [patch] Release build fails, if build-system uses HTTP/FTP proxy
>Confidential:   no
>Severity:       serious
>Priority:       medium
>Responsible:    re
>State:          closed
>Quarter:        
>Keywords:       
>Date-Required:  
>Class:          sw-bug
>Submitter-Id:   current-users
>Arrival-Date:   Wed Aug 12 07:50:01 UTC 2009
>Closed-Date:    Wed May 05 16:42:27 UTC 2010
>Last-Modified:  Wed May  5 16:50:02 UTC 2010
>Originator:     Michael Leun
>Release:        7.2 RELEASE
>Organization:
Vodafone AG & Co. KG
>Environment:
FreeBSD build72-64.tnd.arcor.net 7.2-RELEASE FreeBSD 7.2-RELEASE #0: Fri May  1 07:18:07 UTC 2009     root@driscoll.cse.buffalo.edu:/usr/obj/usr/src/sys/GENERIC  amd64
>Description:
I've created an custom install disk and had to use a build-system which has to use an http/ftp proxy.

Build failed, because /usr/src/release/Makefile does not hand over environment variables HTTP_PROXY and FTP_PROXY to the chroot build script it creates, which therefore fails to fetch perl during the build process.
>How-To-Repeat:
Use a system accessing web/ftp via proxy, have environment variables HTTP_PROXY and FTP_PROXY defined.

cd /usr/src/release
make release
>Fix:
patch attached

Patch attached with submission follows:

--- release/Makefile.orig	2009-08-12 09:31:02.000000000 +0200
+++ release/Makefile	2009-08-12 09:33:17.000000000 +0200
@@ -531,7 +531,7 @@
 	echo "	for i in ${MAKEINDEXPORTS}"	>> ${_MK}
 	echo "	do"			>> ${_MK}
 	echo "		cd /usr/ports/\$${i}"	>> ${_MK}
-	echo "		env -i FTP_PASSIVE_MODE=$${FTP_PASSIVE_MODE:-no} PATH=$${PATH} \\" >> ${_MK}
+	echo "		env -i HTTP_PROXY=$${HTTP_PROXY} FTP_PROXY=$${FTP_PROXY} FTP_PASSIVE_MODE=$${FTP_PASSIVE_MODE:-no} PATH=$${PATH} \\" >> ${_MK}
 	echo "		make all install clean BATCH=yes FORCE_PKG_REGISTER=yes" >> ${_MK}
 	echo "	done"				>> ${_MK}
 	echo "	cd /usr/ports"			>> ${_MK}


>Release-Note:
>Audit-Trail:
Responsible-Changed-From-To: freebsd-bugs->re 
Responsible-Changed-By: remko 
Responsible-Changed-When: Thu Aug 13 06:22:57 UTC 2009 
Responsible-Changed-Why:  
This looks like something for the release engineers.. 

http://www.freebsd.org/cgi/query-pr.cgi?pr=137688 

From: Robert Watson <rwatson@FreeBSD.org>
To: remko@FreeBSD.org
Cc: re@FreeBSD.org, bug-followup@FreeBSD.org
Subject: Re: misc/137688: [build] [patch] Release build fails, if build-system
 uses HTTP/FTP proxy
Date: Sun, 11 Oct 2009 12:45:34 +0100 (BST)

 On Thu, 13 Aug 2009, remko@FreeBSD.org wrote:
 
 > Synopsis: [build] [patch] Release build fails, if build-system uses HTTP/FTP proxy
 >
 > Responsible-Changed-From-To: freebsd-bugs->re
 > Responsible-Changed-By: remko
 > Responsible-Changed-When: Thu Aug 13 06:22:57 UTC 2009
 > Responsible-Changed-Why:
 > This looks like something for the release engineers..
 >
 > http://www.freebsd.org/cgi/query-pr.cgi?pr=137688
 
 This change doesn't sound unreasonable, especially as the release process 
 attempts to preserve other similar state, such as FTP passive mode 
 configuration.  Ken, how do you feel about this one?
 
 Robert
State-Changed-From-To: open->patched 
State-Changed-By: kensmith 
State-Changed-When: Fri Apr 9 14:29:16 UTC 2010 
State-Changed-Why:  

Patch committed to head as r206422, MFC set for 2 weeks. 


http://www.freebsd.org/cgi/query-pr.cgi?pr=137688 

From: dfilter@FreeBSD.ORG (dfilter service)
To: bug-followup@FreeBSD.org
Cc:  
Subject: Re: misc/137688: commit references a PR
Date: Fri,  9 Apr 2010 14:24:09 +0000 (UTC)

 Author: kensmith
 Date: Fri Apr  9 14:24:00 2010
 New Revision: 206422
 URL: http://svn.freebsd.org/changeset/base/206422
 
 Log:
   Pass the HTTP_PROXY and FTP_PROXY environment variables through in addition
   to FTP_PASSIVE_MODE so release building works for a machine that needs
   to use a proxy.
   
   PR:		misc/137688
   Submitted by:	Michael Leun
   MFC after:	2 weeks
 
 Modified:
   head/release/Makefile
 
 Modified: head/release/Makefile
 ==============================================================================
 --- head/release/Makefile	Fri Apr  9 14:22:09 2010	(r206421)
 +++ head/release/Makefile	Fri Apr  9 14:24:00 2010	(r206422)
 @@ -575,7 +575,7 @@ release rerelease:
  	echo "	for i in ${MAKEINDEXPORTS}"	>> ${_MK}
  	echo "	do"			>> ${_MK}
  	echo "		cd /usr/ports/\$${i}"	>> ${_MK}
 -	echo "		env -i FTP_PASSIVE_MODE=$${FTP_PASSIVE_MODE:-no} PATH=$${PATH} \\" >> ${_MK}
 +	echo "		env -i HTTP_PROXY=$${HTTP_PROXY} FTP_PROXY=$${FTP_PROXY} FTP_PASSIVE_MODE=$${FTP_PASSIVE_MODE:-no} PATH=$${PATH} \\" >> ${_MK}
  	echo "		make all install clean BATCH=yes FORCE_PKG_REGISTER=yes" >> ${_MK}
  	echo "	done"				>> ${_MK}
  	echo "	cd /usr/ports"			>> ${_MK}
 _______________________________________________
 svn-src-all@freebsd.org mailing list
 http://lists.freebsd.org/mailman/listinfo/svn-src-all
 To unsubscribe, send any mail to "svn-src-all-unsubscribe@freebsd.org"
 

From: dfilter@FreeBSD.ORG (dfilter service)
To: bug-followup@FreeBSD.org
Cc:  
Subject: Re: misc/137688: commit references a PR
Date: Wed,  5 May 2010 16:26:33 +0000 (UTC)

 Author: kensmith
 Date: Wed May  5 16:25:57 2010
 New Revision: 207660
 URL: http://svn.freebsd.org/changeset/base/207660
 
 Log:
   Merge r206422:
   
   > Pass the HTTP_PROXY and FTP_PROXY environment variables through in addition
   > to FTP_PASSIVE_MODE so release building works for a machine that needs
   > to use a proxy.
   
   PR:		misc/137688
   Submitted by:	Michael Leun
 
 Modified:
   stable/8/release/Makefile
 Directory Properties:
   stable/8/release/   (props changed)
   stable/8/release/picobsd/   (props changed)
   stable/8/release/picobsd/floppy.tree/sbin/   (props changed)
   stable/8/release/picobsd/floppy.tree/sbin/dhclient-script   (props changed)
   stable/8/release/picobsd/qemu/   (props changed)
 
 Modified: stable/8/release/Makefile
 ==============================================================================
 --- stable/8/release/Makefile	Wed May  5 16:05:51 2010	(r207659)
 +++ stable/8/release/Makefile	Wed May  5 16:25:57 2010	(r207660)
 @@ -575,7 +575,7 @@ release rerelease:
  	echo "	for i in ${MAKEINDEXPORTS}"	>> ${_MK}
  	echo "	do"			>> ${_MK}
  	echo "		cd /usr/ports/\$${i}"	>> ${_MK}
 -	echo "		env -i FTP_PASSIVE_MODE=$${FTP_PASSIVE_MODE:-no} PATH=$${PATH} \\" >> ${_MK}
 +	echo "		env -i HTTP_PROXY=$${HTTP_PROXY} FTP_PROXY=$${FTP_PROXY} FTP_PASSIVE_MODE=$${FTP_PASSIVE_MODE:-no} PATH=$${PATH} \\" >> ${_MK}
  	echo "		make all install clean BATCH=yes FORCE_PKG_REGISTER=yes" >> ${_MK}
  	echo "	done"				>> ${_MK}
  	echo "	cd /usr/ports"			>> ${_MK}
 _______________________________________________
 svn-src-all@freebsd.org mailing list
 http://lists.freebsd.org/mailman/listinfo/svn-src-all
 To unsubscribe, send any mail to "svn-src-all-unsubscribe@freebsd.org"
 
State-Changed-From-To: patched->closed 
State-Changed-By: kensmith 
State-Changed-When: Wed May 5 16:41:28 UTC 2010 
State-Changed-Why:  

Merged to stable/8 (r207660) and stable/7 (r207661). 


http://www.freebsd.org/cgi/query-pr.cgi?pr=137688 

From: dfilter@FreeBSD.ORG (dfilter service)
To: bug-followup@FreeBSD.org
Cc:  
Subject: Re: misc/137688: commit references a PR
Date: Wed,  5 May 2010 16:41:29 +0000 (UTC)

 Author: kensmith
 Date: Wed May  5 16:41:14 2010
 New Revision: 207661
 URL: http://svn.freebsd.org/changeset/base/207661
 
 Log:
   Merge r206422:
   
   > Pass the HTTP_PROXY and FTP_PROXY environment variables through in addition
   > to FTP_PASSIVE_MODE so release building works for a machine that needs
   > to use a proxy.
   
   PR:           misc/137688
   Submitted by: Michael Leun
 
 Modified:
   stable/7/release/Makefile
 Directory Properties:
   stable/7/release/   (props changed)
   stable/7/release/doc/   (props changed)
   stable/7/release/doc/en_US.ISO8859-1/hardware/   (props changed)
 
 Modified: stable/7/release/Makefile
 ==============================================================================
 --- stable/7/release/Makefile	Wed May  5 16:25:57 2010	(r207660)
 +++ stable/7/release/Makefile	Wed May  5 16:41:14 2010	(r207661)
 @@ -576,7 +576,7 @@ release rerelease:
  	echo "	for i in ${MAKEINDEXPORTS}"	>> ${_MK}
  	echo "	do"			>> ${_MK}
  	echo "		cd /usr/ports/\$${i}"	>> ${_MK}
 -	echo "		env -i FTP_PASSIVE_MODE=$${FTP_PASSIVE_MODE:-no} PATH=$${PATH} \\" >> ${_MK}
 +	echo "		env -i HTTP_PROXY=$${HTTP_PROXY} FTP_PROXY=$${FTP_PROXY} FTP_PASSIVE_MODE=$${FTP_PASSIVE_MODE:-no} PATH=$${PATH} \\" >> ${_MK}
  	echo "		make all install clean BATCH=yes FORCE_PKG_REGISTER=yes" >> ${_MK}
  	echo "	done"				>> ${_MK}
  	echo "	cd /usr/ports"			>> ${_MK}
 _______________________________________________
 svn-src-all@freebsd.org mailing list
 http://lists.freebsd.org/mailman/listinfo/svn-src-all
 To unsubscribe, send any mail to "svn-src-all-unsubscribe@freebsd.org"
 
>Unformatted:
