From nick.hibma@jrc.it Sun Jun  6 04:15:11 1999
Return-Path: <nick.hibma@jrc.it>
Received: from mrelay.jrc.it (mrelay.jrc.it [139.191.1.65])
	by hub.freebsd.org (Postfix) with ESMTP id E4C5814F32
	for <freebsd-gnats-submit@freebsd.org>; Sun,  6 Jun 1999 04:15:10 -0700 (PDT)
	(envelope-from nick.hibma@jrc.it)
Received: from elpc36.jrc.it (elpc36.jrc.it [139.191.71.36])
	by mrelay.jrc.it (LMC5692) with ESMTP id NAA25144
	for <FreeBSD-gnats-submit@freebsd.org>; Sun, 6 Jun 1999 13:15:07 +0200 (MET DST)
Received: (from n_hibma@localhost)
	by elpc36.jrc.it (8.9.3/8.8.7) id NAA44376;
	Sun, 6 Jun 1999 13:13:45 +0200 (CEST)
	(envelope-from n_hibma)
Message-Id: <199906061113.NAA44376@elpc36.jrc.it>
Date: Sun, 6 Jun 1999 13:13:45 +0200 (CEST)
From: n_hibma@freebsd.org
Sender: nick.hibma@jrc.it
Reply-To: n_hibma@freebsd.org
To: FreeBSD-gnats-submit@freebsd.org
Subject: [PATCH] searching for closed reports requires two selections
X-Send-Pr-Version: 3.2

>Number:         12049
>Category:       misc
>Synopsis:       [PATCH] searching for closed reports requires two selections
>Confidential:   no
>Severity:       non-critical
>Priority:       low
>Responsible:    sheldonh
>State:          closed
>Quarter:        
>Keywords:       
>Date-Required:  
>Class:          change-request
>Submitter-Id:   current-users
>Arrival-Date:   Sun Jun  6 04:20:00 PDT 1999
>Closed-Date:    Tue Jul 20 07:27:31 PDT 1999
>Last-Modified:  Tue Jul 20 07:29:52 PDT 1999
>Originator:     Nick Hibma
>Release:        FreeBSD 4.0-CURRENT i386
>Organization:
>Environment:

	Current web pages at www.freebsd.org
	http://www.freebsd.org/cgi/query-pr-summary.cgi?query

>Description:

	You can select closed in the 'State:' field, but if you want to
	actually see the closed ones you have to select the button 'Closed
	reports too' at the bottom of the page. I suggest moving that button
	up to below the State: field.

	Maybe rename the button to 'Show closed reports too'.

	Other option is to include Closed reports automatically if someone
	asks for state 'Closed'.

	Both patches are included. Use the chunk you like.

>How-To-Repeat:

>Fix:

n_hibma@freefall:cgi% cvs diff query-pr-summary.cgi 
Index: query-pr-summary.cgi
===================================================================
RCS file: /home/ncvs/www/en/cgi/query-pr-summary.cgi,v
retrieving revision 1.22
diff -u -r1.22 query-pr-summary.cgi
--- query-pr-summary.cgi        1999/02/26 22:05:58     1.22
+++ query-pr-summary.cgi        1999/06/06 11:13:37
@@ -203,7 +203,8 @@
 #       [--list-categories] [--list-responsible] [--list-submitters]
 #       [--text=text] [--multitext=mtext] [PR] [PR]...
 
-$query_args .= " --skip-closed" unless $input{"closedtoo"};
+$query_args .= " --skip-closed"
+       unless $input{"closedtoo"} or $input{"state"} eq "closed";
 
 # Only read the appropriate PR's.
 foreach ("category", "originator", "priority", "class", "responsible",
@@ -509,7 +510,6 @@
 <OPTION VALUE="analyzed">Analyzed</OPTION>
 <OPTION VALUE="feedback">Feedback</OPTION>
 <OPTION VALUE="suspended">Suspended</OPTION>
-<OPTION VALUE="closed">Closed</OPTION>
 </SELECT></TD>
 <TD><B>Sort by</B>:</TD>
 <TD><SELECT NAME="sort">
@@ -519,6 +519,9 @@
 <OPTION VALUE="responsible">Responsible Party</OPTION>
 </SELECT></TD>
 </TR><TR>
+<TD><B>Closed reports too</B>:</TD>
+<TD><INPUT NAME="closedtoo" TYPE=CHECKBOX></TD>
+</TR><TR>
 <!-- We don't use submitter Submitter: -->
 <TD><B>Text in single-line fields</B>:</TD>
 <TD><INPUT TYPE=TEXT NAME="text"></TD>
@@ -529,9 +532,6 @@
 <TD><INPUT TYPE=TEXT NAME="multitext"></TD>
 <TD><B>Originator</B>:</TD>
 <TD><INPUT TYPE=TEXT NAME="originator"></TD>
-</TR><TR>
-<TD><B>Closed reports too</B>:</TD>
-<TD><INPUT NAME="closedtoo" TYPE=CHECKBOX></TD>
 </TR>
 </TABLE>
 <INPUT TYPE="SUBMIT" VALUE=" Query PR's ">


>Release-Note:
>Audit-Trail:

From: Bill Fumerola <billf@jade.chc-chimes.com>
To: n_hibma@FreeBSD.ORG
Cc: FreeBSD-gnats-submit@FreeBSD.ORG
Subject: Re: misc/12049: [PATCH] searching for closed reports requires two selections
Date: Mon, 7 Jun 1999 13:26:49 -0400 (EDT)

 On Sun, 6 Jun 1999 n_hibma@FreeBSD.ORG wrote:
 
 > 	Other option is to include Closed reports automatically if someone
 > 	asks for state 'Closed'.
 > 
 > 	Both patches are included. Use the chunk you like.
 
 I like this idea better.
 
 - bill fumerola - billf@chc-chimes.com - BF1560 - computer horizons corp -
 - ph:(800) 252-2421 - bfumerol@computerhorizons.com - billf@FreeBSD.org  -
 
 
 
 
State-Changed-From-To: open->analyzed 
State-Changed-By: n_hibma 
State-Changed-When: Thu Jun 24 11:20:40 PDT 1999 
State-Changed-Why:  
Sheldon has had a look at it and concluded that something would be done 
about it in due time. 


Responsible-Changed-From-To: freebsd-bugs->sheldonh 
Responsible-Changed-By: n_hibma 
Responsible-Changed-When: Thu Jun 24 11:20:40 PDT 1999 
Responsible-Changed-Why:  
Sheldon said he would do something about it. Honest! 

From: Nick Hibma <nick.hibma@jrc.it>
To: freebsd-gnats-submit@freebsd.org
Cc:  
Subject: Re: misc/12049: [PATCH] searching for closed reports requires two selections
Date: Tue, 20 Jul 1999 11:28:28 +0200 (MET DST)

 This bug report is identical, closed that one.
 
 Nick
 
 ---------- Forwarded message ----------
 Date: Tue, 20 Jul 1999 04:15:29 -0500 (CDT)
 From: chris@calldei.com
 To: FreeBSD-gnats-submit@FreeBSD.ORG
 Subject: misc/12716: [Patch] query-pr-summary.cgi excludes closed reports even if state='closed'
 
 
 >Number:         12716
 >Category:       misc
 >Synopsis:       [Patch] query-pr-summary.cgi excludes closed reports even if state='closed'
 >Confidential:   no
 >Severity:       serious
 >Priority:       medium
 >Responsible:    freebsd-bugs
 >State:          open
 >Quarter:        
 >Keywords:       
 >Date-Required:
 >Class:          sw-bug
 >Submitter-Id:   current-users
 >Arrival-Date:   Tue Jul 20 02:20:01 PDT 1999
 >Closed-Date:
 >Last-Modified:
 >Originator:     Chris Costello
 >Release:        FreeBSD 4.0-CURRENT i386
 >Organization:
 none
 >Environment:
 
 query-pr-summary.cgi:
      $Id: query-pr-summary.cgi,v 1.22 1999/02/26 22:05:58 billf Exp $
 
 >Description:
 
 When the state specified in a PR search is 'closed' but the 'Closed too'
 checkbox is not enabled, no results are turned up, even though there are
 closed reports that would turn up had 'Closed too' been enabled.
 
 >How-To-Repeat:
 
 This will show no PRs:
 http://www.freebsd.org/cgi/query-pr-summary.cgi?state=closed&sort=none&originator=Chris+Costello&closedtoo=
 
 This will show my closed PRs:
 http://www.freebsd.org/cgi/query-pr-summary.cgi?state=closed&sort=none&originator=Chris+Costello&closedtoo=on
 
 >Fix:
 This might be a little bit crude, but it definitely works.
 
 Index: query-pr-summary.cgi
 ===================================================================
 RCS file: /home/ncvs/www/en/cgi/query-pr-summary.cgi,v
 retrieving revision 1.22
 diff -u -r1.22 query-pr-summary.cgi
 --- query-pr-summary.cgi	1999/02/26 22:05:58	1.22
 +++ query-pr-summary.cgi	1999/07/20 09:10:41
 @@ -10,6 +10,7 @@
  $project       = "FreeBSD";
  $mail_prefix   = "freebsd-";
  $mail_unass    = "freebsd-bugs";
 +$closed_too    = 0;
  
  %statemap = (
  	"open",		"o",
 @@ -60,6 +61,8 @@
  	}
  }
  
 +$closed_too = 1 if $input{'state'} eq 'closed' || $input{'closedtoo'};
 +
  #------------------------------------------------------------------------
  
  %mons = ('Jan', '01',  'Feb', '02',  'Mar', '03',
 @@ -203,7 +206,7 @@
  #       [--list-categories] [--list-responsible] [--list-submitters]
  #       [--text=text] [--multitext=mtext] [PR] [PR]...
  
 -$query_args .= " --skip-closed" unless $input{"closedtoo"};
 +$query_args .= " --skip-closed" unless $closed_too;
  
  # Only read the appropriate PR's.
  foreach ("category", "originator", "priority", "class", "responsible",
 
 >Release-Note:
 >Audit-Trail:
 >Unformatted:
 
 
 To Unsubscribe: send mail to majordomo@FreeBSD.org
 with "unsubscribe freebsd-bugs" in the body of the message
 
 
 

From: Nick Hibma <nick.hibma@jrc.it>
To: sheldonh@elec.isei.jrc.it
Cc: chris@calldei.com, FreeBSD-gnats-submit@freebsd.org
Subject: Re: misc/12049: [PATCH] searching for closed reports requires two selections
Date: Tue, 20 Jul 1999 11:33:12 +0200 (MET DST)

 Maybe we should apply the patch given for the moment, until you have the
 time to revamp the PR section.
 
 Nick
 
 ---------- Forwarded message ----------
 Date: Tue, 20 Jul 1999 04:15:29 -0500 (CDT)
 From: chris@calldei.com
 To: FreeBSD-gnats-submit@FreeBSD.ORG
 Subject: misc/12716: [Patch] query-pr-summary.cgi excludes closed reports even if state='closed'
 
 
 >Number:         12716
 >Category:       misc
 >Synopsis:       [Patch] query-pr-summary.cgi excludes closed reports even if state='closed'
 ...
 
 Index: query-pr-summary.cgi
 ===================================================================
 RCS file: /home/ncvs/www/en/cgi/query-pr-summary.cgi,v
 retrieving revision 1.22
 diff -u -r1.22 query-pr-summary.cgi
 --- query-pr-summary.cgi	1999/02/26 22:05:58	1.22
 +++ query-pr-summary.cgi	1999/07/20 09:10:41
 @@ -10,6 +10,7 @@
  $project       = "FreeBSD";
  $mail_prefix   = "freebsd-";
  $mail_unass    = "freebsd-bugs";
 +$closed_too    = 0;
  
  %statemap = (
  	"open",		"o",
 @@ -60,6 +61,8 @@
  	}
  }
  
 +$closed_too = 1 if $input{'state'} eq 'closed' || $input{'closedtoo'};
 +
  #------------------------------------------------------------------------
  
  %mons = ('Jan', '01',  'Feb', '02',  'Mar', '03',
 @@ -203,7 +206,7 @@
  #       [--list-categories] [--list-responsible] [--list-submitters]
  #       [--text=text] [--multitext=mtext] [PR] [PR]...
  
 -$query_args .= " --skip-closed" unless $input{"closedtoo"};
 +$query_args .= " --skip-closed" unless $closed_too;
  
  # Only read the appropriate PR's.
  foreach ("category", "originator", "priority", "class", "responsible",
 
 
 
 
State-Changed-From-To: analyzed->closed 
State-Changed-By: sheldonh 
State-Changed-When: Tue Jul 20 07:27:31 PDT 1999 
State-Changed-Why:  
Committed on pain of torture. :-) 
>Unformatted:
