From nobody@FreeBSD.org  Tue Dec 11 18:19:58 2007
Return-Path: <nobody@FreeBSD.org>
Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2001:4f8:fff6::34])
	by hub.freebsd.org (Postfix) with ESMTP id ACDCF16A41B
	for <freebsd-gnats-submit@FreeBSD.org>; Tue, 11 Dec 2007 18:19:58 +0000 (UTC)
	(envelope-from nobody@FreeBSD.org)
Received: from www.freebsd.org (www.freebsd.org [IPv6:2001:4f8:fff6::21])
	by mx1.freebsd.org (Postfix) with ESMTP id AE60713C467
	for <freebsd-gnats-submit@FreeBSD.org>; Tue, 11 Dec 2007 18:19:58 +0000 (UTC)
	(envelope-from nobody@FreeBSD.org)
Received: from www.freebsd.org (localhost [127.0.0.1])
	by www.freebsd.org (8.14.2/8.14.2) with ESMTP id lBBIJsT3019842
	for <freebsd-gnats-submit@FreeBSD.org>; Tue, 11 Dec 2007 18:19:54 GMT
	(envelope-from nobody@www.freebsd.org)
Received: (from nobody@localhost)
	by www.freebsd.org (8.14.2/8.14.1/Submit) id lBBIJslc019841;
	Tue, 11 Dec 2007 18:19:54 GMT
	(envelope-from nobody)
Message-Id: <200712111819.lBBIJslc019841@www.freebsd.org>
Date: Tue, 11 Dec 2007 18:19:54 GMT
From: Sergey Matveychuk <sem@FreeBSD.org>
To: freebsd-gnats-submit@FreeBSD.org
Subject: [patch] iostat -x: a type like bug in output header
X-Send-Pr-Version: www-3.1
X-GNATS-Notify:

>Number:         118555
>Category:       misc
>Synopsis:       [patch] iostat -x: a type like bug in output header
>Confidential:   no
>Severity:       non-critical
>Priority:       low
>Responsible:    freebsd-bugs
>State:          closed
>Quarter:        
>Keywords:       
>Date-Required:  
>Class:          sw-bug
>Submitter-Id:   current-users
>Arrival-Date:   Tue Dec 11 18:20:03 UTC 2007
>Closed-Date:    Tue Dec 11 18:55:22 UTC 2007
>Last-Modified:  Tue Dec 11 18:55:22 UTC 2007
>Originator:     Sergey Matveychuk
>Release:        all
>Organization:
Yandex LLC
>Environment:
>Description:
ioctl -x shows a header that is not compliant with a man page:

                        extended device statistics
device     r/s   w/s    kr/s    kw/s wait svc_t  b

The last field should be %b.

I hope it's a type and our developers know how handle with printf(3)
>How-To-Repeat:
run ioctl -x
>Fix:


Patch attached with submission follows:

--- sys/netinet/ip_fw2.c.orig	Thu Aug 23 13:19:37 2007
+++ sys/netinet/ip_fw2.c	Thu Aug 23 14:12:49 2007
@@ -1591,7 +1591,8 @@
 						inet_ntoa_r(da, dst);
 					}
 					log(LOG_SECURITY | LOG_DEBUG,
-					    "%s %s:%u -> %s:%u, %s\n",
+					    "ipfw: %d %s %s:%u -> %s:%u, %s\n",
+					    parent->rule->rulenum,
 					    "drop session",
 					    src, (args->f_id.src_port),
 					    dst, (args->f_id.dst_port),


>Release-Note:
>Audit-Trail:
State-Changed-From-To: open->closed 
State-Changed-By: sem 
State-Changed-When: Tue Dec 11 18:55:21 UTC 2007 
State-Changed-Why:  
Closed. A wrong patch. 

http://www.freebsd.org/cgi/query-pr.cgi?pr=118555 
>Unformatted:
