From nobody@FreeBSD.org  Sat Jul  1 08:28:42 2006
Return-Path: <nobody@FreeBSD.org>
Received: from mx1.FreeBSD.org (mx1.freebsd.org [216.136.204.125])
	by hub.freebsd.org (Postfix) with ESMTP id CC26C16A403
	for <freebsd-gnats-submit@FreeBSD.org>; Sat,  1 Jul 2006 08:28:42 +0000 (UTC)
	(envelope-from nobody@FreeBSD.org)
Received: from www.freebsd.org (www.freebsd.org [216.136.204.117])
	by mx1.FreeBSD.org (Postfix) with ESMTP id 7C0CA43D48
	for <freebsd-gnats-submit@FreeBSD.org>; Sat,  1 Jul 2006 08:28:42 +0000 (GMT)
	(envelope-from nobody@FreeBSD.org)
Received: from www.freebsd.org (localhost [127.0.0.1])
	by www.freebsd.org (8.13.1/8.13.1) with ESMTP id k618SgMd090744
	for <freebsd-gnats-submit@FreeBSD.org>; Sat, 1 Jul 2006 08:28:42 GMT
	(envelope-from nobody@www.freebsd.org)
Received: (from nobody@localhost)
	by www.freebsd.org (8.13.1/8.13.1/Submit) id k618SgS9090743;
	Sat, 1 Jul 2006 08:28:42 GMT
	(envelope-from nobody)
Message-Id: <200607010828.k618SgS9090743@www.freebsd.org>
Date: Sat, 1 Jul 2006 08:28:42 GMT
From: KIYOHARA Takashi <kiyohara@netbsd.org>
To: freebsd-gnats-submit@FreeBSD.org
Subject: The strange expression in if_ural.c::ural_set_chan()
X-Send-Pr-Version: www-2.3

>Number:         99676
>Category:       kern
>Synopsis:       [ural] [patch] strange expression in if_ural.c::ural_set_chan()
>Confidential:   no
>Severity:       serious
>Priority:       high
>Responsible:    freebsd-bugs
>State:          closed
>Quarter:        
>Keywords:       
>Date-Required:  
>Class:          sw-bug
>Submitter-Id:   current-users
>Arrival-Date:   Sat Jul 01 08:30:18 GMT 2006
>Closed-Date:    Sat Jul 08 07:49:47 GMT 2006
>Last-Modified:  Sat Jul 08 07:49:47 GMT 2006
>Originator:     KIYOHARA Takashi
>Release:        -current
>Organization:
>Environment:
>Description:
I look and think strange expression in if_ural.c::ural_set_chan().  I guess the "i<..." is an accident.

if_ural.c::ural_set_chan() ---

	/* dual-band RF */
	case RAL_RF_5222:
		for (i = 0; i < ural_rf5222[i].chan != chan; i++);
                           ^^^^^
		ural_rf_write(sc, RAL_RF1, ural_rf5222[i].r1);

--- if_ural.c::ural_set_chan()
>How-To-Repeat:

>Fix:

	/* dual-band RF */
	case RAL_RF_5222:
-		for (i = 0; i < ural_rf5222[i].chan != chan; i++);
+		for (i = 0; ural_rf5222[i].chan != chan; i++);

		ural_rf_write(sc, RAL_RF1, ural_rf5222[i].r1);

>Release-Note:
>Audit-Trail:
State-Changed-From-To: open->patched 
State-Changed-By: maxim 
State-Changed-When: Sat Jul 1 13:39:29 UTC 2006 
State-Changed-Why:  
Fixed in HEAD.  Thanks! 

http://www.freebsd.org/cgi/query-pr.cgi?pr=99676 
State-Changed-From-To: patched->closed 
State-Changed-By: maxim 
State-Changed-When: Sat Jul 8 07:49:30 UTC 2006 
State-Changed-Why:  
Merged to RELENG_6. 

http://www.freebsd.org/cgi/query-pr.cgi?pr=99676 
>Unformatted:
