From nobody@FreeBSD.org  Mon Jun  5 14:07:39 2006
Return-Path: <nobody@FreeBSD.org>
Received: from mx1.FreeBSD.org (mx1.freebsd.org [216.136.204.125])
	by hub.freebsd.org (Postfix) with ESMTP id D144316B164
	for <freebsd-gnats-submit@FreeBSD.org>; Mon,  5 Jun 2006 14:07:39 +0000 (UTC)
	(envelope-from nobody@FreeBSD.org)
Received: from www.freebsd.org (www.freebsd.org [216.136.204.117])
	by mx1.FreeBSD.org (Postfix) with ESMTP id 0156A43D72
	for <freebsd-gnats-submit@FreeBSD.org>; Mon,  5 Jun 2006 14:07:33 +0000 (GMT)
	(envelope-from nobody@FreeBSD.org)
Received: from www.freebsd.org (localhost [127.0.0.1])
	by www.freebsd.org (8.13.1/8.13.1) with ESMTP id k55E7Q8C061560
	for <freebsd-gnats-submit@FreeBSD.org>; Mon, 5 Jun 2006 14:07:26 GMT
	(envelope-from nobody@www.freebsd.org)
Received: (from nobody@localhost)
	by www.freebsd.org (8.13.1/8.13.1/Submit) id k55E7Qlk061559;
	Mon, 5 Jun 2006 14:07:26 GMT
	(envelope-from nobody)
Message-Id: <200606051407.k55E7Qlk061559@www.freebsd.org>
Date: Mon, 5 Jun 2006 14:07:26 GMT
From: Michael Heyman <Michael.Heyman@sparta.com>
To: freebsd-gnats-submit@FreeBSD.org
Subject: [netgraph] False "ng_generic_msg: number of nodes changed" report
X-Send-Pr-Version: www-2.3

>Number:         98529
>Category:       kern
>Synopsis:       [netgraph] False "ng_generic_msg: number of nodes changed" report
>Confidential:   no
>Severity:       non-critical
>Priority:       low
>Responsible:    glebius
>State:          closed
>Quarter:        
>Keywords:       
>Date-Required:  
>Class:          sw-bug
>Submitter-Id:   current-users
>Arrival-Date:   Mon Jun 05 14:10:20 GMT 2006
>Closed-Date:    Thu Aug 10 10:26:56 GMT 2006
>Last-Modified:  Thu Aug 10 10:26:56 GMT 2006
>Originator:     Michael Heyman
>Release:        FreeBSD 7-CURRENT
>Organization:
>Environment:
>Description:
In ng_base.c around line 2658 there can be a false error report saying "ng_generic_msg: number of nodes changed". This report occurs when the response message fills up.

The false report occurs when the response message is full and would not receive any more information even though there are still nodes in ng_nodelist to scan.

>How-To-Repeat:

>Fix:
Moving the check down 4 lines to below the "if(NG_NODE_NOT_VALID(node))" and "if(!unamed && (!NG_NODE_HAS_NAME(node)))" conditionals will remove the false error report.


>Release-Note:
>Audit-Trail:
State-Changed-From-To: open->patched 
State-Changed-By: glebius 
State-Changed-When: Wed Jun 7 12:44:14 UTC 2006 
State-Changed-Why:  
Committed, thanks! 


Responsible-Changed-From-To: freebsd-bugs->glebius 
Responsible-Changed-By: glebius 
Responsible-Changed-When: Wed Jun 7 12:44:14 UTC 2006 
Responsible-Changed-Why:  
I'm handling this. 

http://www.freebsd.org/cgi/query-pr.cgi?pr=98529 
State-Changed-From-To: patched->closed 
State-Changed-By: glebius 
State-Changed-When: Thu Aug 10 10:25:59 UTC 2006 
State-Changed-Why:  
Merged to RELENG_6. 

http://www.freebsd.org/cgi/query-pr.cgi?pr=98529 
>Unformatted:
