From nobody@FreeBSD.org  Wed May  3 21:11:03 2006
Return-Path: <nobody@FreeBSD.org>
Received: from mx1.FreeBSD.org (mx1.freebsd.org [216.136.204.125])
	by hub.freebsd.org (Postfix) with ESMTP id 2481B16A410
	for <freebsd-gnats-submit@FreeBSD.org>; Wed,  3 May 2006 21:11:03 +0000 (UTC)
	(envelope-from nobody@FreeBSD.org)
Received: from www.freebsd.org (www.freebsd.org [216.136.204.117])
	by mx1.FreeBSD.org (Postfix) with ESMTP id EEEAA43D5D
	for <freebsd-gnats-submit@FreeBSD.org>; Wed,  3 May 2006 21:11:01 +0000 (GMT)
	(envelope-from nobody@FreeBSD.org)
Received: from www.freebsd.org (localhost [127.0.0.1])
	by www.freebsd.org (8.13.1/8.13.1) with ESMTP id k43LB1X8099578
	for <freebsd-gnats-submit@FreeBSD.org>; Wed, 3 May 2006 21:11:01 GMT
	(envelope-from nobody@www.freebsd.org)
Received: (from nobody@localhost)
	by www.freebsd.org (8.13.1/8.13.1/Submit) id k43LB1j7099574;
	Wed, 3 May 2006 21:11:01 GMT
	(envelope-from nobody)
Message-Id: <200605032111.k43LB1j7099574@www.freebsd.org>
Date: Wed, 3 May 2006 21:11:01 GMT
From: Sven Petai <hadara@bsd.ee>
To: freebsd-gnats-submit@FreeBSD.org
Subject: pci id's for supporting realtek 8168
X-Send-Pr-Version: www-2.3

>Number:         96734
>Category:       kern
>Synopsis:       [re] [patch] pci id's for supporting realtek 8168
>Confidential:   no
>Severity:       non-critical
>Priority:       medium
>Responsible:    freebsd-bugs
>State:          closed
>Quarter:        
>Keywords:       
>Date-Required:  
>Class:          change-request
>Submitter-Id:   current-users
>Arrival-Date:   Wed May 03 21:20:20 GMT 2006
>Closed-Date:    Fri May 12 19:15:52 GMT 2006
>Last-Modified:  Fri May 12 19:15:52 GMT 2006
>Originator:     Sven Petai
>Release:        6.1 RC
>Organization:
>Environment:
FreeBSD  6.1-RC FreeBSD 6.1-RC #11: Tue May  2 19:39:33 EEST 2006     hadara@:/usr/obj/usr/src/sys/DEPRESSION64  amd64
>Description:
Realtek seems to have a new gigabit ethernet chip for PCI-E called 8168B, 
as far as I can tell it's otherwise equivalent to 8169 so
adding new pci id's to the re driver is sufficient for supporting it.

Works fine for me at least.
>How-To-Repeat:

>Fix:
diff -ruN sys_old/dev/re/if_re.c sys/dev/re/if_re.c
--- sys_old/dev/re/if_re.c      Fri Mar 17 23:30:55 2006
+++ sys/dev/re/if_re.c  Wed May  3 23:56:40 2006
@@ -167,6 +167,8 @@
                "D-Link DGE-528(T) Gigabit Ethernet Adapter" },
        { RT_VENDORID, RT_DEVICEID_8139, RL_HWREV_8139CPLUS,
                "RealTek 8139C+ 10/100BaseTX" },
+        { RT_VENDORID, RT_DEVICEID_8168, RL_HWREV_8168B,
+                "RealTek 8168B PCI-E Gigabit Ethernet Adapter" },
        { RT_VENDORID, RT_DEVICEID_8169, RL_HWREV_8169,
                "RealTek 8169 Gigabit Ethernet" },
        { RT_VENDORID, RT_DEVICEID_8169, RL_HWREV_8169S,
@@ -191,6 +193,7 @@
        { RL_HWREV_8139C, RL_8139, "C" },
        { RL_HWREV_8139D, RL_8139, "8139D/8100B/8100C" },
        { RL_HWREV_8139CPLUS, RL_8139CPLUS, "C+"},
+       { RL_HWREV_8168B, RL_8169, "8168B"}, /* it seems to be identical to 8169 */
        { RL_HWREV_8169, RL_8169, "8169"},
        { RL_HWREV_8169S, RL_8169, "8169S"},
        { RL_HWREV_8169SB, RL_8169, "8169SB"},
diff -ruN sys_old/pci/if_rlreg.h sys/pci/if_rlreg.h
--- sys_old/pci/if_rlreg.h      Sun Nov  6 18:00:54 2005
+++ sys/pci/if_rlreg.h  Wed May  3 23:57:05 2006
@@ -145,6 +145,7 @@
 #define RL_LOOPTEST_ON         0x00020000
 #define RL_LOOPTEST_ON_CPLUS   0x00060000

+#define RL_HWREV_8168B         0x30000000
 #define RL_HWREV_8169          0x00000000
 #define RL_HWREV_8169S         0x04000000
 #define RL_HWREV_8169SB                0x10000000
@@ -744,6 +745,7 @@
 #define        RT_DEVICEID_8129                        0x8129
 #define        RT_DEVICEID_8138                        0x8138
 #define        RT_DEVICEID_8139                        0x8139
+#define RT_DEVICEID_8168                       0x8168
 #define RT_DEVICEID_8169                       0x8169
 #define RT_DEVICEID_8100                       0x8100

>Release-Note:
>Audit-Trail:

From: Sven Petai <hadara@bsd.ee>
To: bug-followup@freebsd.org,
 hadara@bsd.ee
Cc:  
Subject: Re: kern/96734: [re] [patch] pci id's for supporting realtek 8168
Date: Fri, 12 May 2006 09:35:48 +0300

 hi
 
 this can be closed, I didn't notice that support was already commited to the 
 current couple of weeks ago as  RLT8111 which seems to be alias for 8168.
State-Changed-From-To: open->closed 
State-Changed-By: linimon 
State-Changed-When: Fri May 12 19:15:35 UTC 2006 
State-Changed-Why:  
Support has already been committed.  Thanks for the report. 

http://www.freebsd.org/cgi/query-pr.cgi?pr=96734 
>Unformatted:
