From simon@comsys.ntu-kpi.kiev.ua  Tue Apr 18 08:33:29 2006
Return-Path: <simon@comsys.ntu-kpi.kiev.ua>
Received: from mx1.FreeBSD.org (mx1.freebsd.org [216.136.204.125])
	by hub.freebsd.org (Postfix) with ESMTP id CFEAA16A40A
	for <FreeBSD-gnats-submit@freebsd.org>; Tue, 18 Apr 2006 08:33:29 +0000 (UTC)
	(envelope-from simon@comsys.ntu-kpi.kiev.ua)
Received: from comsys.ntu-kpi.kiev.ua (comsys.ntu-kpi.kiev.ua [195.245.194.142])
	by mx1.FreeBSD.org (Postfix) with ESMTP id 0029D43D68
	for <FreeBSD-gnats-submit@freebsd.org>; Tue, 18 Apr 2006 08:33:18 +0000 (GMT)
	(envelope-from simon@comsys.ntu-kpi.kiev.ua)
Received: from pm513-1.comsys.ntu-kpi.kiev.ua (pm513-1.comsys.ntu-kpi.kiev.ua [10.18.52.101])
	(authenticated bits=0)
	by comsys.ntu-kpi.kiev.ua (8.13.6/8.13.6) with ESMTP id k3I6U9Dd001500
	(version=TLSv1/SSLv3 cipher=DHE-RSA-AES256-SHA bits=256 verify=FAIL)
	for <FreeBSD-gnats-submit@freebsd.org>; Tue, 18 Apr 2006 09:30:09 +0300 (EEST)
Received: by pm513-1.comsys.ntu-kpi.kiev.ua (Postfix, from userid 1001)
	id A7C435C023; Tue, 18 Apr 2006 09:16:07 +0300 (EEST)
Message-Id: <20060418061607.GA761@pm513-1.comsys.ntu-kpi.kiev.ua>
Date: Tue, 18 Apr 2006 09:16:07 +0300
From: Andrey Simonenko <simon@comsys.ntu-kpi.kiev.ua>
To: FreeBSD-gnats-submit@freebsd.org
Subject: [patch] nfsproto.h has trailing ',' in enums

>Number:         95987
>Category:       kern
>Synopsis:       [patch] nfsproto.h has trailing ',' in enums
>Confidential:   no
>Severity:       non-critical
>Priority:       low
>Responsible:    rees
>State:          closed
>Quarter:        
>Keywords:       
>Date-Required:  
>Class:          sw-bug
>Submitter-Id:   current-users
>Arrival-Date:   Tue Apr 18 08:40:13 GMT 2006
>Closed-Date:    Tue Apr 18 15:46:31 EDT 2006
>Last-Modified:  Tue Apr 18 15:46:31 EDT 2006
>Originator:     Andrey Simonenko
>Release:        FreeBSD 6.1-RC i386
>Organization:
>Environment:
>Description:

nfsproto.h has trailing ',' in enums.

>How-To-Repeat:
>Fix:
--- nfsproto.h.orig	Thu Nov  3 08:09:28 2005
+++ nfsproto.h	Mon Apr 17 23:19:52 2006
@@ -339,7 +339,7 @@
 	NFFIFO=7,
 	NFATTRDIR = 8,
 	NFNAMEDATTR = 9,
-	NFBAD = 10,
+	NFBAD = 10
 } nfstype;	
 
 /* NFSv4 claim type */
@@ -347,14 +347,14 @@
 	NCLNULL = 0,
 	NCLPREV = 1,
 	NCLDELEGCUR = 2,
-	NCLDELEGPREV = 3,
+	NCLDELEGPREV = 3
 } nfsv4cltype;
 
 /* Other NFSv4 types */
 typedef enum {
 	NSHUNSTABLE = 0,
 	NSHDATASYNC = 1,
-	NSHFILESYNC = 2,
+	NSHFILESYNC = 2
 } nfsv4stablehow;
 
 typedef enum { OTNOCREATE = 0, OTCREATE = 1 } nfsv4opentype;


>Release-Note:
>Audit-Trail:
State-Changed-From-To: open->closed 
State-Changed-By: rees 
State-Changed-When: Tue Apr 18 15:41:22 EDT 2006 
State-Changed-Why:  
This is explicitly allowed by ANSI C "Enumeration specifiers" which 
says that an enumerator-list may be followed by a comma. Not a bug. 


Responsible-Changed-From-To: freebsd-bugs->rees 
Responsible-Changed-By: rees 
Responsible-Changed-When: Tue Apr 18 15:41:22 EDT 2006 
Responsible-Changed-Why:  
This is explicitly allowed by ANSI C "Enumeration specifiers" which 
says that an enumerator-list may be followed by a comma. Not a bug. 

http://www.freebsd.org/cgi/query-pr.cgi?pr=95987 
>Unformatted:
