From bryanv@daemoninthecloset.org  Thu Apr  6 04:52:55 2006
Return-Path: <bryanv@daemoninthecloset.org>
Received: from mx1.FreeBSD.org (mx1.freebsd.org [216.136.204.125])
	by hub.freebsd.org (Postfix) with ESMTP id C1CC316A420
	for <FreeBSD-gnats-submit@freebsd.org>; Thu,  6 Apr 2006 04:52:55 +0000 (UTC)
	(envelope-from bryanv@daemoninthecloset.org)
Received: from sccmmhc92.asp.att.net (sccmmhc92.asp.att.net [204.127.203.212])
	by mx1.FreeBSD.org (Postfix) with ESMTP id EFB2F43D45
	for <FreeBSD-gnats-submit@freebsd.org>; Thu,  6 Apr 2006 04:52:54 +0000 (GMT)
	(envelope-from bryanv@daemoninthecloset.org)
Received: from torment.daemoninthecloset.org ([12.219.231.23])
          by sccmmhc92.asp.att.net (sccmmhc92) with ESMTP
          id <20060406045253m92001a8k6e>; Thu, 6 Apr 2006 04:52:53 +0000
Received: from misery.daemoninthecloset.org (daemongateway1.student.iastate.edu [64.113.65.231])
	(using TLSv1 with cipher DHE-RSA-AES256-SHA (256/256 bits))
	(Client CN "misery.daemoninthecloset.org", Issuer "CA Cert Signing Authority" (verified OK))
	by torment.daemoninthecloset.org (Postfix) with ESMTP id 3AFBE70
	for <FreeBSD-gnats-submit@freebsd.org>; Wed,  5 Apr 2006 23:56:14 -0500 (CDT)
Received: from localhost (misery.daemoninthecloset.org [192.168.1.25])
	by misery.daemoninthecloset.org (Postfix) with ESMTP id 5ECDD566D3
	for <FreeBSD-gnats-submit@freebsd.org>; Wed,  5 Apr 2006 23:52:48 -0500 (CDT)
Received: from misery.daemoninthecloset.org ([192.168.1.25])
 by localhost (misery.daemoninthecloset.org [192.168.1.25]) (amavisd-new, port 10024)
 with ESMTP id 06961-09 for <FreeBSD-gnats-submit@freebsd.org>;
 Wed,  5 Apr 2006 23:52:47 -0500 (CDT)
Received: from agonize.daemoninthecloset.org (agonize.daemoninthecloset.org [192.168.1.30])
	by misery.daemoninthecloset.org (Postfix) with ESMTP id 61F8C5645A
	for <FreeBSD-gnats-submit@freebsd.org>; Wed,  5 Apr 2006 23:52:47 -0500 (CDT)
Message-Id: <1144299167.27963@agonize.daemoninthecloset.org>
Date: Wed, 5 Apr 2006 23:52:47 -0500
From: "Bryan Venteicher" <bryanv@daemoninthecloset.org>
To: "FreeBSD gnats submit" <FreeBSD-gnats-submit@freebsd.org>
Subject: [patch] minor if_bfe error
X-Send-Pr-Version: gtk-send-pr 0.4.7 
X-GNATS-Notify:

>Number:         95391
>Category:       kern
>Synopsis:       [bfe] [patch] minor if_bfe error
>Confidential:   no
>Severity:       non-critical
>Priority:       low
>Responsible:    freebsd-bugs
>State:          closed
>Quarter:        
>Keywords:       
>Date-Required:  
>Class:          sw-bug
>Submitter-Id:   current-users
>Arrival-Date:   Thu Apr 06 05:00:32 GMT 2006
>Closed-Date:    Mon May 14 14:20:40 GMT 2007
>Last-Modified:  Mon May 14 14:20:40 GMT 2007
>Originator:     Bryan Venteicher
>Release:        FreeBSD 6.1-PRERELEASE i386
>Organization:
>Environment:


System: FreeBSD 6.1-PRERELEASE #1: Thu Mar 16 21:35:38 CST 2006
    bryanv@agonize.daemoninthecloset.org:/home/bryanv/obj/usr/src/sys/AGONIZE



>Description:


In the first call to bus_dma_tag_create() in bfe_dma_alloc() in if_bfe.c seems to have the lowaddr and highaddr parameters switched. I'm not very familiar with the DMA stuff but every other ethernet driver seems the parameters in the other order.

From how the constants are defined, it seems this would potentially only effect a very small number of users.



>How-To-Repeat:





>Fix:


--- if_bfe.c.diff begins here ---
--- if_bfe.c.orig	Wed Apr  5 23:45:35 2006
+++ if_bfe.c	Wed Apr  5 23:46:09 2006
@@ -200,8 +200,8 @@
 	/* parent tag */
 	error = bus_dma_tag_create(NULL,  /* parent */
 			PAGE_SIZE, 0,             /* alignment, boundary */
-			BUS_SPACE_MAXADDR,        /* lowaddr */
-			BUS_SPACE_MAXADDR_32BIT,  /* highaddr */
+			BUS_SPACE_MAXADDR_32BIT,  /* lowaddr */
+			BUS_SPACE_MAXADDR,        /* highaddr */
 			NULL, NULL,               /* filter, filterarg */
 			MAXBSIZE,                 /* maxsize */
 			BUS_SPACE_UNRESTRICTED,   /* num of segments */
--- if_bfe.c.diff ends here ---



>Release-Note:
>Audit-Trail:

From: Gavin Atkinson <gavin.atkinson@ury.york.ac.uk>
To: bug-followup@FreeBSD.org, bryanv@daemoninthecloset.org
Cc:  
Subject: Re: kern/95391: [bfe] [patch] minor if_bfe error
Date: Wed, 09 May 2007 15:05:17 +0100

 Hi,
 
 It looks like similar changes to yours were made in version 1.33 and
 1.36, and MFC'd to RELENG_6 in version 1.25.2.5 shortly before FreeBSD
 6.1 was released.
 
 Can you please confirm that this is no longer a problem?
 
 Thanks,
 
 Gavin
State-Changed-From-To: open->feedback 
State-Changed-By: linimon 
State-Changed-When: Sun May 13 04:33:37 UTC 2007 
State-Changed-Why:  
Note that submitter has been asked for feedback. 

http://www.freebsd.org/cgi/query-pr.cgi?pr=95391 

From: Gavin Atkinson <gavin.atkinson@ury.york.ac.uk>
To: bug-followup@freebsd.org
Cc:  
Subject: [Fwd: Re: kern/95391: [bfe] [patch] minor if_bfe error]
Date: Mon, 14 May 2007 09:59:12 +0100

 Reply from submitter:
 
 -------- Forwarded Message --------
 From: Bryan Venteicher <bryanv@daemoninthecloset.org>
 Date: Fri, 11 May 2007 00:07:52 -0500
 
 Weh, its been awhile since I submitted that pr. I never had the hardware
 - I was porting a network driver to FreeBSD and noticed the bug by
 inspection. I believe there was a lengthy discussion on a mailing list
 at the time of those commits and it fixed it for the ones who were
 having issues.
 
State-Changed-From-To: feedback->closed 
State-Changed-By: linimon 
State-Changed-When: Mon May 14 14:20:04 UTC 2007 
State-Changed-Why:  
Followup seems to indicate that a similar commit fixed the problems 
that were seen on the mailing lists. 

http://www.freebsd.org/cgi/query-pr.cgi?pr=95391 
>Unformatted:
