From serg@tmn.ru  Wed Apr  5 09:54:09 2006
Return-Path: <serg@tmn.ru>
Received: from mx1.FreeBSD.org (mx1.freebsd.org [216.136.204.125])
	by hub.freebsd.org (Postfix) with ESMTP id A0A9C16A400
	for <FreeBSD-gnats-submit@freebsd.org>; Wed,  5 Apr 2006 09:54:09 +0000 (UTC)
	(envelope-from serg@tmn.ru)
Received: from sbtx.tmn.ru (sbtx.tmn.ru [212.76.160.49])
	by mx1.FreeBSD.org (Postfix) with ESMTP id 70B8343D45
	for <FreeBSD-gnats-submit@freebsd.org>; Wed,  5 Apr 2006 09:54:07 +0000 (GMT)
	(envelope-from serg@tmn.ru)
Received: from sv.tech.sibitex.tmn.ru (sv.tech.sibitex.tmn.ru [10.76.160.59])
	by sbtx.tmn.ru (8.13.3/8.13.3) with ESMTP id k359rvqv052551
	for <FreeBSD-gnats-submit@freebsd.org>; Wed, 5 Apr 2006 15:53:58 +0600 (YEKST)
	(envelope-from serg@tmn.ru)
Received: from sv.tech.sibitex.tmn.ru (localhost.tech.sibitex.tmn.ru [127.0.0.1])
	by sv.tech.sibitex.tmn.ru (8.13.6/8.13.6) with ESMTP id k359rvru003209
	for <FreeBSD-gnats-submit@freebsd.org>; Wed, 5 Apr 2006 15:53:57 +0600 (YEKST)
	(envelope-from serg@sv.tech.sibitex.tmn.ru)
Received: (from serg@localhost)
	by sv.tech.sibitex.tmn.ru (8.13.6/8.13.6/Submit) id k359rvAN003208;
	Wed, 5 Apr 2006 15:53:57 +0600 (YEKST)
	(envelope-from serg)
Message-Id: <200604050953.k359rvAN003208@sv.tech.sibitex.tmn.ru>
Date: Wed, 5 Apr 2006 15:53:57 +0600 (YEKST)
From: "Sergey N. Voronkov" <serg@tmn.ru>
Reply-To: "Sergey N. Voronkov" <serg@tmn.ru>
To: FreeBSD-gnats-submit@freebsd.org
Cc:
Subject: Unabe to run smartd after last commits to sys/dev/ata.
X-Send-Pr-Version: 3.113
X-GNATS-Notify:

>Number:         95342
>Category:       kern
>Synopsis:       [ata] Unable to run smartd after last commits to sys/dev/ata (regression)
>Confidential:   no
>Severity:       serious
>Priority:       medium
>Responsible:    sos
>State:          closed
>Quarter:        
>Keywords:       
>Date-Required:  
>Class:          sw-bug
>Submitter-Id:   current-users
>Arrival-Date:   Wed Apr 05 10:00:36 GMT 2006
>Closed-Date:    Mon Sep 18 19:10:17 GMT 2006
>Last-Modified:  Mon Sep 18 19:10:17 GMT 2006
>Originator:     Sergey N. Voronkov
>Release:        FreeBSD 6.1-PRERELEASE i386
>Organization:
Sibitex Ltd.
>Environment:
System: FreeBSD sv.tech.sibitex.tmn.ru 6.1-PRERELEASE FreeBSD 6.1-PRERELEASE #3: Wed Apr 5 15:05:22 YEKST 2006 serg@sv.tech.sibitex.tmn.ru:/usr/obj/usr/src/sys/SV i386

>Description:
There is a strange problem on todays stable:
Apr  5 15:38:29 sv smartd[802]: Unable to register ATA device /dev/ad4 at line 88 of file /usr/local/etc/smartd.conf
Apr  5 15:38:29 sv smartd[802]: Unable to register device /dev/ad4 (no Directive -d removable). Exiting.

The system was running smartd without any problem before this MFC:

sos         2006-04-04 16:07:42 UTC

  FreeBSD src repository

  Modified files:        (Branch: RELENG_6)
    sys/sys              ata.h 
    sys/dev/ata          ata-all.c ata-all.h ata-disk.c 
                         ata-queue.c atapi-cam.c atapi-cd.c 
                         atapi-fd.c 
  Log:
  MFC:
          Make the ATAPI sense data accessible when using the ioctl interface
  Approved by: re@ (scottl)
  
  Revision   Changes    Path
  1.252.2.9  +6 -2      src/sys/dev/ata/ata-all.c
  1.103.2.8  +5 -44     src/sys/dev/ata/ata-all.h
  1.189.2.4  +10 -3     src/sys/dev/ata/ata-disk.c
  1.50.2.5   +33 -30    src/sys/dev/ata/ata-queue.c
  1.42.2.1   +3 -3      src/sys/dev/ata/atapi-cam.c
  1.179.2.6  +8 -8      src/sys/dev/ata/atapi-cd.c
  1.102.2.4  +1 -1      src/sys/dev/ata/atapi-fd.c
  1.26.2.5   +43 -0     src/sys/sys/ata.h


>How-To-Repeat:

Just try to run smartd onto new RELENG_6.

>Fix:

Recompilation of sysutils/smartmontools helps.

Possible fixes:

1) Backout introduced sysctl incompatibilities.
2) Document this feature in UPDATING

I'l prefer 2'd...
>Release-Note:
>Audit-Trail:
Responsible-Changed-From-To: freebsd-bugs->sos 
Responsible-Changed-By: linimon 
Responsible-Changed-When: Wed Apr 5 14:28:13 UTC 2006 
Responsible-Changed-Why:  
Over to committer of that change. 

http://www.freebsd.org/cgi/query-pr.cgi?pr=95342 

From: Adrian Steinmann <ast@marabu.ch>
To: bug-followup@FreeBSD.org, serg@tmn.ru
Cc:  
Subject: Re: kern/95342: [ata] Unable to run smartd after last commits to sys/dev/ata (regression)
Date: Sun, 23 Apr 2006 16:21:48 +0200

 I've run into this as well. Port recompile worked 2 out of 3 times,
 
 i.e.
 
 cd /usr/ports/sysutils/smartmontools/
 make deinstall
 make clean
 make
 make install
 
 not even reinstalling libtool15, libiconv, and gettext helped on that  
 machine, yet the kernel is the same.
 
 Odd.
 
 Adrian
 

From: Jeremy Chadwick <freebsd@jdc.parodius.com>
To: bug-followup@FreeBSD.org, serg@tmn.ru
Cc: sos@freebsd.dk
Subject: Re: kern/95342: [ata] Unable to run smartd after last commits to sys/dev/ata (regression)
Date: Mon, 8 May 2006 08:46:46 -0700

 I can duplicate this problem on my 6.x systems.  They were just
 upgraded from and to, respectively:
 
 FreeBSD 6.1-PRERELEASE #0: Tue Mar 14 00:05:31 PST 2006
 FreeBSD 6.1-STABLE #0: Mon May  8 07:59:52 PDT 2006
 
 Here's what smartctl says:
 
 ======
 icarus# /usr/local/sbin/smartctl -a /dev/ad12
 smartctl version 5.33 [i386-portbld-freebsd6.1] Copyright (C) 2002-4 Bruce Allen
 Home page is http://smartmontools.sourceforge.net/
 
 Smartctl: Device Read Identity Failed (not an ATA/ATAPI device)
 
 A mandatory SMART command failed: exiting. To continue, add one or more '-T permissive' options.
 ======
 
 And here's with smartmontools 5.36 says -- same problem:
 
 ======
 icarus# ./smartctl -a /dev/ad12
 smartctl version 5.36 [i386-portbld-freebsd6.1] Copyright (C) 2002-6 Bruce Allen
 Home page is http://smartmontools.sourceforge.net/
 
 Smartctl: Device Read Identity Failed (not an ATA/ATAPI device)
 
 A mandatory SMART command failed: exiting. To continue, add one or more '-T permissive' options.
 ======
 
 Rebuilding the port does not fix this.  Upgrading the port does not fix
 this, although upgrading the port to 5.36 __does__ get rid of all the
 ugly files/patch-* hacks.  The port maintainer should probably do this
 soon.
 
 I keep a semi-close eye on CVS commits, and my guess is that Soren
 changed something within the ATA subsystem between March 14th and
 May 8th which broke SMART inqueries.  Here's the CVS history -- as
 you can see, Soren's been hard at work.
 
 http://www.freebsd.org/cgi/cvsweb.cgi/src/sys/dev/ata/
 
 We need to find out the cause for SMART inquiries failing, and make
 sure it gets fixed soon.
 
 Soren, is this due to the ATAPI sense data/ioctl change done on
 April 4th?  I haven't tried backing out that change and testing,
 although I could, but it's easier to just ask you.  :-)
 
 Thanks.
 
 -- 
 | Jeremy Chadwick                                 jdc at parodius.com |
 | Parodius Networking                        http://www.parodius.com/ |
 | UNIX Systems Administrator                   Mountain View, CA, USA |
 | Making life hard for others since 1977.                             |
 

From: Maxim Konovalov <maxim@macomnet.ru>
To: bug-followup@freebsd.org
Cc:  
Subject: kern/95342
Date: Sun, 14 May 2006 01:30:57 +0400 (MSD)

 Bruce Mah has just added an entry in 6.1 ERRATA.
 
 http://www.freebsd.org/releases/6.1R/errata.html
 
 -- 
 Maxim Konovalov
State-Changed-From-To: open->closed 
State-Changed-By: sos 
State-Changed-When: Mon Sep 18 19:09:06 UTC 2006 
State-Changed-Why:  
smartmontools works for me with both -stable and -current. 

http://www.freebsd.org/cgi/query-pr.cgi?pr=95342 
>Unformatted:
