From doconnor@cain.gsoft.com.au  Mon Mar 27 03:55:15 2006
Return-Path: <doconnor@cain.gsoft.com.au>
Received: from mx1.FreeBSD.org (mx1.freebsd.org [216.136.204.125])
	by hub.freebsd.org (Postfix) with ESMTP id B1DCE16A424
	for <FreeBSD-gnats-submit@freebsd.org>; Mon, 27 Mar 2006 03:55:14 +0000 (UTC)
	(envelope-from doconnor@cain.gsoft.com.au)
Received: from cain.gsoft.com.au (cain.gsoft.com.au [203.31.81.10])
	by mx1.FreeBSD.org (Postfix) with ESMTP id 9501543D45
	for <FreeBSD-gnats-submit@freebsd.org>; Mon, 27 Mar 2006 03:55:13 +0000 (GMT)
	(envelope-from doconnor@cain.gsoft.com.au)
Received: from cain.gsoft.com.au (localhost [127.0.0.1])
	by cain.gsoft.com.au (8.13.5/8.13.4) with ESMTP id k2R3t7uP013100
	(version=TLSv1/SSLv3 cipher=DHE-RSA-AES256-SHA bits=256 verify=NO)
	for <FreeBSD-gnats-submit@freebsd.org>; Mon, 27 Mar 2006 13:25:07 +0930 (CST)
	(envelope-from doconnor@cain.gsoft.com.au)
Received: (from doconnor@localhost)
	by cain.gsoft.com.au (8.13.5/8.13.4/Submit) id k2R3t7dE013099;
	Mon, 27 Mar 2006 14:25:07 +1030 (CST)
	(envelope-from doconnor)
Message-Id: <200603270355.k2R3t7dE013099@cain.gsoft.com.au>
Date: Mon, 27 Mar 2006 14:25:07 +1030 (CST)
From: "Daniel O'Connor" <doconnor@gsoft.com.au>
Reply-To: "Daniel O'Connor" <doconnor@gsoft.com.au>
To: FreeBSD-gnats-submit@freebsd.org
Cc:
Subject: pfctl complains about ALTQ missing
X-Send-Pr-Version: 3.113
X-GNATS-Notify:

>Number:         94992
>Category:       kern
>Synopsis:       [pf] [patch] pfctl complains about ALTQ missing
>Confidential:   no
>Severity:       non-critical
>Priority:       low
>Responsible:    freebsd-pf
>State:          closed
>Quarter:        
>Keywords:       
>Date-Required:  
>Class:          sw-bug
>Submitter-Id:   current-users
>Arrival-Date:   Mon Mar 27 04:00:31 GMT 2006
>Closed-Date:    Fri Nov 10 23:16:24 GMT 2006
>Last-Modified:  Fri Nov 10 23:30:30 GMT 2006
>Originator:     Daniel O'Connor
>Release:        FreeBSD 6.0-RELEASE amd64
>Organization:
>Environment:
System: FreeBSD cain.gsoft.com.au 6.0-RELEASE FreeBSD 6.0-RELEASE #0: Wed Nov 2 19:07:38 UTC 2005 root@rat.samsco.home:/usr/obj/usr/src/sys/GENERIC amd64


>Description:
pfctl complains about ALTQ support being missing from the kernel yet it is not in
GENERIC. IMO it should only complain if you are trying to do something ALTQ related.

>How-To-Repeat:
pfctl -s rules

>Fix:
Index: contrib/pf/pfctl/pfctl.c
===================================================================
RCS file: /usr/local/ncvs/src/contrib/pf/pfctl/pfctl.c,v
retrieving revision 1.6
diff -u -r1.6 pfctl.c
--- contrib/pf/pfctl/pfctl.c    3 May 2005 16:55:20 -0000       1.6
+++ contrib/pf/pfctl/pfctl.c    27 Mar 2006 03:51:31 -0000
@@ -1510,7 +1510,7 @@

        if (ioctl(dev, DIOCGETALTQS, &pa)) {
                if (errno == ENODEV) {
-                       if (!(opts & PF_OPT_QUIET))
+                       if (opts & PF_OPT_VERBOSE)
                                fprintf(stderr, "No ALTQ support in kernel\n"
                                    "ALTQ related functions disabled\n");
                        return (0);


>Release-Note:
>Audit-Trail:
Responsible-Changed-From-To: freebsd-bugs->freebsd-pf 
Responsible-Changed-By: linimon 
Responsible-Changed-When: Thu Jun 15 08:00:01 UTC 2006 
Responsible-Changed-Why:  
Over to maintainer(s). 

http://www.freebsd.org/cgi/query-pr.cgi?pr=94992 
State-Changed-From-To: open->closed 
State-Changed-By: mlaier 
State-Changed-When: Fri Nov 10 23:15:33 UTC 2006 
State-Changed-Why:  


http://www.freebsd.org/cgi/query-pr.cgi?pr=94992 

From: Max Laier <max@love2party.net>
To: bug-followup@freebsd.org,
 doconnor@gsoft.com.au
Cc:  
Subject: Re: kern/94992: [pf] [patch] pfctl complains about ALTQ missing
Date: Sat, 11 Nov 2006 00:22:23 +0100

 This was meant to say: "This behavior is intentional as the (historical) 
 behavior caused many confused users as well.  Sorry"
>Unformatted:
