From vivek@lorax.kcilink.com  Mon Mar 13 21:10:09 2006
Return-Path: <vivek@lorax.kcilink.com>
Received: from mx1.FreeBSD.org (mx1.freebsd.org [216.136.204.125])
	by hub.freebsd.org (Postfix) with ESMTP id 63D5316A424
	for <FreeBSD-gnats-submit@freebsd.org>; Mon, 13 Mar 2006 21:10:09 +0000 (UTC)
	(envelope-from vivek@lorax.kcilink.com)
Received: from lorax.kcilink.com (lorax.kciLink.com [206.112.95.1])
	by mx1.FreeBSD.org (Postfix) with ESMTP id DA23343D62
	for <FreeBSD-gnats-submit@freebsd.org>; Mon, 13 Mar 2006 21:10:07 +0000 (GMT)
	(envelope-from vivek@lorax.kcilink.com)
Received: from localhost (localhost [127.0.0.1])
	by lorax.kcilink.com (Postfix) with ESMTP id EEE42115CB
	for <FreeBSD-gnats-submit@freebsd.org>; Mon, 13 Mar 2006 16:10:06 -0500 (EST)
Received: from lorax.kcilink.com ([127.0.0.1])
 by localhost (lorax.kcilink.com [127.0.0.1]) (amavisd-new, port 10024)
 with LMTP id 47696-03-2 for <FreeBSD-gnats-submit@freebsd.org>;
 Mon, 13 Mar 2006 16:10:06 -0500 (EST)
Received: by lorax.kcilink.com (Postfix, from userid 120)
	id 389EE115C3; Mon, 13 Mar 2006 16:10:06 -0500 (EST)
Message-Id: <20060313211006.389EE115C3@lorax.kcilink.com>
Date: Mon, 13 Mar 2006 16:10:06 -0500 (EST)
From: Vivek Khera <vivek@khera.org>
Reply-To: Vivek Khera <vivek@khera.org>
To: FreeBSD-gnats-submit@freebsd.org
Cc:
Subject: BGE5721 or BGE5750?
X-Send-Pr-Version: 3.113
X-GNATS-Notify:

>Number:         94424
>Category:       kern
>Synopsis:       [bge] BGE5721 or BGE5750?
>Confidential:   no
>Severity:       non-critical
>Priority:       low
>Responsible:    yongari
>State:          closed
>Quarter:        
>Keywords:       
>Date-Required:  
>Class:          doc-bug
>Submitter-Id:   current-users
>Arrival-Date:   Mon Mar 13 21:10:18 GMT 2006
>Closed-Date:    Tue Sep 28 00:00:55 UTC 2010
>Last-Modified:  Tue Sep 28 00:00:55 UTC 2010
>Originator:     Vivek Khera
>Release:        FreeBSD 6.0-RELEASE-p4 i386
>Organization:
>Environment:
System: FreeBSD lorax.kcilink.com 6.0-RELEASE-p4 FreeBSD 6.0-RELEASE-p4 #0: Thu Jan 26 17:37:40 EST 2006 vivek@lorax.kcilink.com:/u/lorax1/usr6/obj.i386/n/lorax1/usr6/src/sys/LORAX i386


	
>Description:
	

I'm trying to make a BGE5714 chip found in the IBM e326m server recognized by
the bge driver.  To do so I was comparing the vendor ID and device ID numbers
from other systems I have and noticed that according the boot logs this
device:

bge0@pci5:0:0:  class=0x020000 card=0x01851028 chip=0x165914e4 rev=0x01 hdr=0x00

is identified by 6.1-PRE as 

bge0: <Broadcom BCM5721 Gigabit Ethernet, ASIC rev. 0x4001> mem 0xdfaf0000-0xdfa

This is what Dell claims is in this server (Dell PE800).  However, according
to pciconf -l -v the PCI database claims it is

BCM5750A1 NetXtreme Gigabit Ethernet PCI Express

So something disagrees with something here.  I never really opened up this box
to find what chipset was *really* in there, and I send the original PR that
got the PE800 ethernet support into FreeBSD 5.4, so it could be Dell's error
in their literature.

>How-To-Repeat:
	

n/a

>Fix:

	

Resolve the inconsistency between if_bgreg.h and if_bge.c and the pciconf
database.  I have no idea how to figure out which is more accurate.  I suspect
pciconf is.
>Release-Note:
>Audit-Trail:

From: "Internet Partners, Inc. Tech Support" <support@ipinc.net>
To: <bug-followup@FreeBSD.org>, <vivek@khera.org>
Cc:  
Subject: Re: kern/94424: [bge] BGE5721 or BGE5750?
Date: Wed, 3 May 2006 12:24:46 -0700

 Please don't submit multiple PR's for the same bug without referencing each
 other, this is the same bug you filed on PR kern/94863
 
State-Changed-From-To: open->closed 
State-Changed-By: linimon 
State-Changed-When: Wed May 3 19:53:23 UTC 2006 
State-Changed-Why:  
Superseded by kern/94863. 

http://www.freebsd.org/cgi/query-pr.cgi?pr=94424 

From: Vivek Khera <vivek@khera.org>
To: "Internet Partners, Inc. Tech Support" <support@ipinc.net>
Cc: <bug-followup@FreeBSD.org>
Subject: Re: kern/94424: [bge] BGE5721 or BGE5750?
Date: Wed, 3 May 2006 16:36:01 -0400

 On May 3, 2006, at 3:24 PM, Internet Partners, Inc. Tech Support wrote:
 
 >
 > Please don't submit multiple PR's for the same bug without  
 > referencing each
 > other, this is the same bug you filed on PR kern/94863
 >
 
 No, these are two entirely separate issues on entirely separate  
 machines.  One is a Dell PE800 with chip ID 1659 which is  
 inconsistently identified, and the other is getting an IBM e326m with  
 chip ID 166a to work.
 
 
State-Changed-From-To: closed->open 
State-Changed-By: linimon 
State-Changed-When: Wed May 3 21:19:53 UTC 2006 
State-Changed-Why:  
Closed by mistake; these are two separate issues. 

http://www.freebsd.org/cgi/query-pr.cgi?pr=94424 

From: "Internet Partners, Inc. Tech Support" <support@ipinc.net>
To: "Vivek Khera" <vivek@khera.org>
Cc: <bug-followup@FreeBSD.org>
Subject: RE: kern/94424: [bge] BGE5721 or BGE5750?
Date: Wed, 3 May 2006 15:27:59 -0700

 Actually, they are the same bug just different manifestations
 of it.  If you check PR kern/94863 you will see that BCM5714
 which is used in the IBM is listed in the current BGE driver
 as having ASIC rev 0x05 which is not consistent with what the
 Broadcom Linux driver says it's supposed to be.  Broadcom says
 BCM5714 has ASIC rev 0x09.  There are also other differences in
 the list of FreeBSD bge driver chip IDs from what Broadcom has
 listed in the Linux driver.
 
 The BCM6714 and BCM5780 require a number of exceptions in
 the FreeBSD bge driver because they don't act exactly like the
 other Broadcom chips.  Those exceptions aren't currently present,
 but even if they were, they wouldn't be activated because the chip
 ID's and asci revs aren't correct in the FreeBSD driver.
 
 Part of the fix for the IBM with it's BCM5714 chip is correction of
 the chip and ASIC ID's, and that is the fix you need for the Dell PE800.
 I've done part of that already and posted a patch to PR 94863 I need
 to finish the rest of that and post the patch to the if_bge.c driver.
 But, that is the easy part of the bge driver fix, since it just deals
 with updating the detection logic in the driver.  The other part of the
 bge fix is figuring out where the BCM5714 needs to be excepted in the
 driver.
 The obvious way would be for the bge maintainer to look at the Linux
 driver code, and see where they have excepted the BCM5714, then transfer the
 exceptions into the FreeBSD driver.  I've already posted the link to
 where the Broadcom driver is.  It shouldn't be more than a few hours
 work for an experienced driver programmer, unfortunately I am not
 one of those people. :-(
 
 Ted
 
State-Changed-From-To: open->feedback 
State-Changed-By: yongari 
State-Changed-When: Mon Sep 27 19:25:19 UTC 2010 
State-Changed-Why:  
I beleive the PCI device id of BCM5721 controller is 0x1659 so 
bge(4) is right about telling the truth. I don't know why 
pciconf(8) shows BCM5750A1 but I guess it showed MAC version of 
controller. Broadcom used to deploy different controller model 
naming and MAC naming. They also added even more confusion by 
introducing different PHY model naming. 
All drivers in tree shows controller name, not MAC/PHY model name, 
so I believe bge(4) is correct. I think other OSes will show BCM5721 
for the controller. So do you agree on closing the PR? 


Responsible-Changed-From-To: freebsd-bugs->yongari 
Responsible-Changed-By: yongari 
Responsible-Changed-When: Mon Sep 27 19:25:19 UTC 2010 
Responsible-Changed-Why:  
Take. 

http://www.freebsd.org/cgi/query-pr.cgi?pr=94424 

From: Vick Khera <khera@kcilink.com>
To: bug-followup@FreeBSD.org
Cc:  
Subject: Re: kern/94424: [bge] BGE5721 or BGE5750?
Date: Mon, 27 Sep 2010 15:56:38 -0400

 Wow... I don't think I have this machine anymore to verify the =
 identification is consistent now in freebsd 8 between bge(4) and pciconf =
 output.  I have no opinion on whether to close or not the PR.
 
 

From: Pyun YongHyeon <pyunyh@gmail.com>
To: Vick Khera <khera@kcilink.com>
Cc: yongari@freebsd.org, bug-followup@FreeBSD.org
Subject: Re: kern/94424: [bge] BGE5721 or BGE5750?
Date: Mon, 27 Sep 2010 15:28:42 -0700

 On Mon, Sep 27, 2010 at 08:00:17PM +0000, Vick Khera wrote:
 > The following reply was made to PR kern/94424; it has been noted by GNATS.
 > 
 > From: Vick Khera <khera@kcilink.com>
 > To: bug-followup@FreeBSD.org
 > Cc:  
 > Subject: Re: kern/94424: [bge] BGE5721 or BGE5750?
 > Date: Mon, 27 Sep 2010 15:56:38 -0400
 > 
 >  Wow... I don't think I have this machine anymore to verify the =
 >  identification is consistent now in freebsd 8 between bge(4) and pciconf =
 >  output.  I have no opinion on whether to close or not the PR.
 >  
 
 Checking /usr/share/misc/pci_vendors in HEAD shows the following.
 
 [...]
 14E4    Broadcom Corporation
         034F    ??? (NV36GL?)
         04B5    Broadcom 54bg Wireless (BCM4312)
 	...
         1659    NetXtreme Gigabit Ethernet PCI Express (BCM5721)
 	...
 
 As you see, pciconf(8) data base was corrected to BCM5721.
State-Changed-From-To: feedback->closed 
State-Changed-By: yongari 
State-Changed-When: Tue Sep 28 00:00:16 UTC 2010 
State-Changed-Why:  
Submitter has no longer access to the hardware but it's beleived 
that pciconf(8) database was changed to show BCM5721 for 
the controller. 
bge(4) was correct so close it. 

http://www.freebsd.org/cgi/query-pr.cgi?pr=94424 
>Unformatted:
