From nobody@FreeBSD.org  Wed Mar  8 22:47:32 2006
Return-Path: <nobody@FreeBSD.org>
Received: from mx1.FreeBSD.org (mx1.freebsd.org [216.136.204.125])
	by hub.freebsd.org (Postfix) with ESMTP id 8175316A420
	for <freebsd-gnats-submit@FreeBSD.org>; Wed,  8 Mar 2006 22:47:32 +0000 (GMT)
	(envelope-from nobody@FreeBSD.org)
Received: from www.freebsd.org (www.freebsd.org [216.136.204.117])
	by mx1.FreeBSD.org (Postfix) with ESMTP id 502FD43D45
	for <freebsd-gnats-submit@FreeBSD.org>; Wed,  8 Mar 2006 22:47:32 +0000 (GMT)
	(envelope-from nobody@FreeBSD.org)
Received: from www.freebsd.org (localhost [127.0.0.1])
	by www.freebsd.org (8.13.1/8.13.1) with ESMTP id k28MlWPE044628
	for <freebsd-gnats-submit@FreeBSD.org>; Wed, 8 Mar 2006 22:47:32 GMT
	(envelope-from nobody@www.freebsd.org)
Received: (from nobody@localhost)
	by www.freebsd.org (8.13.1/8.13.1/Submit) id k28MlW5e044627;
	Wed, 8 Mar 2006 22:47:32 GMT
	(envelope-from nobody)
Message-Id: <200603082247.k28MlW5e044627@www.freebsd.org>
Date: Wed, 8 Mar 2006 22:47:32 GMT
From: Dave Thompson <davetho@cisco.com>
To: freebsd-gnats-submit@FreeBSD.org
Subject: Inconsistent use of time_second & time_uptime in in_rmx.c
X-Send-Pr-Version: www-2.3

>Number:         94249
>Category:       kern
>Synopsis:       [netinet] Inconsistent use of time_second & time_uptime in in_rmx.c
>Confidential:   no
>Severity:       non-critical
>Priority:       low
>Responsible:    oleg
>State:          closed
>Quarter:        
>Keywords:       
>Date-Required:  
>Class:          sw-bug
>Submitter-Id:   current-users
>Arrival-Date:   Wed Mar 08 22:50:04 GMT 2006
>Closed-Date:    Thu Jul 06 12:35:21 GMT 2006
>Last-Modified:  Thu Jul 06 12:35:21 GMT 2006
>Originator:     Dave Thompson
>Release:        7.0_CURRENT
>Organization:
Cisco Systems
>Environment:
FreeBSD stack 7.0-CURRENT FreeBSD 7.0-CURRENT #56: Wed Mar  8 21:13:43 CST 2006     davetho@davetho-freebsd.cisco.com:/local/davetho/cvs/csi/freebsd7_xen3/src/sys/i386-xen/compile/XENCONF  i386
>Description:
The function in_rtqtimo() of netinet/in_rmx.c uses time_second to set the
starting value of arg.nextstop.  When the rnh tree is walked, the nextstop
arg can then be changed in in_rtqkill() to rt->rt_rmx.rmx_expire which is
set using time_uptime. On my system (with the DIAGNOSTIC option turned on),
this causes the tvtohz() call at the end of the in_rtqtimo() function to
display a console message that the atv.tv_sec value is negative.  This is
negative because on my system the time_second value is a very large value
and the time_uptime is a small value.
>How-To-Repeat:
Turn the DIAGNOSTIC option on and wait for the in_rtqtimo() function to run.
>Fix:
Change the references to time_second in in_rtqtimo() of netinet/in_rmx.c
to use time_uptime instead.  This will be consistent with the use of
time_uptime in the other related functions.
>Release-Note:
>Audit-Trail:
Responsible-Changed-From-To: freebsd-bugs->andre 
Responsible-Changed-By: glebius 
Responsible-Changed-When: Wed Mar 15 15:51:05 UTC 2006 
Responsible-Changed-Why:  
AFAIK, this inconsistensy introduced by Andre. 

http://www.freebsd.org/cgi/query-pr.cgi?pr=94249 
Responsible-Changed-From-To: andre->oleg 
Responsible-Changed-By: oleg 
Responsible-Changed-When: Wed Jul 5 23:09:56 UTC 2006 
Responsible-Changed-Why:  
i'll fix that. 


http://www.freebsd.org/cgi/query-pr.cgi?pr=94249 
State-Changed-From-To: open->closed 
State-Changed-By: oleg 
State-Changed-When: Thu Jul 6 12:33:05 UTC 2006 
State-Changed-Why:  
Fixed in src/sys/netinet/in_rmx.c rev. 1.55 
Thank you for your report! 


http://www.freebsd.org/cgi/query-pr.cgi?pr=94249 
>Unformatted:
