From nobody@FreeBSD.org  Wed Mar  1 22:12:36 2006
Return-Path: <nobody@FreeBSD.org>
Received: from mx1.FreeBSD.org (mx1.freebsd.org [216.136.204.125])
	by hub.freebsd.org (Postfix) with ESMTP id 0B9E216A420
	for <freebsd-gnats-submit@FreeBSD.org>; Wed,  1 Mar 2006 22:12:36 +0000 (GMT)
	(envelope-from nobody@FreeBSD.org)
Received: from www.freebsd.org (www.freebsd.org [216.136.204.117])
	by mx1.FreeBSD.org (Postfix) with ESMTP id A42CE43D46
	for <freebsd-gnats-submit@FreeBSD.org>; Wed,  1 Mar 2006 22:12:35 +0000 (GMT)
	(envelope-from nobody@FreeBSD.org)
Received: from www.freebsd.org (localhost [127.0.0.1])
	by www.freebsd.org (8.13.1/8.13.1) with ESMTP id k21MCZ4B004078
	for <freebsd-gnats-submit@FreeBSD.org>; Wed, 1 Mar 2006 22:12:35 GMT
	(envelope-from nobody@www.freebsd.org)
Received: (from nobody@localhost)
	by www.freebsd.org (8.13.1/8.13.1/Submit) id k21MCZEo004077;
	Wed, 1 Mar 2006 22:12:35 GMT
	(envelope-from nobody)
Message-Id: <200603012212.k21MCZEo004077@www.freebsd.org>
Date: Wed, 1 Mar 2006 22:12:35 GMT
From: Neel Natu <neelnatu@yahoo.com>
To: freebsd-gnats-submit@FreeBSD.org
Subject: panic in libstand when closing raw disk device
X-Send-Pr-Version: www-2.3

>Number:         93998
>Category:       kern
>Synopsis:       [libstand] [patch] panic in libstand when closing raw disk device
>Confidential:   no
>Severity:       serious
>Priority:       medium
>Responsible:    brueffer
>State:          closed
>Quarter:        
>Keywords:       
>Date-Required:  
>Class:          sw-bug
>Submitter-Id:   current-users
>Arrival-Date:   Wed Mar 01 22:20:03 GMT 2006
>Closed-Date:    Wed Nov 04 14:42:13 CET 2009
>Last-Modified:  Wed Nov 04 14:42:13 CET 2009
>Originator:     Neel Natu
>Release:        6.0-RELEASE
>Organization:
>Environment:
FreeBSD neel3.silverspringnet.com. 6.0-RELEASE FreeBSD 6.0-RELEASE #0: Thu Nov  3 09:36:13 UTC 2005     root@x64.samsco.home:/usr/obj/usr/src/sys/GENERIC  i386

>Description:
We have a modified loader(8) than opens a raw disk partition using libstand open(), reads stuff from it and does a close() on the file descriptor. This close() panics because it tries to free 'f_rabuf'. This is because it has not been initialized in open() for raw disk devices.
>How-To-Repeat:
Not sure how to exercise this from the vanilla loader.
>Fix:
===================================================================
RCS file: /cvsroot/eng/gw/lib/libstand/open.c,v
retrieving revision 1.1.1.1.16.1
retrieving revision 1.2.14.1
diff -u -r1.1.1.1.16.1 -r1.2.14.1
--- open.c	16 Feb 2006 01:44:27 -0000	1.1.1.1.16.1
+++ open.c	18 Feb 2006 06:47:00 -0000	1.2.14.1
@@ -117,6 +117,7 @@
     /* see if we opened a raw device; otherwise, 'file' is the file name. */
     if (file == (char *)0 || *file == '\0') {
 	f->f_flags |= F_RAW;
+	f->f_rabuf = NULL;
 	return (fd);
     }
 

>Release-Note:
>Audit-Trail:
State-Changed-From-To: open->patched 
State-Changed-By: brueffer 
State-Changed-When: Wed Oct 28 15:13:54 CET 2009 
State-Changed-Why:  
Committed, thanks! 


Responsible-Changed-From-To: freebsd-bugs->brueffer 
Responsible-Changed-By: brueffer 
Responsible-Changed-When: Wed Oct 28 15:13:54 CET 2009 
Responsible-Changed-Why:  
MFC reminder. 

http://www.freebsd.org/cgi/query-pr.cgi?pr=93998 

From: dfilter@FreeBSD.ORG (dfilter service)
To: bug-followup@FreeBSD.org
Cc:  
Subject: Re: kern/93998: commit references a PR
Date: Wed, 28 Oct 2009 14:13:57 +0000 (UTC)

 Author: brueffer
 Date: Wed Oct 28 14:13:45 2009
 New Revision: 198542
 URL: http://svn.freebsd.org/changeset/base/198542
 
 Log:
   Initialize f_rabuf in the raw device case. A subsequent close()
   later on would try to free it, leading to a crash.
   
   PR:		93998
   Submitted by:	neel
   MFC after:	1 week
 
 Modified:
   head/lib/libstand/open.c
 
 Modified: head/lib/libstand/open.c
 ==============================================================================
 --- head/lib/libstand/open.c	Wed Oct 28 13:50:28 2009	(r198541)
 +++ head/lib/libstand/open.c	Wed Oct 28 14:13:45 2009	(r198542)
 @@ -113,6 +113,7 @@ open(const char *fname, int mode)
      /* see if we opened a raw device; otherwise, 'file' is the file name. */
      if (file == (char *)0 || *file == '\0') {
  	f->f_flags |= F_RAW;
 +	f->f_rabuf = NULL;
  	return (fd);
      }
  
 _______________________________________________
 svn-src-all@freebsd.org mailing list
 http://lists.freebsd.org/mailman/listinfo/svn-src-all
 To unsubscribe, send any mail to "svn-src-all-unsubscribe@freebsd.org"
 
State-Changed-From-To: patched->closed 
State-Changed-By: brueffer 
State-Changed-When: Wed Nov 4 14:41:53 CET 2009 
State-Changed-Why:  
MFCs done. 

http://www.freebsd.org/cgi/query-pr.cgi?pr=93998 
>Unformatted:
