From antoine@peanut.dreadbsd.org  Thu Feb 23 15:08:07 2006
Return-Path: <antoine@peanut.dreadbsd.org>
Received: from mx1.FreeBSD.org (mx1.freebsd.org [216.136.204.125])
	by hub.freebsd.org (Postfix) with ESMTP id DA4A516A420
	for <FreeBSD-gnats-submit@freebsd.org>; Thu, 23 Feb 2006 15:08:07 +0000 (GMT)
	(envelope-from antoine@peanut.dreadbsd.org)
Received: from barton.dreadbsd.org (peanut.dreadbsd.org [82.67.196.50])
	by mx1.FreeBSD.org (Postfix) with ESMTP id CB12643D48
	for <FreeBSD-gnats-submit@freebsd.org>; Thu, 23 Feb 2006 15:08:06 +0000 (GMT)
	(envelope-from antoine@peanut.dreadbsd.org)
Received: from barton.dreadbsd.org (localhost [127.0.0.1])
	by barton.dreadbsd.org (8.13.4/8.13.4) with ESMTP id k1NF82Qu059229
	for <FreeBSD-gnats-submit@freebsd.org>; Thu, 23 Feb 2006 16:08:02 +0100 (CET)
	(envelope-from antoine@peanut.dreadbsd.org)
Received: (from antoine@localhost)
	by barton.dreadbsd.org (8.13.4/8.13.1/Submit) id k1NF82l1059228;
	Thu, 23 Feb 2006 16:08:02 +0100 (CET)
	(envelope-from antoine)
Message-Id: <200602231508.k1NF82l1059228@barton.dreadbsd.org>
Date: Thu, 23 Feb 2006 16:08:02 +0100 (CET)
From: Antoine Brodin <antoine.brodin@laposte.net>
Reply-To: Antoine Brodin <antoine.brodin@laposte.net>
To: FreeBSD-gnats-submit@freebsd.org
Cc:
Subject: [patch] 2 copy'n'paste-os in sys/vm/phys_pager.c
X-Send-Pr-Version: 3.113
X-GNATS-Notify:

>Number:         93755
>Category:       kern
>Synopsis:       [kernel] [patch] 2 copy'n'paste-os in sys/vm/phys_pager.c
>Confidential:   no
>Severity:       non-critical
>Priority:       low
>Responsible:    remko
>State:          closed
>Quarter:        
>Keywords:       
>Date-Required:  
>Class:          doc-bug
>Submitter-Id:   current-users
>Arrival-Date:   Thu Feb 23 15:10:03 GMT 2006
>Closed-Date:    Sat Nov 10 11:23:29 UTC 2007
>Last-Modified:  Sat Nov 10 11:30:03 UTC 2007
>Originator:     Antoine Brodin
>Release:        FreeBSD 7.0-CURRENT i386
>Organization:
none
>Environment:
System: FreeBSD barton.dreadbsd.org 7.0-CURRENT FreeBSD 7.0-CURRENT #0: Wed Feb 22 20:15:40 CET 2006 antoine@barton.dreadbsd.org:/usr/obj/usr/src/sys/BARTON i386


>Description:
There are two copy'n'paste-os in sys/vm/phys_pager.c
>How-To-Repeat:
Read sys/vm/phys_pager.c
>Fix:
note: phyalc can be changed to ph[sy]al[cl]


--- phys.diff begins here ---
Index: phys_pager.c
===================================================================
RCS file: /home/ncvs/src/sys/vm/phys_pager.c,v
retrieving revision 1.23
diff -u -p -r1.23 phys_pager.c
--- phys_pager.c	7 Jan 2005 02:29:26 -0000	1.23
+++ phys_pager.c	23 Feb 2006 14:36:52 -0000
@@ -44,7 +44,7 @@ __FBSDID("$FreeBSD: src/sys/vm/phys_page
 
 /* prevent concurrant creation races */
 static int phys_pager_alloc_lock;
-/* list of device pager objects */
+/* list of phys pager objects */
 static struct pagerlst phys_pager_object_list;
 /* protect access to phys_pager_object_list */
 static struct mtx phys_pager_mtx;
@@ -82,7 +82,7 @@ phys_pager_alloc(void *handle, vm_ooffse
 		 */
 		while (phys_pager_alloc_lock) {
 			phys_pager_alloc_lock = -1;
-			tsleep(&phys_pager_alloc_lock, PVM, "swpalc", 0);
+			tsleep(&phys_pager_alloc_lock, PVM, "phyalc", 0);
 		}
 		phys_pager_alloc_lock = 1;
 
--- phys.diff ends here ---


>Release-Note:
>Audit-Trail:
Responsible-Changed-From-To: freebsd-bugs->imp 
Responsible-Changed-By: remko 
Responsible-Changed-When: Fri Jan 26 21:48:18 UTC 2007 
Responsible-Changed-Why:  
Hello Warner, can you look into this ticket please? and either commit it 
or allow me to do so if it is OK, thanks! 

http://www.freebsd.org/cgi/query-pr.cgi?pr=93755 
Responsible-Changed-From-To: imp->remko 
Responsible-Changed-By: imp 
Responsible-Changed-When: Tue Jul 10 15:54:48 MDT 2007 
Responsible-Changed-Why:  
Looks good to me, reassigning to remko 


http://www.freebsd.org/cgi/query-pr.cgi?pr=93755 
State-Changed-From-To: open->patched 
State-Changed-By: remko 
State-Changed-When: Tue Oct 30 14:48:40 UTC 2007 
State-Changed-Why:  
One of the two items fixed in current, the second item does no 
longer apply to the version in -CURRENT nor on RELENG_7 because 
that already lost the specific function-call. 

RELENG_6 needs the second item though. 

http://www.freebsd.org/cgi/query-pr.cgi?pr=93755 

From: dfilter@FreeBSD.ORG (dfilter service)
To: bug-followup@FreeBSD.org
Cc:  
Subject: Re: kern/93755: commit references a PR
Date: Tue, 30 Oct 2007 22:12:49 +0000 (UTC)

 remko       2007-10-30 14:48:14 UTC
 
   FreeBSD src repository
 
   Modified files:
     sys/vm               phys_pager.c 
   Log:
   Correct a copy and paste'o in phys_pager.c, we are talking about phys here
   and not about devices.
   
   PR:             93755
   Approved by:    imp (mentor, implicit when re-assigning the ticket to me).
   
   Revision  Changes    Path
   1.29      +1 -1      src/sys/vm/phys_pager.c
 _______________________________________________
 cvs-all@freebsd.org mailing list
 http://lists.freebsd.org/mailman/listinfo/cvs-all
 To unsubscribe, send any mail to "cvs-all-unsubscribe@freebsd.org"
 
State-Changed-From-To: patched->closed 
State-Changed-By: remko 
State-Changed-When: Sat Nov 10 11:23:28 UTC 2007 
State-Changed-Why:  
This had been committed to all relevant branches at the moment. 

http://www.freebsd.org/cgi/query-pr.cgi?pr=93755 

From: dfilter@FreeBSD.ORG (dfilter service)
To: bug-followup@FreeBSD.org
Cc:  
Subject: Re: kern/93755: commit references a PR
Date: Sat, 10 Nov 2007 11:21:25 +0000 (UTC)

 remko       2007-11-10 11:21:17 UTC
 
   FreeBSD src repository
 
   Modified files:        (Branch: RELENG_7)
     sys/vm               phys_pager.c 
   Log:
   MFC rev 1.29 phys_pager.c
   
     Correct a copy and paste'o in phys_pager.c, we are talking about phys here
     and not about devices.
   
     PR:           93755
     Approved by:  imp (mentor, implicit when re-assigning the ticket to me).
   
   Approved by:    re (kensmith), imp (mentor)
   
   Revision  Changes    Path
   1.28.2.1  +1 -1      src/sys/vm/phys_pager.c
 _______________________________________________
 cvs-all@freebsd.org mailing list
 http://lists.freebsd.org/mailman/listinfo/cvs-all
 To unsubscribe, send any mail to "cvs-all-unsubscribe@freebsd.org"
 

From: dfilter@FreeBSD.ORG (dfilter service)
To: bug-followup@FreeBSD.org
Cc:  
Subject: Re: kern/93755: commit references a PR
Date: Sat, 10 Nov 2007 11:23:08 +0000 (UTC)

 remko       2007-11-10 11:23:01 UTC
 
   FreeBSD src repository
 
   Modified files:        (Branch: RELENG_6)
     sys/vm               phys_pager.c 
   Log:
   MFC rev 1.29 phys_pager.c
   
     Correct a copy and paste'o in phys_pager.c, we are talking about phys here
     and not about devices.
   
     PR:           93755
     Approved by:  imp (mentor, implicit when re-assigning the ticket to me).
   
   This includes another fix that is not part of CURRENT and RELENG_7 because
   that is not part of the code there anymore.
   
   Approved by:    re (kensmith), imp (mentor)
   
   Revision  Changes    Path
   1.23.2.1  +2 -2      src/sys/vm/phys_pager.c
 _______________________________________________
 cvs-all@freebsd.org mailing list
 http://lists.freebsd.org/mailman/listinfo/cvs-all
 To unsubscribe, send any mail to "cvs-all-unsubscribe@freebsd.org"
 
>Unformatted:
