From nobody@FreeBSD.org  Mon Feb  6 15:27:56 2006
Return-Path: <nobody@FreeBSD.org>
Received: from mx1.FreeBSD.org (mx1.freebsd.org [216.136.204.125])
	by hub.freebsd.org (Postfix) with ESMTP id 6C7B616A420
	for <freebsd-gnats-submit@FreeBSD.org>; Mon,  6 Feb 2006 15:27:56 +0000 (GMT)
	(envelope-from nobody@FreeBSD.org)
Received: from www.freebsd.org (www.freebsd.org [216.136.204.117])
	by mx1.FreeBSD.org (Postfix) with ESMTP id 2AE6443D4C
	for <freebsd-gnats-submit@FreeBSD.org>; Mon,  6 Feb 2006 15:27:56 +0000 (GMT)
	(envelope-from nobody@FreeBSD.org)
Received: from www.freebsd.org (localhost [127.0.0.1])
	by www.freebsd.org (8.13.1/8.13.1) with ESMTP id k16FRtD8051427
	for <freebsd-gnats-submit@FreeBSD.org>; Mon, 6 Feb 2006 15:27:55 GMT
	(envelope-from nobody@www.freebsd.org)
Received: (from nobody@localhost)
	by www.freebsd.org (8.13.1/8.13.1/Submit) id k16FRt8G051422;
	Mon, 6 Feb 2006 15:27:55 GMT
	(envelope-from nobody)
Message-Id: <200602061527.k16FRt8G051422@www.freebsd.org>
Date: Mon, 6 Feb 2006 15:27:55 GMT
From: Vladimir Ivanov <wawa@yandex-team.ru>
To: freebsd-gnats-submit@FreeBSD.org
Subject: em driver watchdog reset's warning suppressed due to small bug in em_watchdog()
X-Send-Pr-Version: www-2.3

>Number:         92895
>Category:       kern
>Synopsis:       [em] [patch] em driver watchdog reset's warning suppressed due to small bug in em_watchdog()
>Confidential:   no
>Severity:       serious
>Priority:       medium
>Responsible:    glebius
>State:          closed
>Quarter:        
>Keywords:       
>Date-Required:  
>Class:          sw-bug
>Submitter-Id:   current-users
>Arrival-Date:   Mon Feb 06 15:30:07 GMT 2006
>Closed-Date:    Thu Feb 16 12:46:07 GMT 2006
>Last-Modified:  Thu Feb 16 12:46:07 GMT 2006
>Originator:     Vladimir Ivanov
>Release:        RELENG_5
>Organization:
Yandex LLC
>Environment:
FreeBSD dixi.yandex.net 5.5-PRERELEASE FreeBSD 5.5-PRERELEASE #15: Fri Feb  3 18:34:49 MSK 2006     root@dixi.yandex.net:/usr/obj/usr/src/sys/CORE-RTR-RELENG_5  i386

>Description:
EM driver sometimes resets hardware (under heavy load). But never reports watchdog reset (!).
The problem occured due to small mistake in em_watchdog (see patch)

>How-To-Repeat:

>Fix:
--- if_em.c.orig        Fri Feb  3 17:38:46 2006
+++ if_em.c     Mon Feb  6 18:22:58 2006
@@ -774,7 +774,7 @@ em_watchdog(struct ifnet *ifp)
                return;
        }

-       if (em_check_for_link(&adapter->hw))
+       if (!em_check_for_link(&adapter->hw))
                printf("em%d: watchdog timeout -- resetting\n", adapter->unit);

        ifp->if_flags &= ~IFF_RUNNING;

>Release-Note:
>Audit-Trail:
Responsible-Changed-From-To: freebsd-bugs->glebius 
Responsible-Changed-By: glebius 
Responsible-Changed-When: Tue Feb 7 13:28:18 UTC 2006 
Responsible-Changed-Why:  
I'll handle this. 

http://www.freebsd.org/cgi/query-pr.cgi?pr=92895 
State-Changed-From-To: open->patched 
State-Changed-By: glebius 
State-Changed-When: Thu Feb 9 12:57:50 UTC 2006 
State-Changed-Why:  
Fixed in HEAD. 

http://www.freebsd.org/cgi/query-pr.cgi?pr=92895 
State-Changed-From-To: patched->closed 
State-Changed-By: glebius 
State-Changed-When: Thu Feb 16 12:45:55 UTC 2006 
State-Changed-Why:  
Merged to RELENG_5 and RELENG_6. Thanks! 

http://www.freebsd.org/cgi/query-pr.cgi?pr=92895 
>Unformatted:
