From bryanv@daemoninthecloset.org  Sun Jan 29 17:24:17 2006
Return-Path: <bryanv@daemoninthecloset.org>
Received: from mx1.FreeBSD.org (mx1.freebsd.org [216.136.204.125])
	by hub.freebsd.org (Postfix) with ESMTP id 8696016A420
	for <FreeBSD-gnats-submit@freebsd.org>; Sun, 29 Jan 2006 17:24:17 +0000 (GMT)
	(envelope-from bryanv@daemoninthecloset.org)
Received: from sccmmhc92.asp.att.net (sccmmhc92.asp.att.net [204.127.203.212])
	by mx1.FreeBSD.org (Postfix) with ESMTP id DED4143D49
	for <FreeBSD-gnats-submit@freebsd.org>; Sun, 29 Jan 2006 17:24:16 +0000 (GMT)
	(envelope-from bryanv@daemoninthecloset.org)
Received: from torment.daemoninthecloset.org ([12.219.231.23])
          by sccmmhc92.asp.att.net (sccmmhc92) with ESMTP
          id <20060129172415m9200akoote>; Sun, 29 Jan 2006 17:24:15 +0000
Received: from misery.daemoninthecloset.org (daemongateway1.student.iastate.edu [64.113.65.231])
	(using TLSv1 with cipher DHE-RSA-AES256-SHA (256/256 bits))
	(Client CN "misery.daemoninthecloset.org", Issuer "CA Cert Signing Authority" (verified OK))
	by torment.daemoninthecloset.org (Postfix) with ESMTP id 5AF7E19
	for <FreeBSD-gnats-submit@freebsd.org>; Sun, 29 Jan 2006 11:23:40 -0600 (CST)
Received: from localhost (misery.daemoninthecloset.org [192.168.1.25])
	by misery.daemoninthecloset.org (Postfix) with ESMTP id 403AA56731
	for <FreeBSD-gnats-submit@freebsd.org>; Sun, 29 Jan 2006 11:23:16 -0600 (CST)
Received: from misery.daemoninthecloset.org ([192.168.1.25])
 by localhost (misery.daemoninthecloset.org [192.168.1.25]) (amavisd-new, port 10024)
 with ESMTP id 20388-03 for <FreeBSD-gnats-submit@freebsd.org>;
 Sun, 29 Jan 2006 11:23:15 -0600 (CST)
Received: from agonize.daemoninthecloset.org (agonize.daemoninthecloset.org [192.168.1.30])
	(using TLSv1 with cipher DHE-RSA-AES256-SHA (256/256 bits))
	(Client CN "agonize.daemoninthecloset.org", Issuer "CA Cert Signing Authority" (verified OK))
	by misery.daemoninthecloset.org (Postfix) with ESMTP id 0F453566DF
	for <FreeBSD-gnats-submit@freebsd.org>; Sun, 29 Jan 2006 11:23:15 -0600 (CST)
Received: from agonize.daemoninthecloset.org (localhost [127.0.0.1])
	by agonize.daemoninthecloset.org (Postfix) with ESMTP id B9AA82E0D2
	for <FreeBSD-gnats-submit@freebsd.org>; Sun, 29 Jan 2006 11:23:14 -0600 (CST)
Message-Id: <1138555394.24005@agonize.daemoninthecloset.org>
Date: Sun, 29 Jan 2006 11:23:14 -0600
From: "Bryan Venteicher" <bryanv@daemoninthecloset.org>
To: "FreeBSD gnats submit" <FreeBSD-gnats-submit@freebsd.org>
Subject: Incorrect Comment in vm_fault
X-Send-Pr-Version: gtk-send-pr 0.4.7 
X-GNATS-Notify:

>Number:         92509
>Category:       kern
>Synopsis:       [patch] Incorrect Comment in vm_fault
>Confidential:   no
>Severity:       non-critical
>Priority:       low
>Responsible:    tegge
>State:          closed
>Quarter:        
>Keywords:       
>Date-Required:  
>Class:          sw-bug
>Submitter-Id:   current-users
>Arrival-Date:   Sun Jan 29 17:30:09 GMT 2006
>Closed-Date:    Mon Jun 12 15:10:01 GMT 2006
>Last-Modified:  Mon Jun 12 15:10:01 GMT 2006
>Originator:     Bryan Venteicher
>Release:        FreeBSD 6.0-STABLE i386
>Organization:
>Environment:


System: FreeBSD 6.0-STABLE #3: Mon Jan 23 14:13:29 CST 2006
    root@agonize.daemoninthecloset.org:/usr/obj/usr/src/sys/AGONIZE



>Description:


In v1.82 of vm_fault.c, the functionality of RELEASE_PAGE/release_page was changed.  A comment was not updated accordingly. 


>How-To-Repeat:





>Fix:


--- vm_fault.c.orig	Sun Jan 29 11:03:48 2006
+++ vm_fault.c	Sun Jan 29 11:04:10 2006
@@ -811,7 +811,7 @@
 			    &fs.entry, &retry_object, &retry_pindex, &retry_prot, &wired);
 
 			/*
-			 * If we don't need the page any longer, put it on the active
+			 * If we don't need the page any longer, put it on the inactive
 			 * list (the easiest thing to do here).  If no one needs it,
 			 * pageout will grab it eventually.
 			 */



>Release-Note:
>Audit-Trail:
Responsible-Changed-From-To: freebsd-bugs->tegge 
Responsible-Changed-By: glebius 
Responsible-Changed-When: Tue Jan 31 08:40:52 UTC 2006 
Responsible-Changed-Why:  
Tors comment. Let him review the patch. 

http://www.freebsd.org/cgi/query-pr.cgi?pr=92509 
State-Changed-From-To: open->closed 
State-Changed-By: maxim 
State-Changed-When: Mon Jun 12 15:08:57 UTC 2006 
State-Changed-Why:  
Tor Egge has fixed the issue in HEAD and I just merged the patch 
to RELENG_6.  Thanks for the submission! 

http://www.freebsd.org/cgi/query-pr.cgi?pr=92509 
>Unformatted:
