From guy@alum.mit.edu  Thu Jan  5 08:34:22 2006
Return-Path: <guy@alum.mit.edu>
Received: from mx1.FreeBSD.org (mx1.freebsd.org [216.136.204.125])
	by hub.freebsd.org (Postfix) with ESMTP id ABB9C16A41F
	for <FreeBSD-gnats-submit@freebsd.org>; Thu,  5 Jan 2006 08:34:22 +0000 (GMT)
	(envelope-from guy@alum.mit.edu)
Received: from a.mail.sonic.net (a.mail.sonic.net [64.142.16.245])
	by mx1.FreeBSD.org (Postfix) with ESMTP id 530F943D4C
	for <FreeBSD-gnats-submit@freebsd.org>; Thu,  5 Jan 2006 08:34:22 +0000 (GMT)
	(envelope-from guy@alum.mit.edu)
Received: from [192.168.0.5] (209-204-185-249.dsl.static.sonic.net [209.204.185.249])
	(authenticated bits=0)
	by a.mail.sonic.net (8.13.3/8.13.3) with ESMTP id k058YLio013639
	(version=TLSv1/SSLv3 cipher=RC4-MD5 bits=128 verify=NO)
	for <FreeBSD-gnats-submit@freebsd.org>; Thu, 5 Jan 2006 00:34:21 -0800
Message-Id: <43BCDA0E.6060806@alum.mit.edu>
Date: Thu, 05 Jan 2006 00:34:22 -0800
From: Guy Harris <guy@alum.mit.edu>
To: FreeBSD-gnats-submit@freebsd.org
Subject: Adding a devfs rule with a rule set number of 0 locks the devfs rules

>Number:         91338
>Category:       kern
>Synopsis:       Adding a devfs rule with a rule set number of 0 locks the devfs rules
>Confidential:   no
>Severity:       serious
>Priority:       medium
>Responsible:    freebsd-bugs
>State:          closed
>Quarter:        
>Keywords:       
>Date-Required:  
>Class:          sw-bug
>Submitter-Id:   current-users
>Arrival-Date:   Thu Jan 05 08:40:10 GMT 2006
>Closed-Date:    Sat Jan 14 08:50:45 GMT 2006
>Last-Modified:  Sat Jan 14 08:50:45 GMT 2006
>Originator:     Guy Harris
>Release:        FreeBSD 6.0-RELEASE i386
>Organization:
>Environment:
 System: FreeBSD marconi.local 6.0-RELEASE FreeBSD 6.0-RELEASE #0: Thu Nov 3 09:36:13 UTC 2005 root@x64.samsco.home:/usr/obj/usr/src/sys/GENERIC i386
>Description:
 	If you submit a rule with DEVFSIO_RADD, and the rule set number
 	of the rule is 0, devfs_rules_ioctl() will return without
 	releasing any locks - in particular, it won't release the devfs
 	ruleset lock.
>How-To-Repeat:
 	Do
 
 		devfs rule add path 'bpf*' group staff mode 0660
 
 	from the command line; it should report
 
 		devfs rule: ioctl DEVFSIO_RADD: Input/output error
 
 	and should now lock up on any subsequent attempt to add rules
 	(or anything else that tries to get the devfs ruleset lock).
>Fix:
 
 	Release the lock before returning EIO:
 
 Index: devfs_rule.c
 ===================================================================
 RCS file: /home/ncvs/src/sys/fs/devfs/devfs_rule.c,v
 retrieving revision 1.20
 diff -c -r1.20 devfs_rule.c
 *** devfs_rule.c	24 Sep 2005 07:03:09 -0000	1.20
 --- devfs_rule.c	1 Jan 2006 02:28:32 -0000
 ***************
 *** 186,193 ****
    			error = EEXIST;
    			break;
    		}
 ! 		if (rid2rsn(dr->dr_id) == 0)
 ! 			return (EIO);
    		error = devfs_rule_insert(dr);
    		break;
    	case DEVFSIO_RAPPLY:
 --- 186,195 ----
    			error = EEXIST;
    			break;
    		}
 ! 		if (rid2rsn(dr->dr_id) == 0) {
 ! 			error = EIO;
 ! 			break;
 ! 		}
    		error = devfs_rule_insert(dr);
    		break;
    	case DEVFSIO_RAPPLY:
 
 
 
>Release-Note:
>Audit-Trail:
Responsible-Changed-From-To: gnats-admin->freebsd-bugs 
Responsible-Changed-By: linimon 
Responsible-Changed-When: Thu Jan 5 17:50:36 UTC 2006 
Responsible-Changed-Why:  
Rescue this PR from the 'pending' category. 

http://www.freebsd.org/cgi/query-pr.cgi?pr=91338 
State-Changed-From-To: open->closed 
State-Changed-By: rwatson 
State-Changed-When: Sat Jan 14 08:49:47 UTC 2006 
State-Changed-Why:  
This is a dup of bin/88463, and was corrected by a recent commit and 
MFC I made (with an identical fix to the one proposed here). 

Thanks! 


http://www.freebsd.org/cgi/query-pr.cgi?pr=91338 
>Unformatted:
