From nobody@FreeBSD.org  Fri Dec 30 06:47:01 2005
Return-Path: <nobody@FreeBSD.org>
Received: from mx1.FreeBSD.org (mx1.freebsd.org [216.136.204.125])
	by hub.freebsd.org (Postfix) with ESMTP id 8F07016A41F
	for <freebsd-gnats-submit@FreeBSD.org>; Fri, 30 Dec 2005 06:47:01 +0000 (GMT)
	(envelope-from nobody@FreeBSD.org)
Received: from www.freebsd.org (www.freebsd.org [216.136.204.117])
	by mx1.FreeBSD.org (Postfix) with ESMTP id 22E5A43D48
	for <freebsd-gnats-submit@FreeBSD.org>; Fri, 30 Dec 2005 06:47:01 +0000 (GMT)
	(envelope-from nobody@FreeBSD.org)
Received: from www.freebsd.org (localhost [127.0.0.1])
	by www.freebsd.org (8.13.1/8.13.1) with ESMTP id jBU6l0G1093336
	for <freebsd-gnats-submit@FreeBSD.org>; Fri, 30 Dec 2005 06:47:00 GMT
	(envelope-from nobody@www.freebsd.org)
Received: (from nobody@localhost)
	by www.freebsd.org (8.13.1/8.13.1/Submit) id jBU6l0kg093335;
	Fri, 30 Dec 2005 06:47:00 GMT
	(envelope-from nobody)
Message-Id: <200512300647.jBU6l0kg093335@www.freebsd.org>
Date: Fri, 30 Dec 2005 06:47:00 GMT
From: Christian Ullrich <chris@chrullrich.de>
To: freebsd-gnats-submit@FreeBSD.org
Subject: ipfilter rule changes fail in securelevel 2
X-Send-Pr-Version: www-2.3

>Number:         91082
>Category:       kern
>Synopsis:       [ipfilter] [patch] ipfilter rule changes fail in securelevel 2
>Confidential:   no
>Severity:       serious
>Priority:       medium
>Responsible:    darrenr
>State:          closed
>Quarter:        
>Keywords:       
>Date-Required:  
>Class:          sw-bug
>Submitter-Id:   current-users
>Arrival-Date:   Fri Dec 30 06:50:01 GMT 2005
>Closed-Date:    Mon Feb 27 06:48:08 GMT 2006
>Last-Modified:  Mon Feb 27 06:48:08 GMT 2006
>Originator:     Christian Ullrich
>Release:        6.0-STABLE
>Organization:
>Environment:
FreeBSD legolas.chrullrich.de 6.0-STABLE FreeBSD 6.0-STABLE #0: Wed Dec 28 19:11:05 CET 2005     root@wt.chrullrich.de:/usr/obj/usr/src/sys/LEGOLAS  i386
>Description:
On FreeBSD 6.0, modifying ipfilter rule sets is disallowed in any securelevel >= 2. This behavior differs from earlier releases, the init(8) man page, and the requirements for changing ipnat rules, which are allowed up to securelevel 2.

Release 3 of ipfilter initially required securelevel < 2 for rule changes as well, which was changed in revision 1.28 of src/sys/contrib/ipfilter/netinet/ip_fil.c, back in 2002.

In FreeBSD 6, ipfilter 3 has been replaced by release 4, which, again, requires the lower securelevel. As noted above, that applies only to changes to filtering rules, not NAT rules.
>How-To-Repeat:
In securelevel 2, run anything which will change ipf filter rules.
>Fix:
--- sys/contrib/ipfilter/netinet/ip_fil_freebsd.c.orig  Fri Dec 30 07:40:18 2005
+++ sys/contrib/ipfilter/netinet/ip_fil_freebsd.c       Fri Dec 30 07:40:40 2005
@@ -421,7 +421,7 @@
        friostat_t fio;

 #if (BSD >= 199306) && defined(_KERNEL)
-       if ((securelevel >= 2) && (mode & FWRITE))
+       if ((securelevel >= 3) && (mode & FWRITE))
                return EPERM;
 #endif

>Release-Note:
>Audit-Trail:
Responsible-Changed-From-To: freebsd-bugs->darrenr 
Responsible-Changed-By: glebius 
Responsible-Changed-When: Fri Dec 30 11:02:34 UTC 2005 
Responsible-Changed-Why:  
To ipfilter maintainer. 

http://www.freebsd.org/cgi/query-pr.cgi?pr=91082 
State-Changed-From-To: open->feedback 
State-Changed-By: darrenr 
State-Changed-When: Mon Feb 27 06:47:19 UTC 2006 
State-Changed-Why:  


http://www.freebsd.org/cgi/query-pr.cgi?pr=91082 
State-Changed-From-To: feedback->closed 
State-Changed-By: darrenr 
State-Changed-When: Mon Feb 27 06:47:56 UTC 2006 
State-Changed-Why:  
fixed in -current with 4.1.10 

http://www.freebsd.org/cgi/query-pr.cgi?pr=91082 
>Unformatted:
