From cejkar@fit.vutbr.cz  Thu Dec 22 17:00:44 2005
Return-Path: <cejkar@fit.vutbr.cz>
Received: from mx1.FreeBSD.org (mx1.freebsd.org [216.136.204.125])
	by hub.freebsd.org (Postfix) with ESMTP id E99F516A41F
	for <FreeBSD-gnats-submit@freebsd.org>; Thu, 22 Dec 2005 17:00:44 +0000 (GMT)
	(envelope-from cejkar@fit.vutbr.cz)
Received: from kazi.fit.vutbr.cz (kazi.fit.vutbr.cz [147.229.8.12])
	by mx1.FreeBSD.org (Postfix) with ESMTP id 8EA7043D5F
	for <FreeBSD-gnats-submit@freebsd.org>; Thu, 22 Dec 2005 17:00:34 +0000 (GMT)
	(envelope-from cejkar@fit.vutbr.cz)
Received: from kazi.fit.vutbr.cz (localhost [127.0.0.1])
	by kazi.fit.vutbr.cz (envelope-from cejkar@fit.vutbr.cz) (8.13.5/8.13.5) with ESMTP id jBMH0Td6084847
	(version=TLSv1/SSLv3 cipher=DHE-RSA-AES256-SHA bits=256 verify=NO)
	for <FreeBSD-gnats-submit@freebsd.org>; Thu, 22 Dec 2005 18:00:29 +0100 (CET)
Received: (from cejkar@localhost)
	by kazi.fit.vutbr.cz (8.13.5/8.13.1/Submit) id jBMH0TDb084846;
	Thu, 22 Dec 2005 18:00:29 +0100 (CET)
	(envelope-from cejkar)
Message-Id: <200512221700.jBMH0TDb084846@kazi.fit.vutbr.cz>
Date: Thu, 22 Dec 2005 18:00:29 +0100 (CET)
From: Rudolf Cejka <cejkar@fit.vutbr.cz>
Reply-To: Rudolf Cejka <cejkar@fit.vutbr.cz>
To: FreeBSD-gnats-submit@freebsd.org
Cc:
Subject: SMBFS with character conversions sometimes hangs
X-Send-Pr-Version: 3.113
X-GNATS-Notify:

>Number:         90815
>Category:       kern
>Synopsis:       [smbfs] [patch] SMBFS with character conversions sometimes hangs
>Confidential:   no
>Severity:       serious
>Priority:       medium
>Responsible:    freebsd-fs
>State:          analyzed
>Quarter:        
>Keywords:       
>Date-Required:  
>Class:          sw-bug
>Submitter-Id:   current-users
>Arrival-Date:   Thu Dec 22 17:10:02 GMT 2005
>Closed-Date:    
>Last-Modified:  Mon May 18 04:22:08 UTC 2009
>Originator:     Rudolf Cejka
>Release:        6.0-STABLE #11: Thu Dec 22 17:12:43 CET 2005
>Organization:
FIT, Brno University of Technology, Czech Republic
>Environment:

>Description:

If I mount smb fs with mount_smbfs -Eiso8859-2:cp852 -Lcs_CZ.ISO8859-2 ...
and there are some file/directory names, where some characters could not
be converted, directory tree traversion hangs. It is because iconv_xxx()
function returns -1, which is forwarded to the upper layer, where -1
is incorrectly taken as ERESTART and path conversion is restarted from
the beginning, which results in infinite loop.

>How-To-Repeat:

Try to mount some smb fs with character conversions (for example, I do
use -Eiso8859-2:cp852,-Lcs_CZ.ISO8859-2), where iconv could not convert
all characters in file/directory names and try to run find . on mounted
directory - it should hang when it finds nonconvertible file/directory
name (maybe it "works" just for directory names, which is the case
where I tried to find the problem).

>Fix:

I'm currently trying the following patch, which fixes the hang problem,
however I'm not sure, how much is it really correct.

--- sys/netsmb/smb_subr.c.orig	Thu Dec 22 16:52:55 2005
+++ sys/netsmb/smb_subr.c	Thu Dec 22 17:11:19 2005
@@ -323,7 +323,10 @@
 {
 	size_t outlen = len;
 
-	return iconv_conv((struct iconv_drv*)mbp->mb_udata, &src, &len, &dst, &outlen);
+	if (iconv_conv((struct iconv_drv*)mbp->mb_udata,
+	    &src, &len, &dst, &outlen) == -1)
+		bcopy(src, dst, len);
+	return 0;
 }
 
 int
>Release-Note:
>Audit-Trail:

From: Boris Popov <bp@freebsd.org>
To: bug-followup <bug-followup@FreeBSD.org>, cejkar <cejkar@fit.vutbr.cz>
Cc:  
Subject: Re: kern/90815: [smbfs] [patch] SMBFS with character conversions 
	sometimes hangs
Date: Wed, 25 Mar 2009 21:19:48 +0600

   The patch looks correct.
 
 -- 
 Boris Popov
State-Changed-From-To: open->analyzed 
State-Changed-By: linimon 
State-Changed-When: Thu Mar 26 02:06:16 UTC 2009 
State-Changed-Why:  
bp@ has stated that this patch looks correct. 

http://www.freebsd.org/cgi/query-pr.cgi?pr=90815 
Responsible-Changed-From-To: freebsd-bugs->freebsd-fs 
Responsible-Changed-By: linimon 
Responsible-Changed-When: Mon May 18 04:22:01 UTC 2009 
Responsible-Changed-Why:  
Over to maintainer(s). 

http://www.freebsd.org/cgi/query-pr.cgi?pr=90815 
>Unformatted:
