From bkoenig@cs.tu-berlin.de  Sat Dec 17 01:17:20 2005
Return-Path: <bkoenig@cs.tu-berlin.de>
Received: from mx1.FreeBSD.org (mx1.freebsd.org [216.136.204.125])
	by hub.freebsd.org (Postfix) with ESMTP id DE28616A41F
	for <FreeBSD-gnats-submit@freebsd.org>; Sat, 17 Dec 2005 01:17:20 +0000 (GMT)
	(envelope-from bkoenig@cs.tu-berlin.de)
Received: from efacilitas.de (smtp.efacilitas.de [85.10.196.108])
	by mx1.FreeBSD.org (Postfix) with ESMTP id 7402D43D49
	for <FreeBSD-gnats-submit@freebsd.org>; Sat, 17 Dec 2005 01:17:20 +0000 (GMT)
	(envelope-from bkoenig@cs.tu-berlin.de)
Received: from eurystheus.local (port-212-202-39-231.dynamic.qsc.de [212.202.39.231])
	by efacilitas.de (Postfix) with ESMTP id 8434C4CBAF
	for <FreeBSD-gnats-submit@freebsd.org>; Sat, 17 Dec 2005 02:25:40 +0100 (CET)
Received: from hoppel.local (eurystheus.local [192.168.1.67])
	by eurystheus.local (Postfix) with SMTP id 301675089C
	for <FreeBSD-gnats-submit@freebsd.org>; Sat, 17 Dec 2005 02:16:06 +0100 (CET)
Received: by hoppel.local (sSMTP sendmail emulation); Sat, 17 Dec 2005 02:16:06 +0100
Message-Id: <20051217011606.301675089C@eurystheus.local>
Date: Sat, 17 Dec 2005 02:16:06 +0100
From: "Bjrn Knig" <bkoenig@cs.tu-berlin.de>
Reply-To: Bjrn Knig <bkoenig@cs.tu-berlin.de>
To: FreeBSD-gnats-submit@freebsd.org
Cc:
Subject: UDF driver might calculate a wrong descriptor tag checksum
X-Send-Pr-Version: 3.113
X-GNATS-Notify:

>Number:         90521
>Category:       kern
>Synopsis:       [udf] [patch] UDF driver might calculate a wrong descriptor tag checksum
>Confidential:   no
>Severity:       non-critical
>Priority:       low
>Responsible:    markus
>State:          closed
>Quarter:        
>Keywords:       
>Date-Required:  
>Class:          sw-bug
>Submitter-Id:   current-users
>Arrival-Date:   Sat Dec 17 01:20:02 GMT 2005
>Closed-Date:    Sat Feb 16 16:24:05 UTC 2008
>Last-Modified:  Sat Feb 16 16:24:05 UTC 2008
>Originator:     Bjrn Knig
>Release:        FreeBSD 6.0-RELEASE i386
>Organization:
>Environment:
System: FreeBSD hoppel.local 6.0-RELEASE FreeBSD 6.0-RELEASE #3: Sun Nov 27 19:50:05 CET 2005 bkoenig@hoppel.local:/home/bkoenig/obj/home/bkoenig/devel/freebsd/RELENG_6_0/src/sys/HOPPEL i386

>Description:
	According to ECMA-167 7.2.3 the bytes 0-3 and 5-15 should be used
	to calculate the checksum of a descriptor tag. Actually only
	the bytes 0-3 and 5-14 will be used.
	
>How-To-Repeat:
>Fix:
--- udf_vfsops.c-2005121701.diff begins here ---
--- src/sys/fs/udf/udf_vfsops.c.orig	Sat Dec 17 01:51:41 2005
+++ src/sys/fs/udf/udf_vfsops.c	Sat Nov 26 20:15:50 2005
@@ -296,7 +296,7 @@
 	if (tag->id != id)
 		return (EINVAL);
 
-	for (i = 0; i < 15; i++)
+	for (i = 0; i < 16; i++)
 		cksum = cksum + itag[i];
 	cksum = cksum - itag[4];
 
--- udf_vfsops.c-2005121701.diff ends here ---


>Release-Note:
>Audit-Trail:

From: Andriy Gapon <avg@icyb.net.ua>
To: bug-followup@FreeBSD.org, bkoenig@cs.tu-berlin.de
Cc:  
Subject: Re: kern/90521: [udf] [patch] UDF driver might calculate a wrong
 descriptor tag checksum
Date: Wed, 24 May 2006 16:10:11 +0300

 One small correction (addition): this calculation is described in
 ECMA-167, Part 4, 7.2.3. ("part 4" part was missing).
 
 -- 
 Andriy Gapon

From: dfilter@FreeBSD.ORG (dfilter service)
To: bug-followup@FreeBSD.org
Cc:  
Subject: Re: kern/90521: commit references a PR
Date: Tue, 11 Dec 2007 19:49:45 +0000 (UTC)

 markus      2007-12-11 19:49:40 UTC
 
   FreeBSD src repository
 
   Modified files:
     sys/fs/udf           udf_vfsops.c 
   Log:
   Fix calculation of descriptor tag checksums. According to ECMA-167, Part 4,
   7.2.3, bytes 0-3 and 5-15 are used to calculate the checksum of a descriptor
   tag.
   
   PR:             kern/90521
   Submitted by:   Bjrn Knig <bkoenig@cs.tu-berlin.de>
   Reviewed by:    scottl
   Approved by:    emax (mentor)
   
   Revision  Changes    Path
   1.50      +1 -1      src/sys/fs/udf/udf_vfsops.c
 _______________________________________________
 cvs-all@freebsd.org mailing list
 http://lists.freebsd.org/mailman/listinfo/cvs-all
 To unsubscribe, send any mail to "cvs-all-unsubscribe@freebsd.org"
 
State-Changed-From-To: open->patched 
State-Changed-By: markus 
State-Changed-When: Tue Dec 11 19:50:20 UTC 2007 
State-Changed-Why:  
Committed to -CURRENT, MFC to come. Thanks! 


Responsible-Changed-From-To: freebsd-bugs->markus 
Responsible-Changed-By: markus 
Responsible-Changed-When: Tue Dec 11 19:50:20 UTC 2007 
Responsible-Changed-Why:  
MFC reminder 

http://www.freebsd.org/cgi/query-pr.cgi?pr=90521 
State-Changed-From-To: patched->closed 
State-Changed-By: markus 
State-Changed-When: Sat Feb 16 16:22:33 UTC 2008 
State-Changed-Why:  
MFC to RELENG_7/6/5 done. Thanks! 

http://www.freebsd.org/cgi/query-pr.cgi?pr=90521 
>Unformatted:
