From jdc@koitsu.dyndns.org  Fri Dec  2 12:32:53 2005
Return-Path: <jdc@koitsu.dyndns.org>
Received: from mx1.FreeBSD.org (mx1.freebsd.org [216.136.204.125])
	by hub.freebsd.org (Postfix) with ESMTP id 848DF16A41F
	for <FreeBSD-gnats-submit@freebsd.org>; Fri,  2 Dec 2005 12:32:53 +0000 (GMT)
	(envelope-from jdc@koitsu.dyndns.org)
Received: from ylpvm29.prodigy.net (ylpvm29-ext.prodigy.net [207.115.57.60])
	by mx1.FreeBSD.org (Postfix) with ESMTP id E853A43D58
	for <FreeBSD-gnats-submit@freebsd.org>; Fri,  2 Dec 2005 12:32:52 +0000 (GMT)
	(envelope-from jdc@koitsu.dyndns.org)
Received: from pimout6-ext.prodigy.net (pimout6-int.prodigy.net [207.115.4.22])
	by ylpvm29.prodigy.net (8.12.10 outbound/8.12.10) with ESMTP id jB2CX3to001394
	for <FreeBSD-gnats-submit@freebsd.org>; Fri, 2 Dec 2005 07:33:03 -0500
Received: from icarus.home.lan (adsl-71-141-104-33.dsl.snfc21.pacbell.net [71.141.104.33])
	by pimout6-ext.prodigy.net (8.13.4 outbound domainkey aix/8.13.4) with ESMTP id jB2CWk8U129164
	for <FreeBSD-gnats-submit@freebsd.org>; Fri, 2 Dec 2005 07:32:47 -0500
Received: by icarus.home.lan (Postfix, from userid 1000)
	id 24E545C033; Fri,  2 Dec 2005 04:32:46 -0800 (PST)
Message-Id: <20051202123246.24E545C033@icarus.home.lan>
Date: Fri,  2 Dec 2005 04:32:46 -0800 (PST)
From: Jeremy Chadwick <freebsd@jdc.parodius.com>
Reply-To: Jeremy Chadwick <freebsd@jdc.parodius.com>
To: FreeBSD-gnats-submit@freebsd.org
Cc:
Subject: PCI code outputs superfluous "failed to enable/disable memory/port mapping!" messages
X-Send-Pr-Version: 3.113
X-GNATS-Notify:

>Number:         89837
>Category:       kern
>Synopsis:       [pci] PCI code outputs superfluous "failed to enable/disable memory/port mapping!" messages
>Confidential:   no
>Severity:       non-critical
>Priority:       low
>Responsible:    freebsd-bugs
>State:          closed
>Quarter:        
>Keywords:       
>Date-Required:  
>Class:          change-request
>Submitter-Id:   current-users
>Arrival-Date:   Fri Dec 02 12:40:02 GMT 2005
>Closed-Date:    Thu Apr 28 04:34:19 UTC 2011
>Last-Modified:  Thu Apr 28 04:34:19 UTC 2011
>Originator:     Jeremy Chadwick
>Release:        FreeBSD 6.0-STABLE i386
>Organization:
Parodius Networking
>Environment:
System: FreeBSD icarus.home.lan 6.0-STABLE FreeBSD 6.0-STABLE #0: Fri Dec 2 02:22:17 PST 2005 root@icarus.home.lan:/usr/obj/usr/src/sys/ICARUS i386
>Description:
	The PCI code can under many configurations spit out the following kernel message:

	XXXpciXXX: failed to {enable|disable} {memory|port} mapping!

	This is output via device_printf() in sys/dev/pci/pci.c, lines ~677 and ~706.

	There have been numerous PRs and mailing list threads about what this message
	means (particularly the "failed to enable memory mapping!" message).  So far,
	every report I've seen that involves driver developers results in them saying
	"This message should only appear when bootverbose is enabled, so ignore it."

	I'm proposing that the above device_printf() calls be wrapped with a
	bootverbose check -- and ONLY for the device_printf() (not the return()).

	I'm sure there will be someone who will step up and say why this is a bad idea,
	blah blah blah, but I'll remind you that such messages on -STABLE need only
	appear when there _really_ is a problem, and not when "there isn't a problem
	but it's nice to know"; messages of this nature should be left for -CURRENT.

	If it's _really_ necessary, then users need something that explains what this
	message actually means (one can find such explanations in certain manpages,
	such as bge(4) -- but, at least in my case, it seems unlikely that my Intel
	ICH5 Southbridge, on an Intel motherboard nonetheless, would lack
	bus-mastering support :-) ).
>How-To-Repeat:
	Not applicable.
>Fix:
	Wrap the device_printf() statements in sys/dev/pci/pci.c which output
	the aforementioned message with an "if (bootverbose)" conditional.

	I can provide a patch if someone doesn't want to deal with doing it.

	This matter should apply to both 5.x and 6.x kernels (and probably 7.x too).
>Release-Note:
>Audit-Trail:

From: Jeremy Chadwick <freebsd@jdc.parodius.com>
To: bug-followup@FreeBSD.org, freebsd@jdc.parodius.com
Cc:  
Subject: Re: kern/89837: PCI code outputs superfluous "failed to enable/disable memory/port mapping!" messages
Date: Fri, 2 Dec 2005 05:21:30 -0800

 A brief follow-up to this PR:
 
 My recommendation is a bit hasty, solely for reasons like what you
 will see in PR i386/89296.
 
 That PR should probably be increased from low priority to medium or
 high priority, as it may be the cause of issues many of us are reporting
 pertaining to PCI memory space mapping.
 
 In English: the kernel message I'm complaining about seems useful
 indeed, but the core problems that are inducing the message do not
 seem to be getting the attention they may need.  I'm unfamiliar with
 PCI architecture, so this needs to go to someone with the appropriate
 skill set.
 
 -- 
 | Jeremy Chadwick                                 jdc at parodius.com |
 | Parodius Networking                        http://www.parodius.com/ |
 | UNIX Systems Administrator                   Mountain View, CA, USA |
 | Making life hard for others since 1977.                             |
 

From: John Baldwin <jhb@FreeBSD.org>
To: bug-followup@FreeBSD.org, freebsd@jdc.parodius.com
Cc:  
Subject: Re: kern/89837: [pci] PCI code outputs superfluous "failed to enable/disable
 memory/port mapping!" messages
Date: Wed, 27 Apr 2011 17:32:47 -0400

 I suspect this no longer occurs after the PCI bus was changed to handle 
 BARs on legacy ATA devices.
 
 -- 
 John Baldwin

From: Jeremy Chadwick <freebsd@jdc.parodius.com>
To: John Baldwin <jhb@FreeBSD.org>
Cc: bug-followup@FreeBSD.org
Subject: Re: kern/89837: [pci] PCI code outputs superfluous "failed to
 enable/disable memory/port mapping!" messages
Date: Wed, 27 Apr 2011 14:42:58 -0700

 On Wed, Apr 27, 2011 at 05:32:47PM -0400, John Baldwin wrote:
 > I suspect this no longer occurs after the PCI bus was changed to
 > handle BARs on legacy ATA devices.
 
 Thanks for the follow-up, John.  That sounds extremely likely.  Given
 that, closing this PR should be fine.
 
 -- 
 | Jeremy Chadwick                                   jdc@parodius.com |
 | Parodius Networking                       http://www.parodius.com/ |
 | UNIX Systems Administrator                  Mountain View, CA, USA |
 | Making life hard for others since 1977.               PGP 4BD6C0CB |
 
State-Changed-From-To: open->closed 
State-Changed-By: linimon 
State-Changed-When: Thu Apr 28 04:34:00 UTC 2011 
State-Changed-Why:  
Closed at submitter's request. 

http://www.freebsd.org/cgi/query-pr.cgi?pr=89837 
>Unformatted:
