From nobody@FreeBSD.org  Tue Nov 15 20:14:57 2005
Return-Path: <nobody@FreeBSD.org>
Received: from mx1.FreeBSD.org (mx1.freebsd.org [216.136.204.125])
	by hub.freebsd.org (Postfix) with ESMTP id AF85016A41F
	for <freebsd-gnats-submit@FreeBSD.org>; Tue, 15 Nov 2005 20:14:57 +0000 (GMT)
	(envelope-from nobody@FreeBSD.org)
Received: from www.freebsd.org (www.freebsd.org [216.136.204.117])
	by mx1.FreeBSD.org (Postfix) with ESMTP id 7A34143D45
	for <freebsd-gnats-submit@FreeBSD.org>; Tue, 15 Nov 2005 20:14:57 +0000 (GMT)
	(envelope-from nobody@FreeBSD.org)
Received: from www.freebsd.org (localhost [127.0.0.1])
	by www.freebsd.org (8.13.1/8.13.1) with ESMTP id jAFKEvDi007134
	for <freebsd-gnats-submit@FreeBSD.org>; Tue, 15 Nov 2005 20:14:57 GMT
	(envelope-from nobody@www.freebsd.org)
Received: (from nobody@localhost)
	by www.freebsd.org (8.13.1/8.13.1/Submit) id jAFKEvYc007113;
	Tue, 15 Nov 2005 20:14:57 GMT
	(envelope-from nobody)
Message-Id: <200511152014.jAFKEvYc007113@www.freebsd.org>
Date: Tue, 15 Nov 2005 20:14:57 GMT
From: Rostislav Krasny <rosti.bsd@gmail.com>
To: freebsd-gnats-submit@FreeBSD.org
Subject: Running 'kldunload smbfs' without 'smbutil logout' always panicing the system
X-Send-Pr-Version: www-2.3

>Number:         89085
>Category:       kern
>Synopsis:       [smbfs] [patch] Running 'kldunload smbfs' without 'smbutil logout' always panicing the system
>Confidential:   no
>Severity:       serious
>Priority:       medium
>Responsible:    freebsd-bugs
>State:          closed
>Quarter:        
>Keywords:       
>Date-Required:  
>Class:          sw-bug
>Submitter-Id:   current-users
>Arrival-Date:   Tue Nov 15 20:20:22 GMT 2005
>Closed-Date:    Tue Nov 22 02:19:01 GMT 2005
>Last-Modified:  Tue Nov 22 02:19:01 GMT 2005
>Originator:     Rostislav Krasny
>Release:        6.0
>Organization:
>Environment:
FreeBSD saturn.lan 6.0-RELEASE FreeBSD 6.0-RELEASE #0: Wed Nov  2 23:45:48 IST 2005     root@saturn.lan:/usr/obj/usr/src/sys/GENERIC  i386
>Description:
The system doesn't prevent unloading the smbfs.ko module when there is any
yet opened SMB connection. The result is a panic.
>How-To-Repeat:
# kldload smbfs
netsmb_dev: loaded
# smbutil login //user@server
Password:
Connect to USER
# kldunload smbfs
smb_sm_done: 1 connection still active
netsmb_dev: unload
#

Fatal trap 12: page fault while in kernel mode
fault virtual address	= 0xc17c295d
fault code		= supervisor read, page not present
instruction pointer	= 0x20:0xc17c295d
stack pointer		= 0x28:0xcc8e2ce0
frame pointer		= 0x28:0xcc8e2d10
code segment		= base 0x0, limit 0xfffff, type 0x1b
			= DPL 0, pres 1, def32 1, gran 1
processor flags		= interrupt enabled, resume, IOPL = 0
current process		= 596 (smbiod0)
trap number		= 12
panic: page fault
Uptime: 15m7s
Dumping 127 MB (2 chunks)
[snip]


The server is Windows XP Professional SP2.
>Fix:

>Release-Note:
>Audit-Trail:

From: Rostislav Krasny <rosti.bsd@gmail.com>
To: bug-followup@FreeBSD.org
Cc:  
Subject: Re: kern/89085 : [smbfs] [panic] Running 'kldunload smbfs' without
 'smbutil logout' always panicing the system
Date: Thu, 17 Nov 2005 06:57:45 +0200

 Following patch of src/sys/netsmb/smb_dev.c fixes the panic:
 
 --- smb_dev.c.orig	Mon Aug 15 11:27:48 2005
 +++ /usr/src/sys/netsmb/smb_dev.c	Thu Nov 17 05:14:23 2005
 @@ -346,7 +346,8 @@
  	    case MOD_UNLOAD:
  		smb_iod_done();
  		error = smb_sm_done();
 -		error = 0;
 +		if (error != 0)
 +			break;
  		EVENTHANDLER_DEREGISTER(dev_clone, nsmb_dev_tag);
  		printf("netsmb_dev: unloaded\n");
  		break;
State-Changed-From-To: open->closed 
State-Changed-By: bp 
State-Changed-When: Tue Nov 22 02:17:06 GMT 2005 
State-Changed-Why:  
Fixed in HEAD and will be MFCed in one week. 

Thanks! 

http://www.freebsd.org/cgi/query-pr.cgi?pr=89085 
>Unformatted:
