From garys@opusnet.com  Wed Sep 21 23:34:52 2005
Return-Path: <garys@opusnet.com>
Received: from mx1.FreeBSD.org (mx1.freebsd.org [216.136.204.125])
	by hub.freebsd.org (Postfix) with ESMTP id A150116A41F
	for <FreeBSD-gnats-submit@freebsd.org>; Wed, 21 Sep 2005 23:34:52 +0000 (GMT)
	(envelope-from garys@opusnet.com)
Received: from opusnet.com (mail.opusnet.com [209.210.200.6])
	by mx1.FreeBSD.org (Postfix) with ESMTP id 5A5A043D45
	for <FreeBSD-gnats-submit@freebsd.org>; Wed, 21 Sep 2005 23:34:52 +0000 (GMT)
	(envelope-from garys@opusnet.com)
Received: from localhost.localhost [70.98.246.232] by opusnet.com with ESMTP
  (SMTPD32-8.05) id AE187ADE00D0; Wed, 21 Sep 2005 16:34:48 -0700
Received: from localhost.localhost (localhost.localhost [127.0.0.1])
	by localhost.localhost (8.13.3/8.13.3) with ESMTP id j8LNaoBC079631
	for <FreeBSD-gnats-submit@freebsd.org>; Wed, 21 Sep 2005 16:36:50 -0700 (PDT)
	(envelope-from garys@opusnet.com)
Received: (from jojo@localhost)
	by localhost.localhost (8.13.3/8.13.3/Submit) id j8LNajQg079630;
	Wed, 21 Sep 2005 16:36:45 -0700 (PDT)
	(envelope-from garys@opusnet.com)
Message-Id: <su64su8037.4su@mail.opusnet.com>
Date: Wed, 21 Sep 2005 16:36:44 -0700
From: "Gary W. Swearingen" <garys@freebsd.org>
Reply-To: garys@freebsd.org
To: FreeBSD-gnats-submit@freebsd.org
Subject: tcp_input.c and tcp_sack.c refer to obsolete ICPM_BANDLIM
X-GNATS-Notify:

>Number:         86437
>Category:       kern
>Synopsis:       tcp_input.c and tcp_sack.c refer to obsolete ICPM_BANDLIM
>Confidential:   no
>Severity:       non-critical
>Priority:       low
>Responsible:    andre
>State:          closed
>Quarter:        
>Keywords:       
>Date-Required:  
>Class:          change-request
>Submitter-Id:   current-users
>Arrival-Date:   Wed Sep 21 23:40:03 GMT 2005
>Closed-Date:    Sun Nov 08 15:53:22 UTC 2009
>Last-Modified:  Sun Nov 08 15:53:22 UTC 2009
>Originator:     Gary W. Swearingen
>Release:        FreeBSD 5.4-RELEASE i386
>Organization:
>Environment:
n/a
>Description:

These files reference the obsolete variable ICMP_BANDLIM.  I don't
know if the includes are still needed or not, but if nobody wants to
find out, the comments should probably be changed to "for unknown
purpose" or something.

src/sys/netinet/tcp_input.c:#include <netinet/ip_icmp.h>   /* for ICMP_BANDLIM             */
src/sys/netinet/tcp_input.c:#include <netinet/icmp_var.h>  /* for ICMP_BANDLIM             */
src/sys/netinet/tcp_sack.c:#include <netinet/ip_icmp.h>    /* for ICMP_BANDLIM             */
src/sys/netinet/tcp_sack.c:#include <netinet/icmp_var.h>   /* for ICMP_BANDLIM             */

>How-To-Repeat:
n/a

>Fix:
>Release-Note:
>Audit-Trail:
Responsible-Changed-From-To: freebsd-bugs->andre 
Responsible-Changed-By: rodrigc 
Responsible-Changed-When: Thu Sep 22 00:17:39 GMT 2005 
Responsible-Changed-Why:  
Andre is cleaning up all the TCP code. 

http://www.freebsd.org/cgi/query-pr.cgi?pr=86437 
State-Changed-From-To: open->patched 
State-Changed-By: andre 
State-Changed-When: Sat Feb 18 17:05:18 UTC 2006 
State-Changed-Why:  
Fixed in tcp_input.c rev. 1.289 and tcp_sack.c rev. 1.29. 

http://www.freebsd.org/cgi/query-pr.cgi?pr=86437 
State-Changed-From-To: patched->closed 
State-Changed-By: gavin 
State-Changed-When: Sun Nov 8 15:52:20 UTC 2009 
State-Changed-Why:  
This is fixed in HEAD, 8.x and 7.x, and given it's only a minor 
change in comments doesn't really need to be merged to 6.x.  Close. 

http://www.freebsd.org/cgi/query-pr.cgi?pr=86437 
>Unformatted:
