From olli@lurza.secnetix.de  Tue Aug 30 12:50:34 2005
Return-Path: <olli@lurza.secnetix.de>
Received: from mx1.FreeBSD.org (mx1.freebsd.org [216.136.204.125])
	by hub.freebsd.org (Postfix) with ESMTP id 1D30B16A41F
	for <FreeBSD-gnats-submit@freebsd.org>; Tue, 30 Aug 2005 12:50:34 +0000 (GMT)
	(envelope-from olli@lurza.secnetix.de)
Received: from lurza.secnetix.de (lurza.secnetix.de [83.120.8.8])
	by mx1.FreeBSD.org (Postfix) with ESMTP id 75B6343D48
	for <FreeBSD-gnats-submit@freebsd.org>; Tue, 30 Aug 2005 12:50:33 +0000 (GMT)
	(envelope-from olli@lurza.secnetix.de)
Received: from lurza.secnetix.de (lopipk@localhost [127.0.0.1])
	by lurza.secnetix.de (8.13.1/8.13.1) with ESMTP id j7UCoViN089523;
	Tue, 30 Aug 2005 14:50:31 +0200 (CEST)
	(envelope-from oliver.fromme@secnetix.de)
Received: (from olli@localhost)
	by lurza.secnetix.de (8.13.1/8.13.1/Submit) id j7UCoVin089522;
	Tue, 30 Aug 2005 14:50:31 +0200 (CEST)
	(envelope-from olli)
Message-Id: <200508301250.j7UCoVin089522@lurza.secnetix.de>
Date: Tue, 30 Aug 2005 14:50:31 +0200 (CEST)
From: Oliver Fromme <olli@secnetix.de>
Reply-To: Oliver Fromme <olli@secnetix.de>
To: FreeBSD-gnats-submit@freebsd.org
Cc: Oliver Fromme <olli@secnetix.de>
Subject: [patch] [trivial] fix driver message in if_xe.c
X-Send-Pr-Version: 3.113
X-GNATS-Notify:

>Number:         85477
>Category:       kern
>Synopsis:       [xe] [patch] fix driver message in if_xe.c
>Confidential:   no
>Severity:       non-critical
>Priority:       low
>Responsible:    freebsd-bugs
>State:          closed
>Quarter:        
>Keywords:       
>Date-Required:  
>Class:          sw-bug
>Submitter-Id:   current-users
>Arrival-Date:   Tue Aug 30 13:00:29 GMT 2005
>Closed-Date:    Sat Apr 15 11:42:33 GMT 2006
>Last-Modified:  Sat Apr 15 11:42:33 GMT 2006
>Originator:     Oliver Fromme
>Release:        HEAD, RELENG_6, RELENG_5
>Organization:
secnetix GmbH & Co. KG, Munich, Germany
>Environment:

   The patch applies to HEAD, RELENG_6 and RELENG_5.

   (In fact, the problem exists in all versions since rev 1.39
   of if_xe.c which was introduced between 5.1-RELEASE and
   5.2-RELEASE.)

>Description:

   This is a trivial patch that fixes a small glitch in
   a message printed from the xe driver, resulting in a
   duplicate "0x0x" prefix.  This message is only printed
   when the xe_debug level is 1 or larger (the default is 0).

>How-To-Repeat:

   Use an xe card and set the xe_debug level to 1 (or larger),
   then watch the kernel messages.

   It's pretty obvious if you look at the patch.

>Fix:

--- src/sys/dev/xe/if_xe.c.orig Sun Aug 28 21:12:22 2005
+++ src/sys/dev/xe/if_xe.c      Tue Aug 30 14:34:41 2005
@@ -293,7 +293,7 @@
   }
   if (scp->ce2) {
     XE_SELECT_PAGE(0x45);
-    DEVPRINTF(1, (dev, "CE2 version = 0x%#02x\n", XE_INB(XE_REV)));
+    DEVPRINTF(1, (dev, "CE2 version = %#04x\n", XE_INB(XE_REV)));
   }

   /* Attach the interface */
>Release-Note:
>Audit-Trail:
State-Changed-From-To: open->closed 
State-Changed-By: maxim 
State-Changed-When: Sat Apr 15 11:41:58 UTC 2006 
State-Changed-Why:  
I decided to remove "#" flag to match a style of the rest of file. 
Thanks for the report! 

http://www.freebsd.org/cgi/query-pr.cgi?pr=85477 
>Unformatted:
