From Andre.Albsmeier@siemens.com  Mon Aug 22 07:27:25 2005
Return-Path: <Andre.Albsmeier@siemens.com>
Received: from mx1.FreeBSD.org (mx1.freebsd.org [216.136.204.125])
	by hub.freebsd.org (Postfix) with ESMTP id 8987D16A41F
	for <FreeBSD-gnats-submit@freebsd.org>; Mon, 22 Aug 2005 07:27:25 +0000 (GMT)
	(envelope-from Andre.Albsmeier@siemens.com)
Received: from thoth.sbs.de (thoth.sbs.de [192.35.17.2])
	by mx1.FreeBSD.org (Postfix) with ESMTP id AEFD843D46
	for <FreeBSD-gnats-submit@freebsd.org>; Mon, 22 Aug 2005 07:27:24 +0000 (GMT)
	(envelope-from Andre.Albsmeier@siemens.com)
Received: from mail2.siemens.de (mail2.siemens.de [139.25.208.11])
	by thoth.sbs.de (8.12.6/8.12.6) with ESMTP id j7M7RNfi008484
	for <FreeBSD-gnats-submit@freebsd.org>; Mon, 22 Aug 2005 09:27:23 +0200
Received: from ims.mchp.siemens.de (ims.mchp.siemens.de [139.25.31.39])
	by mail2.siemens.de (8.12.6/8.12.6) with ESMTP id j7M7RMmo007115
	for <FreeBSD-gnats-submit@freebsd.org>; Mon, 22 Aug 2005 09:27:22 +0200
Received: from mail-ct.mchp.siemens.de (mail-ct.mchp.siemens.de [139.25.31.51])
				by ims.mchp.siemens.de  with ESMTP id j7M7RMJQ019534
				for <FreeBSD-gnats-submit@freebsd.org>; Mon, 22 Aug 2005 09:27:22 +0200 (MEST)
Received: from curry.mchp.siemens.de (curry [139.25.42.7])
	by mail-ct.mchp.siemens.de (8.12.11/8.12.11) with ESMTP id j7M7RMDV006323
	for <FreeBSD-gnats-submit@freebsd.org>; Mon, 22 Aug 2005 09:27:22 +0200 (MEST)
Received: (from localhost)
	by curry.mchp.siemens.de (8.13.3/8.13.3) id j7M7RLek073466
	for FreeBSD-gnats-submit@freebsd.org; Mon, 22 Aug 2005 09:27:21 +0200 (CEST)
Message-Id: <200508220727.j7M7RLDe014913@curry.mchp.siemens.de>
Date: Mon, 22 Aug 2005 09:27:21 +0200 (CEST)
From: Andre Albsmeier <Andre.Albsmeier@siemens.com>
To: FreeBSD-gnats-submit@freebsd.org
Cc:
Subject: [PATCH] add TH_PUSH to TH_FLAGS in  netinet/tcp.h
X-Send-Pr-Version: 3.113
X-GNATS-Notify:

>Number:         85203
>Category:       kern
>Synopsis:       [headers] [patch] add TH_PUSH to TH_FLAGS in netinet/tcp.h
>Confidential:   no
>Severity:       non-critical
>Priority:       medium
>Responsible:    bms
>State:          closed
>Quarter:        
>Keywords:       
>Date-Required:  
>Class:          change-request
>Submitter-Id:   current-users
>Arrival-Date:   Mon Aug 22 07:30:14 GMT 2005
>Closed-Date:    Mon Mar 05 10:22:12 GMT 2007
>Last-Modified:  Mon Mar  5 10:30:08 GMT 2007
>Originator:     Andre Albsmeier
>Release:        FreeBSD 5.4-STABLE i386
>Organization:
>Environment:

Any FreeBSD System

>Description:

While adding code to pflogd.c to log packets directly to syslog
I noticed that TH_PUSH is not included in TH_FLAGS in netinet/tcp.h
while all other flags are.

>How-To-Repeat:

grep -B 9 TH_FLAGS /usr/include/netinet/tcp.h

>Fix:

Although TH_FLAGS appears to be used nowhere in FreeBSD
and in case it was simply forgotten to add TH_PUSH, here
is the fix for 5.4-STABLE:

--- netinet/tcp.h.ORI	Mon Aug 22 09:14:48 2005
+++ netinet/tcp.h	Mon Aug 22 09:15:08 2005
@@ -69,7 +69,7 @@
 #define	TH_URG	0x20
 #define	TH_ECE	0x40
 #define	TH_CWR	0x80
-#define	TH_FLAGS	(TH_FIN|TH_SYN|TH_RST|TH_ACK|TH_URG|TH_ECE|TH_CWR)
+#define	TH_FLAGS	(TH_FIN|TH_SYN|TH_RST|TH_PUSH|TH_ACK|TH_URG|TH_ECE|TH_CWR)
 
 	u_short	th_win;			/* window */
 	u_short	th_sum;			/* checksum */
>Release-Note:
>Audit-Trail:
Responsible-Changed-From-To: freebsd-bugs->andre 
Responsible-Changed-By: andre 
Responsible-Changed-When: Tue Jan 24 18:21:54 UTC 2006 
Responsible-Changed-Why:  
take over. 

http://www.freebsd.org/cgi/query-pr.cgi?pr=85203 
State-Changed-From-To: open->patched 
State-Changed-By: andre 
State-Changed-When: Sat Feb 18 16:51:50 UTC 2006 
State-Changed-Why:  
Fixed in tcp.h rev. 1.33. 

http://www.freebsd.org/cgi/query-pr.cgi?pr=85203 
Responsible-Changed-From-To: andre->bms 
Responsible-Changed-By: bms 
Responsible-Changed-When: Mon Mar 5 10:21:52 UTC 2007 
Responsible-Changed-Why:  
snarf 

http://www.freebsd.org/cgi/query-pr.cgi?pr=85203 
State-Changed-From-To: patched->closed 
State-Changed-By: bms 
State-Changed-When: Mon Mar 5 10:22:03 UTC 2007 
State-Changed-Why:  
mfc 

http://www.freebsd.org/cgi/query-pr.cgi?pr=85203 

From: dfilter@FreeBSD.ORG (dfilter service)
To: bug-followup@FreeBSD.org
Cc:  
Subject: Re: kern/85203: commit references a PR
Date: Mon,  5 Mar 2007 10:22:00 +0000 (UTC)

 bms         2007-03-05 10:21:52 UTC
 
   FreeBSD src repository
 
   Modified files:        (Branch: RELENG_6)
     sys/netinet          tcp.h 
   Log:
   MFC rev 1.33:
     Add missing TH_PUSH to the TH_FLAGS enumeration.
   
   Submitted by:   Andre Albsmeier <Andre.Albsmeier-at-siemens.com>
   PR:             kern/85203
   
   Revision  Changes    Path
   1.31.2.2  +1 -1      src/sys/netinet/tcp.h
 _______________________________________________
 cvs-all@freebsd.org mailing list
 http://lists.freebsd.org/mailman/listinfo/cvs-all
 To unsubscribe, send any mail to "cvs-all-unsubscribe@freebsd.org"
 
>Unformatted:
