From nobody@FreeBSD.org  Fri Aug 19 01:14:13 2005
Return-Path: <nobody@FreeBSD.org>
Received: from mx1.FreeBSD.org (mx1.freebsd.org [216.136.204.125])
	by hub.freebsd.org (Postfix) with ESMTP id 2A0B416A41F
	for <freebsd-gnats-submit@FreeBSD.org>; Fri, 19 Aug 2005 01:14:13 +0000 (GMT)
	(envelope-from nobody@FreeBSD.org)
Received: from www.freebsd.org (www.freebsd.org [216.136.204.117])
	by mx1.FreeBSD.org (Postfix) with ESMTP id EF5CE43D46
	for <freebsd-gnats-submit@FreeBSD.org>; Fri, 19 Aug 2005 01:14:12 +0000 (GMT)
	(envelope-from nobody@FreeBSD.org)
Received: from www.freebsd.org (localhost [127.0.0.1])
	by www.freebsd.org (8.13.1/8.13.1) with ESMTP id j7J1ECRu008152
	for <freebsd-gnats-submit@FreeBSD.org>; Fri, 19 Aug 2005 01:14:12 GMT
	(envelope-from nobody@www.freebsd.org)
Received: (from nobody@localhost)
	by www.freebsd.org (8.13.1/8.13.1/Submit) id j7J1ECPl008149;
	Fri, 19 Aug 2005 01:14:12 GMT
	(envelope-from nobody)
Message-Id: <200508190114.j7J1ECPl008149@www.freebsd.org>
Date: Fri, 19 Aug 2005 01:14:12 GMT
From: Arthur Hartwig <arthur.hartwig@nokia.com>
To: freebsd-gnats-submit@FreeBSD.org
Subject: The ICH7 smb interface is not recognised
X-Send-Pr-Version: www-2.3

>Number:         85106
>Category:       kern
>Synopsis:       [ichsmb] [patch] The ICH7 smb interface is not recognised
>Confidential:   no
>Severity:       non-critical
>Priority:       medium
>Responsible:    remko
>State:          closed
>Quarter:        
>Keywords:       
>Date-Required:  
>Class:          change-request
>Submitter-Id:   current-users
>Arrival-Date:   Fri Aug 19 01:20:12 GMT 2005
>Closed-Date:    Sun Dec 02 09:10:47 UTC 2007
>Last-Modified:  Sun Dec 02 09:10:47 UTC 2007
>Originator:     Arthur Hartwig
>Release:        5.4
>Organization:
Nokia
>Environment:
FreeBSD oz-net-11.iprg.nokia.com 5.4-RELEASE FreeBSD 5.4-RELEASE #8: Thu Aug 18 16:46:30 EST 2005     hartwig@oz-net-11.iprg.nokia.com:/usr/obj/usr/src/sys/oz-net-11  i386
>Description:
The ICH7 SMB interface is not recognised
>How-To-Repeat:
Boot FreeBSD 5.4 with ichsmb support on any motherboard with Intel 945
or 955 chipset.
>Fix:
      In dev/ichsmb/ichsmb_pci.c, in the section
/* PCI unique identifiers */
add
#define ID_82801GB          0x27da8086
and in  the function ichsmb_pci_probe add another case labvl and code

Case ID_82801GB:
        device_set_desc(dev, "Intel 82801GB (ICH7) SMBus controller");
        break;

I have tested this using a couple of programs to see what devices exist on the SMBus and dumping the data in the SPD eeproms on the two DRAM sticks on a Gigabyte GA-8I945P-G motherboard which uses the Intel 945 chipset which includes the ICH7.

The ICH6 SMB is also unrecognised. Its PCI ID is 0x266A8086 and chip code is 82801FB and the driver will probably work with the ICH6 SMB by just changing it to recognise the ICH6 as described above for the ICH7. I am not able to test the ICH6 SMB.

>Release-Note:
>Audit-Trail:

From: Oliver Fromme <olli@lurza.secnetix.de>
To: bug-followup@FreeBSD.org, arthur.hartwig@nokia.com
Cc:  
Subject: Re: kern/85106: The ICH7 smb interface is not recognised
Date: Tue, 30 Aug 2005 17:01:56 +0200 (CEST)

    Hi,
 
    I've been able to verify that the suggested patch for ICH6
    does work.  I tested it on my Samsung X20 1600-V notebook
    which uses the i915GM chipset + 82801FB (ICH6).
 
    Without the patch (plain RELENG_6 == 6.0-BETA3), I got:
 
 pci0: <serial bus, SMBus> at device 31.3 (no driver attached)
 
    With the patch, I get:
 
 ichsmb0: <Intel 82801FB (ICH6) SMBus controller> port 0x18a0-0x18bf irq 19 at device 31.3 on pci0
 ichsmb0: [GIANT-LOCKED]
 smbus0: <System Management Bus> on ichsmb0
 smb0: <SMBus generic I/O> on smbus0
 
    Below is the complete patch.  It applies to all of HEAD,
    RELENG_6, RELENG_5 and RELENG_4.
 
    Best regards
       Oliver
 
 
 --- src/sys/dev/ichsmb/ichsmb_pci.c.orig        Fri Aug 19 20:38:55 2005
 +++ src/sys/dev/ichsmb/ichsmb_pci.c     Tue Aug 30 16:59:08 2005
 @@ -41,7 +41,8 @@
 
  /*
   * Support for the SMBus controller logical device which is part of the
 - * Intel 81801AA/AB/BA/CA/DC/EB (ICH/ICH[02345]) I/O controller hub chips.
 + * Intel 81801AA/AB/BA/CA/DC/EB/FB/GB (ICH/ICH[0234567])
 + * I/O controller hub chips.
   */
 
  #include <sys/param.h>
 @@ -73,6 +74,8 @@
  #define ID_82801CA			0x24838086
  #define ID_82801DC			0x24C38086
  #define ID_82801EB			0x24D38086
 +#define ID_82801FB			0x266a8086
 +#define ID_82801GB			0x27da8086
  #define ID_6300ESB			0x25a48086
 
  #define PCIS_SERIALBUS_SMBUS_PROGIF	0x00
 @@ -142,6 +145,12 @@
 		break;
 	case ID_82801EB:
 		device_set_desc(dev, "Intel 82801EB (ICH5) SMBus controller");
 +		break;
 +	case ID_82801FB:
 +		device_set_desc(dev, "Intel 82801FB (ICH6) SMBus controller");
 +		break;
 +	case ID_82801GB:
 +		device_set_desc(dev, "Intel 82801GB (ICH7) SMBus controller");
 		break;
 	case ID_6300ESB:
 		device_set_desc(dev, "Intel 6300ESB (ICH) SMBus controller");
 
 
 
 -- 
 Oliver Fromme,  secnetix GmbH & Co. KG, Marktplatz 29, 85567 Grafing
 Any opinions expressed in this message may be personal to the author
 and may not necessarily reflect the opinions of secnetix in any way.
 
 "I learned Java 3 years before Python.  It was my language of
 choice.  It took me two weekends with Python before I was more
 productive with it than with Java." -- Anthony Roberts

From: Mike Jakubik <mikej@rogers.com>
To: bug-followup@FreeBSD.org,  arthur.hartwig@nokia.com
Cc:  
Subject: Re: kern/85106: The ICH7 smb interface is not recognised
Date: Thu, 27 Jul 2006 13:47:33 -0400

 Here are my results with a Supermicro PDSMi MB (Intel E7230 (Mukilteo) 
 Smithfield chipset,  ICH7R + PXH-V + Intel 82573V)
 
 7.0-CURRENT #0: Thu Jul 27 12:28:34 EDT 2006.
 
 The controller is detected:
 
 ichsmb0: <Intel 82801GB (ICH7) SMBus controller> port 0x1100-0x111f irq 
 19 at device 31.3 on pci0
 ichsmb0: [GIANT-LOCKED]
 smbus0: <System Management Bus> on ichsmb0
 smb0: <SMBus generic I/O> on smbus0
 
 However communication does not seem to work:
 
 # smbmsg -p
 Probing for devices on /dev/smb0:
 Device @0x30: rw
 Device @0x32: rw
 ^C
 
 ichsmb0: device timeout, status=0x41
 ichsmb0: device timeout, status=0x41
 ichsmb0: device timeout, status=0x41
 
 I also tried running mbmon using SMB, however this is the result:
 
 # mbmon -S
 No SMBus HWM available!!
 InitMBInfo: Unknown error: 0
 
 Without any options, i get bogus temp values:
 
 # mbmon
 
 Temp.= 208.0,  0.0,  0.0; Rot.=    0,    0,    0
 Vcore = 3.62, 3.62; Volt. = 3.62, 5.21, 11.80,   1.13,  2.09
 
 

From: Arthur Hartwig <Arthur.Hartwig@nokia.com>
To: ext Mike Jakubik <mikej@rogers.com>
Cc: bug-followup@FreeBSD.org
Subject: Re: kern/85106: The ICH7 smb interface is not recognised
Date: Fri, 28 Jul 2006 11:33:31 +1000

 G'day Mike,
     Thanks for your attention. I was interested in this issue because I 
 noticed it on a Gigabyte GA-8I945-P motherboard. This particular 
 motherboard has the environmental sensors accessed over the ISA bus to a 
 ITE 8712 super-io chip rather than the ICH7 but the ICH7 support was of 
 interest to me because a system under design at the time was going to to 
 use the ICH7. That plan was revised and the system is using the 5000P 
 chipset instead.
 
 The smb support in FreeBSD is a bit inconsistent. The intpm driver 
 (seems to be the earliest smbus driver) treats a user supplied smbus 
 address as 8 bits with the low order bit the read/write bit. (This also 
 seems to be the address view of the smbmsg utility, at least as stated 
 in the man page.) However the other drivers for smb hardware that I 
 looked at all take the user supplied address as a 7-bit address and 
 shift it left one bit before giving it to the hardware. The left shit 
 allows for the read/write bit. This seems incompatible with the smbmsg 
 utility.
 
 In probing the smb bus I have found the practice most likely to succeed 
 is to use a quick write (no data supplied in that message) and see if 
 anything responds (acknowledges). My experience is that its dangerous to 
 probe 7-bit addresses below 0x10 and above 0x78. Accesses outside that 
 address range seem to hit something that locks up the controller and 
 recovery seems to be possible only through a system restart. I admit I 
 have tried only about 3 or 4 different motherboards, a poor sample size 
 from which to generalise.
 
 Arthur
 
 
 ext Mike Jakubik wrote:
 > Here are my results with a Supermicro PDSMi MB (Intel E7230 (Mukilteo) 
 > Smithfield chipset,  ICH7R + PXH-V + Intel 82573V)
 >
 > 7.0-CURRENT #0: Thu Jul 27 12:28:34 EDT 2006.
 >
 > The controller is detected:
 >
 > ichsmb0: <Intel 82801GB (ICH7) SMBus controller> port 0x1100-0x111f 
 > irq 19 at device 31.3 on pci0
 > ichsmb0: [GIANT-LOCKED]
 > smbus0: <System Management Bus> on ichsmb0
 > smb0: <SMBus generic I/O> on smbus0
 >
 > However communication does not seem to work:
 >
 > # smbmsg -p
 > Probing for devices on /dev/smb0:
 > Device @0x30: rw
 > Device @0x32: rw
 > ^C
 >
 > ichsmb0: device timeout, status=0x41
 > ichsmb0: device timeout, status=0x41
 > ichsmb0: device timeout, status=0x41
 >
 > I also tried running mbmon using SMB, however this is the result:
 >
 > # mbmon -S
 > No SMBus HWM available!!
 > InitMBInfo: Unknown error: 0
 >
 > Without any options, i get bogus temp values:
 >
 > # mbmon
 >
 > Temp.= 208.0,  0.0,  0.0; Rot.=    0,    0,    0
 > Vcore = 3.62, 3.62; Volt. = 3.62, 5.21, 11.80,   1.13,  2.09
 >
 >
 
Responsible-Changed-From-To: freebsd-bugs->remko 
Responsible-Changed-By: remko 
Responsible-Changed-When: Tue Feb 20 14:49:37 UTC 2007 
Responsible-Changed-Why:  
I'll take it. 

http://www.freebsd.org/cgi/query-pr.cgi?pr=85106 
State-Changed-From-To: open->patched 
State-Changed-By: remko 
State-Changed-When: Mon Nov 26 19:58:03 UTC 2007 
State-Changed-Why:  
Patched in -HEAD 

http://www.freebsd.org/cgi/query-pr.cgi?pr=85106 

From: dfilter@FreeBSD.ORG (dfilter service)
To: bug-followup@FreeBSD.org
Cc:  
Subject: Re: kern/85106: commit references a PR
Date: Mon, 26 Nov 2007 19:55:03 +0000 (UTC)

 remko       2007-11-26 19:54:54 UTC
 
   FreeBSD src repository
 
   Modified files:
     sys/dev/ichsmb       ichsmb_pci.c 
   Log:
   Add the Intel 82801FB (ICH6) SMBus controller and the
   Intel 82801GB (ICH7) SMBus controller.
   
   PR:             85106 [1]
   PR:             99663 [2]
   Approved by:    imp (mentor), jhb
   Submitted by:   Oliver Fromme <olli at lurza.secnetix dot de>, [1]
                   Arthur Hartwig <arthur dot hartwig at nokia dot com>, [1]
                   Lowell Gilbert <lgfbsd at be-well dot ilk dot org> [2]@
   MFC After:      3 days
   
   Revision  Changes    Path
   1.20      +8 -0      src/sys/dev/ichsmb/ichsmb_pci.c
 _______________________________________________
 cvs-all@freebsd.org mailing list
 http://lists.freebsd.org/mailman/listinfo/cvs-all
 To unsubscribe, send any mail to "cvs-all-unsubscribe@freebsd.org"
 

From: dfilter@FreeBSD.ORG (dfilter service)
To: bug-followup@FreeBSD.org
Cc:  
Subject: Re: kern/85106: commit references a PR
Date: Sun,  2 Dec 2007 08:42:21 +0000 (UTC)

 remko       2007-12-02 08:42:16 UTC
 
   FreeBSD src repository
 
   Modified files:        (Branch: RELENG_7)
     sys/dev/ichsmb       ichsmb_pci.c 
     share/man/man4       ichsmb.4 
   Log:
   MFC rev 1.8 ichsmb.4
   
     Add information about the ICH6 and ICH7 being supported since recently.
   
   MFC rev 1.20 ichsmb_pci.c
   
     Add the Intel 82801FB (ICH6) SMBus controller and the
     Intel 82801GB (ICH7) SMBus controller.
   
     PR:             85106 [1]
     PR:             99663 [2]
     Approved by:    imp (mentor), jhb
     Submitted by:   Oliver Fromme <olli at lurza.secnetix dot de>, [1]
                     Arthur Hartwig <arthur dot hartwig at nokia dot com>, [1]
                     Lowell Gilbert <lgfbsd at be-well dot ilk dot org> [2]@
     MFC After:      3 days
   
   Approved by:    re (hrs), imp (mentor, implicit)
   
   Revision  Changes    Path
   1.7.10.1  +3 -3      src/share/man/man4/ichsmb.4
   1.19.2.1  +8 -0      src/sys/dev/ichsmb/ichsmb_pci.c
 _______________________________________________
 cvs-all@freebsd.org mailing list
 http://lists.freebsd.org/mailman/listinfo/cvs-all
 To unsubscribe, send any mail to "cvs-all-unsubscribe@freebsd.org"
 

From: dfilter@FreeBSD.ORG (dfilter service)
To: bug-followup@FreeBSD.org
Cc:  
Subject: Re: kern/85106: commit references a PR
Date: Sun,  2 Dec 2007 08:56:42 +0000 (UTC)

 remko       2007-12-02 08:56:37 UTC
 
   FreeBSD src repository
 
   Modified files:        (Branch: RELENG_6)
     sys/dev/ichsmb       ichsmb_pci.c 
     share/man/man4       ichsmb.4 
   Log:
   MFC rev 1.8 ichsmb.4
   
     Add information about the ICH6 and ICH7 being supported since recently.
   
   MFC rev 1.20 ichsmb_pci.c
   
     Add the Intel 82801FB (ICH6) SMBus controller and the
     Intel 82801GB (ICH7) SMBus controller.
   
     PR:             85106 [1]
     PR:             99663 [2]
     Approved by:    imp (mentor), jhb
     Submitted by:   Oliver Fromme <olli at lurza.secnetix dot de>, [1]
                     Arthur Hartwig <arthur dot hartwig at nokia dot com>, [1]
                     Lowell Gilbert <lgfbsd at be-well dot ilk dot org> [2]@
     MFC After:      3 days
   
   Approved by:    re (hrs), imp (mentor, implicit)
   
   Revision  Changes    Path
   1.7.2.1   +3 -3      src/share/man/man4/ichsmb.4
   1.16.2.2  +8 -0      src/sys/dev/ichsmb/ichsmb_pci.c
 _______________________________________________
 cvs-all@freebsd.org mailing list
 http://lists.freebsd.org/mailman/listinfo/cvs-all
 To unsubscribe, send any mail to "cvs-all-unsubscribe@freebsd.org"
 

From: dfilter@FreeBSD.ORG (dfilter service)
To: bug-followup@FreeBSD.org
Cc:  
Subject: Re: kern/85106: commit references a PR
Date: Sun,  2 Dec 2007 09:05:42 +0000 (UTC)

 remko       2007-12-02 09:05:38 UTC
 
   FreeBSD src repository
 
   Modified files:        (Branch: RELENG_6_3)
     sys/dev/ichsmb       ichsmb_pci.c 
     share/man/man4       ichsmb.4 
   Log:
   MFC rev 1.8 ichsmb.4
   
     Add information about the ICH6 and ICH7 being supported since recently.
   
   MFC rev 1.20 ichsmb_pci.c
   
     Add the Intel 82801FB (ICH6) SMBus controller and the
     Intel 82801GB (ICH7) SMBus controller.
   
     PR:             85106 [1]
     PR:             99663 [2]
     Approved by:    imp (mentor), jhb
     Submitted by:   Oliver Fromme <olli at lurza.secnetix dot de>, [1]
                     Arthur Hartwig <arthur dot hartwig at nokia dot com>, [1]
                     Lowell Gilbert <lgfbsd at be-well dot ilk dot org> [2]@
     MFC After:      3 days
   
   Approved by:    re (hrs), imp (mentor, implicit)
   
   Revision      Changes    Path
   1.7.12.1      +3 -3      src/share/man/man4/ichsmb.4
   1.16.2.1.8.1  +8 -0      src/sys/dev/ichsmb/ichsmb_pci.c
 _______________________________________________
 cvs-all@freebsd.org mailing list
 http://lists.freebsd.org/mailman/listinfo/cvs-all
 To unsubscribe, send any mail to "cvs-all-unsubscribe@freebsd.org"
 
State-Changed-From-To: patched->closed 
State-Changed-By: remko 
State-Changed-When: Sun Dec 2 09:10:46 UTC 2007 
State-Changed-Why:  
Committed to all relevant branches! thanks! 

http://www.freebsd.org/cgi/query-pr.cgi?pr=85106 
>Unformatted:
