From never@mile.mirotel.net  Thu Aug  4 12:01:36 2005
Return-Path: <never@mile.mirotel.net>
Received: from mx1.FreeBSD.org (mx1.freebsd.org [216.136.204.125])
	by hub.freebsd.org (Postfix) with ESMTP id 696ED16A420
	for <FreeBSD-gnats-submit@freebsd.org>; Thu,  4 Aug 2005 12:01:36 +0000 (GMT)
	(envelope-from never@mile.mirotel.net)
Received: from mile.mirotel.net (mile.mirotel.net [194.125.225.114])
	by mx1.FreeBSD.org (Postfix) with ESMTP id 36B8B43D55
	for <FreeBSD-gnats-submit@freebsd.org>; Thu,  4 Aug 2005 12:01:34 +0000 (GMT)
	(envelope-from never@mile.mirotel.net)
Received: from mile.mirotel.net (localhost.mirotel.net [127.0.0.1])
	by mile.mirotel.net (8.13.3/8.13.3) with ESMTP id j74C1XI0007758
	for <FreeBSD-gnats-submit@freebsd.org>; Thu, 4 Aug 2005 15:01:33 +0300 (EEST)
	(envelope-from never@mile.mirotel.net)
Received: (from never@localhost)
	by mile.mirotel.net (8.13.3/8.13.1/Submit) id j74C1X5U007757;
	Thu, 4 Aug 2005 15:01:33 +0300 (EEST)
	(envelope-from never)
Message-Id: <200508041201.j74C1X5U007757@mile.mirotel.net>
Date: Thu, 4 Aug 2005 15:01:33 +0300 (EEST)
From: Alexandr Kovalenko <never@nevermind.kiev.ua>
Reply-To: Alexandr Kovalenko <never@nevermind.kiev.ua>
To: FreeBSD-gnats-submit@freebsd.org
Cc:
Subject: PF_QNAME_SIZE is too small for common use
X-Send-Pr-Version: 3.113
X-GNATS-Notify:

>Number:         84544
>Category:       kern
>Synopsis:       [pf] [patch] pfvar.h: PF_QNAME_SIZE is too small for common use
>Confidential:   no
>Severity:       serious
>Priority:       medium
>Responsible:    dhartmei
>State:          closed
>Quarter:        
>Keywords:       
>Date-Required:  
>Class:          change-request
>Submitter-Id:   current-users
>Arrival-Date:   Thu Aug 04 12:10:17 GMT 2005
>Closed-Date:    Tue Oct 17 14:43:28 GMT 2006
>Last-Modified:  Tue Oct 17 14:43:28 GMT 2006
>Originator:     Alexandr Kovalenko
>Release:        FreeBSD 6.0-BETA1
>Organization:
Mirotel ISP, http://mirotel.net/
>Environment:
System: FreeBSD releng6.xxx.net 6.0-BETA1 FreeBSD 6.0-BETA1 #0: Tue Aug  2 16:08:13 EEST 2005     root@releng6.xxx.net:/usr/obj/usr/src/sys/releng6  i386

>Description:
	PF_QNAME_SIZE is too small for real-life use - it is only 16 bytes long.
>How-To-Repeat:
	Take a look at
	/usr/src/sys/contrib/pf/net/pfvar.h (rev.1.12 as for now for HEAD)
	line 584 
>Fix:
	Increase this variable by applying the following patch:

--- pfvar.h.orig	Thu Aug  4 14:59:48 2005
+++ pfvar.h	Thu Aug  4 15:00:16 2005
@@ -581,7 +581,7 @@
 	union pf_rule_ptr	 skip[PF_SKIP_COUNT];
 #define PF_RULE_LABEL_SIZE	 64
 	char			 label[PF_RULE_LABEL_SIZE];
-#define PF_QNAME_SIZE		 16
+#define PF_QNAME_SIZE		 64
 	char			 ifname[IFNAMSIZ];
 	char			 qname[PF_QNAME_SIZE];
 	char			 pqname[PF_QNAME_SIZE];
>Release-Note:
>Audit-Trail:
Responsible-Changed-From-To: freebsd-bugs->dhartmei 
Responsible-Changed-By: glebius 
Responsible-Changed-When: Thu Aug 11 11:20:32 GMT 2005 
Responsible-Changed-Why:  
Daniel to make decision. 

http://www.freebsd.org/cgi/query-pr.cgi?pr=84544 
State-Changed-From-To: open->analyzed 
State-Changed-By: dhartmei 
State-Changed-When: Tue Aug 16 09:16:58 GMT 2005 
State-Changed-Why:  
Agreed, 16 chars is a little short. We can't change it right now, as this 
is part of the kernel/userland API, but I'll try to increase it as soon 
as possible. Thanks for the report. 

http://www.freebsd.org/cgi/query-pr.cgi?pr=84544 
State-Changed-From-To: analyzed->closed 
State-Changed-By: dhartmei 
State-Changed-When: Tue Oct 17 14:41:10 UTC 2006 
State-Changed-Why:  
The suggested patch (increasing the length to 64 characters) has now 
(finally ;) been committed upstream, and will eventually make its way. 

http://www.freebsd.org/cgi/query-pr.cgi?pr=84544 
>Unformatted:
