From vanmaren@vanmaren.aros.net  Wed Oct 21 09:31:28 1998
Received: from vanmaren.aros.net (vanmaren.aros.net [208.219.24.33])
          by hub.freebsd.org (8.8.8/8.8.8) with ESMTP id JAA06921
          for <FreeBSD-gnats-submit@freebsd.org>; Wed, 21 Oct 1998 09:31:27 -0700 (PDT)
          (envelope-from vanmaren@vanmaren.aros.net)
Received: (from vanmaren@localhost)
	by vanmaren.aros.net (8.9.1/8.9.1) id KAA01422;
	Wed, 21 Oct 1998 10:31:18 -0600 (MDT)
	(envelope-from vanmaren)
Message-Id: <199810211631.KAA01422@vanmaren.aros.net>
Date: Wed, 21 Oct 1998 10:31:18 -0600 (MDT)
From: vanmaren@cs.utah.edu
Reply-To: vanmaren@cs.utah.edu
To: FreeBSD-gnats-submit@freebsd.org
Subject: Aopen AW37Pro isn't supported by Luigi's driver
X-Send-Pr-Version: 3.2

>Number:         8400
>Category:       kern
>Synopsis:       ad1848.c does not recognize the CS4235 chip.
>Confidential:   no
>Severity:       serious
>Priority:       medium
>Responsible:    luigi
>State:          closed
>Quarter:        
>Keywords:       
>Date-Required:  
>Class:          sw-bug
>Submitter-Id:   current-users
>Arrival-Date:   Wed Oct 21 09:40:01 PDT 1998
>Closed-Date:    Mon Dec 14 06:42:52 PST 1998
>Last-Modified:  Mon Dec 14 11:36:20 PST 1998
>Originator:     Kevin Van Maren
>Release:        FreeBSD 3.0-BETA i386
>Organization:
University of Utah, CSL
>Environment:

	Luigi's driver in the latest 3.0 (and 2.2-STABLE)

FreeBSD vanmaren.aros.net 3.0-BETA FreeBSD 3.0-BETA #42: Tue Oct 20 18:21:32 MDT 1998     vanmaren@vanmaren.aros.net:/usr/src/sys/compile/VANMAREN  i386

>Description:

	The sound driver in 2.2-STABLE and 3.0-RELEASE/CURRENT
does not recognize the chip ID used in the new AOPen AW37Pro sound cards

>How-To-Repeat:

	Try to use an AOpen AW37Pro sound card.

>Fix:

Treat the CS4235 as a CS4237, used in the AW35Pro.  This is enough
to play pcm and mp3 files, at least.


Index: ad1848.c
===================================================================
RCS file: /cvs/src/sys/i386/isa/snd/ad1848.c,v
retrieving revision 1.14
diff -u -r1.14 ad1848.c
--- ad1848.c    1998/10/04 16:22:25     1.14
+++ ad1848.c    1998/10/21 16:20:04
@@ -1406,6 +1406,8 @@
        s = "CS4236" ;
     else if ( id == 0x3500630e )
        s = "CS4236B" ;
+    else if ( id == 0x2500630e )
+       s = "CS4235" ;
     else if ( id == 0x3200630e)
        s = "CS4232" ;
     else if ( id == 0x2000a865)
@@ -1416,6 +1418,8 @@
        s = "Yamaha YMF719 OPL-SA3";
     else if (vend_id == 0x8140d315)
        s = "SoundscapeVIVO";
+    else
+       printf("unknown ID: 0x%8x\n", vend_id);
     if (s) {
        struct pnp_cinfo d;
        read_pnp_parms(&d, 0);
@@ -1482,6 +1486,7 @@
            break;
 
        case 0x3700630e:        /* CS4237 */
+       case 0x2500630e:        /* CS4235 */
            tmp_d.bd_id = MD_CS4237 ;
            break;


>Release-Note:
>Audit-Trail:
State-Changed-From-To: open->closed 
State-Changed-By: luigi 
State-Changed-When: Mon Dec 14 06:42:52 PST 1998 
State-Changed-Why:  
committed the proposed fix 


Responsible-Changed-From-To: freebsd-bugs->luigi-bugs 
Responsible-Changed-By: luigi 
Responsible-Changed-When: Mon Dec 14 06:42:52 PST 1998 
Responsible-Changed-Why:  
pcm driver maintainer 
Responsible-Changed-From-To: luigi-bugs->luigi 
Responsible-Changed-By: billf 
Responsible-Changed-When: Mon Dec 14 11:33:03 PST 1998 
Responsible-Changed-Why:  
'responsible' is either a mailing list alias or a freefall account name. 
>Unformatted:
