From matuska@wall2.zoznam.sk  Sat Jul  9 14:54:45 2005
Return-Path: <matuska@wall2.zoznam.sk>
Received: from mx1.FreeBSD.org (mx1.freebsd.org [216.136.204.125])
	by hub.freebsd.org (Postfix) with ESMTP id 99C1F16A41F
	for <FreeBSD-gnats-submit@freebsd.org>; Sat,  9 Jul 2005 14:54:15 +0000 (GMT)
	(envelope-from matuska@wall2.zoznam.sk)
Received: from wall2.zoznam.sk (wall2.zoznam.sk [62.65.179.30])
	by mx1.FreeBSD.org (Postfix) with ESMTP id 0208C43D46
	for <FreeBSD-gnats-submit@freebsd.org>; Sat,  9 Jul 2005 14:54:14 +0000 (GMT)
	(envelope-from matuska@wall2.zoznam.sk)
Received: from wall2.zoznam.sk (localhost [127.0.0.1])
	by wall2.zoznam.sk (8.13.3/8.13.3) with ESMTP id j69EsEQw005027
	for <FreeBSD-gnats-submit@freebsd.org>; Sat, 9 Jul 2005 16:54:14 +0200 (CEST)
	(envelope-from matuska@wall2.zoznam.sk)
Received: (from matuska@localhost)
	by wall2.zoznam.sk (8.13.3/8.13.3/Submit) id j69EsETg005022;
	Sat, 9 Jul 2005 16:54:14 +0200 (CEST)
	(envelope-from matuska)
Message-Id: <200507091454.j69EsETg005022@wall2.zoznam.sk>
Date: Sat, 9 Jul 2005 16:54:14 +0200 (CEST)
From: Martin Matuska <martin@matuska.org>
Reply-To: Martin Matuska <martin@matuska.org>
To: FreeBSD-gnats-submit@freebsd.org
Cc:
Subject: MFC suggestion for if_pfsync.c
X-Send-Pr-Version: 3.113
X-GNATS-Notify:

>Number:         83187
>Category:       kern
>Synopsis:       [pfsync] [patch] MFC suggestion for if_pfsync.c
>Confidential:   no
>Severity:       non-critical
>Priority:       low
>Responsible:    glebius
>State:          closed
>Quarter:        
>Keywords:       
>Date-Required:  
>Class:          change-request
>Submitter-Id:   current-users
>Arrival-Date:   Sat Jul 09 15:00:35 GMT 2005
>Closed-Date:    Thu Nov 03 12:26:30 GMT 2005
>Last-Modified:  Thu Nov 03 12:26:30 GMT 2005
>Originator:     Martin Matuska
>Release:        FreeBSD 5-STABLE i386
>Organization:
>Environment:
>Description:
I suggest MFCing the patch in OpenBSD: src/sys/net/if_pfsync.c rev. 1.41
to RELENG_5 (already included in HEAD)

Comments from OpenBSD cvslog for src/sys/net/if_pfsync.c 1.41:
Set creation timestamps correctly on states learnt by pfsync that are
more than a second old.

>How-To-Repeat:
>Fix:
fixed in OpenBSD: src/sys/net/if_pfsync.c rev. 1.41
already included in HEAD
please MFC to RELENG_5 the following patches from HEAD:
--- src/sys/contrib/pf/net/if_pfsync.c.orig	Sat Jul  9 15:31:31 2005
+++ src/sys/contrib/pf/net/if_pfsync.c	Sat Jul  9 15:56:51 2005
@@ -346,7 +349,7 @@
 
 	bcopy(&sp->rt_addr, &st->rt_addr, sizeof(st->rt_addr));
 #ifdef __FreeBSD__
-	st->creation = ntohl(sp->creation) + time_second;
+	st->creation = time_second - ntohl(sp->creation);
 	st->expire = ntohl(sp->expire) + time_second;
 #else
 	st->creation = ntohl(sp->creation) + time.tv_sec;
>Release-Note:
>Audit-Trail:
Responsible-Changed-From-To: freebsd-bugs->mlaier 
Responsible-Changed-By: simon 
Responsible-Changed-When: Sat Jul 9 18:52:13 GMT 2005 
Responsible-Changed-Why:  
Over to our pf maintainer. 

http://www.freebsd.org/cgi/query-pr.cgi?pr=83187 
Responsible-Changed-From-To: mlaier->glebius 
Responsible-Changed-By: mlaier 
Responsible-Changed-When: Tue Jul 12 18:28:44 GMT 2005 
Responsible-Changed-Why:  
Gelb is in a position to test this, thanks for looking into the issue! 

http://www.freebsd.org/cgi/query-pr.cgi?pr=83187 
State-Changed-From-To: open->closed 
State-Changed-By: glebius 
State-Changed-When: Thu Nov 3 12:26:12 GMT 2005 
State-Changed-Why:  
Committed to RELENG_5. 

http://www.freebsd.org/cgi/query-pr.cgi?pr=83187 
>Unformatted:
