From nobody@FreeBSD.org  Tue Jul  5 15:03:17 2005
Return-Path: <nobody@FreeBSD.org>
Received: from mx1.FreeBSD.org (mx1.freebsd.org [216.136.204.125])
	by hub.freebsd.org (Postfix) with ESMTP id 67B0116A41C
	for <freebsd-gnats-submit@FreeBSD.org>; Tue,  5 Jul 2005 15:03:17 +0000 (GMT)
	(envelope-from nobody@FreeBSD.org)
Received: from www.freebsd.org (www.freebsd.org [216.136.204.117])
	by mx1.FreeBSD.org (Postfix) with ESMTP id 539A143D45
	for <freebsd-gnats-submit@FreeBSD.org>; Tue,  5 Jul 2005 15:03:17 +0000 (GMT)
	(envelope-from nobody@FreeBSD.org)
Received: from www.freebsd.org (localhost [127.0.0.1])
	by www.freebsd.org (8.13.1/8.13.1) with ESMTP id j65F3Hej051520
	for <freebsd-gnats-submit@FreeBSD.org>; Tue, 5 Jul 2005 15:03:17 GMT
	(envelope-from nobody@www.freebsd.org)
Received: (from nobody@localhost)
	by www.freebsd.org (8.13.1/8.13.1/Submit) id j65F3HSe051519;
	Tue, 5 Jul 2005 15:03:17 GMT
	(envelope-from nobody)
Message-Id: <200507051503.j65F3HSe051519@www.freebsd.org>
Date: Tue, 5 Jul 2005 15:03:17 GMT
From: "Yuriy N. Shkandybin" <jura@networks.ru>
To: freebsd-gnats-submit@FreeBSD.org
Subject: nge vlans broken
X-Send-Pr-Version: www-2.3

>Number:         83011
>Category:       kern
>Synopsis:       nge vlans broken
>Confidential:   no
>Severity:       non-critical
>Priority:       medium
>Responsible:    yar
>State:          closed
>Quarter:        
>Keywords:       
>Date-Required:  
>Class:          sw-bug
>Submitter-Id:   current-users
>Arrival-Date:   Tue Jul 05 15:10:20 GMT 2005
>Closed-Date:    Mon Oct 03 08:51:33 GMT 2005
>Last-Modified:  Mon Oct 03 08:51:33 GMT 2005
>Originator:     Yuriy N. Shkandybin
>Release:        CURRENT
>Organization:
NetAMS
>Environment:
FreeBSD ftp 6.0-CURRENT FreeBSD 6.0-CURRENT #0: Tue Jul  5 14:47:32 MSD 2005     root@:/usr/obj/usr/src/sys/FTP  i386    
>Description:
There is
nge0: flags=8843<UP,BROADCAST,RUNNING,SIMPLEX,MULTICAST> mtu 1504
        options=13<RXCSUM,TXCSUM,VLAN_HWTAGGING>
        inet 10.0.0.2 netmask 0xffffff80 broadcast 10.0.0.127
        ether 00:40:f4:47:be:10
        media: Ethernet autoselect (1000baseSX <full-duplex>)
        status: active
vlan100: flags=8843<UP,BROADCAST,RUNNING,SIMPLEX,MULTICAST> mtu 1500
        inet 10.0.1.1 netmask 0xffffff00 broadcast 10.0.1.255
        ether 00:40:f4:47:be:10
        media: Ethernet autoselect (1000baseSX <full-duplex>)
        status: active
        vlan: 100 parent interface: nge0

This config is working with FreeBSD-5 with applied patches HEAD  1.70-1.72 &#1090;&#1086; if_nge.c (otherwise core dumps)
And vlans completely broken in HEAD.

But native nge0 interface is working.



>How-To-Repeat:
kldload if_nge
ifconfig nge0 mtu 1504 up
Provide dot1q trunk (there is vlan 100 with ip 10.0.1.1/24 for example)
ifconfig vlan100 create
ifconfig vlan 100 vlan 100 vlandev nge0 inet 10.0.1.2 netmask 255.255.255.0

ping 10.0.1.1

>Fix:
      
>Release-Note:
>Audit-Trail:

From: "Yuriy N. Shkandybin" <jura@networks.ru>
To: <bug-followup@FreeBSD.org>,
	"Yuriy N. Shkandybin" <jura@networks.ru>
Cc: <freebsd-net@freebsd.org>
Subject: Re: kern/83011: nge vlans broken
Date: Fri, 8 Jul 2005 17:58:58 +0400

 I've invistigated that m_head mbuf doesn't have M_VLANTAG when performing 
 VLAN_OUTPUT()
 
 next diff for /usr/src/sys/net/if_vlan_var.h make it work:
 --- 1.h Fri Jul  8 17:34:31 2005
 +++ if_vlan_var.h       Fri Jul  8 17:35:53 2005
 @@ -111,7 +111,7 @@
  } while (0)
 
  #define        VLAN_OUTPUT_TAG(_ifp, _m)                               \
 -       ((_m)->m_flags & M_VLANTAG ?                            \
 +       ((_ifp)->if_nvlans != 0 ?                               \
                 m_tag_locate((_m), MTAG_VLAN, MTAG_VLAN_TAG, NULL) : NULL)
  #define        VLAN_TAG_VALUE(_mt)     (*(u_int *)((_mt)+1))
  #endif /* _KERNEL */
 
 
 Actually this is partial backout ru@ commit
 http://www.freebsd.org/cgi/cvsweb.cgi/src/sys/net/if_vlan_var.h.diff?r1=1.20&r2=1.21&f=h
 
 Since it's not adressed to if_nge itself, so it's possible same problems for 
 another interfaces.
 
 Jura
 
 
State-Changed-From-To: open->feedback 
State-Changed-By: yar 
State-Changed-When: Mon Oct 3 02:29:09 GMT 2005 
State-Changed-Why:  
This problem is believed to be fixed in if_vlan.c rev. 1.82, 
which has been merged to RELENG_6 as well.  Would you mind 
testing if it works in your case?  Thanks! 


Responsible-Changed-From-To: freebsd-bugs->yar 
Responsible-Changed-By: yar 
Responsible-Changed-When: Mon Oct 3 02:29:09 GMT 2005 
Responsible-Changed-Why:  
My favourite area. 

http://www.freebsd.org/cgi/query-pr.cgi?pr=83011 

From: "Yuriy N. Shkandybin" <jura@networks.ru>
To: <bug-followup@FreeBSD.org>,
	"Yuriy N. Shkandybin" <jura@networks.ru>
Cc:  
Subject: Re: kern/83011: nge vlans broken
Date: Mon, 3 Oct 2005 10:41:33 +0400

 Sure i've tested and it's definitely fixed.
 I've got another bug with this driver
 See PR 86618
 
 Jura
State-Changed-From-To: feedback->closed 
State-Changed-By: yar 
State-Changed-When: Mon Oct 3 08:50:02 GMT 2005 
State-Changed-Why:  
It has been confirmed that the bug no longer exists. 

http://www.freebsd.org/cgi/query-pr.cgi?pr=83011 
>Unformatted:
