From sand@zunet.ru  Mon Jun 13 07:59:20 2005
Return-Path: <sand@zunet.ru>
Received: from mx1.FreeBSD.org (mx1.freebsd.org [216.136.204.125])
	by hub.freebsd.org (Postfix) with ESMTP id 26CCF16A41C
	for <FreeBSD-gnats-submit@freebsd.org>; Mon, 13 Jun 2005 07:59:20 +0000 (GMT)
	(envelope-from sand@zunet.ru)
Received: from mail.zunet.ru (mail.zunet.ru [217.67.117.68])
	by mx1.FreeBSD.org (Postfix) with ESMTP id 4D05643D1D
	for <FreeBSD-gnats-submit@freebsd.org>; Mon, 13 Jun 2005 07:59:19 +0000 (GMT)
	(envelope-from sand@zunet.ru)
Received: (qmail 2008 invoked from network); 13 Jun 2005 08:09:24 -0000
Received: from mail.zunet.ru (HELO zunet.ru) (217.67.117.68)
  by mail.zunet.ru with SMTP; 13 Jun 2005 08:09:24 -0000
Received: (qmail 2003 invoked by uid 1002); 13 Jun 2005 08:09:24 -0000
Message-Id: <20050613080924.2002.qmail@zunet.ru>
Date: 13 Jun 2005 08:09:24 -0000
From: Stikheev Andrew <sand@zunet.ru>
Reply-To: Stikheev Andrew <sand@zunet.ru>
To: FreeBSD-gnats-submit@freebsd.org
Cc:
Subject: [patch] ng_fec interface - problems with counting input bytes
X-Send-Pr-Version: 3.113
X-GNATS-Notify:

>Number:         82189
>Category:       kern
>Synopsis:       [netgraph] [patch] ng_fec interface - problems with counting input bytes
>Confidential:   no
>Severity:       non-critical
>Priority:       low
>Responsible:    ru
>State:          closed
>Quarter:        
>Keywords:       
>Date-Required:  
>Class:          sw-bug
>Submitter-Id:   current-users
>Arrival-Date:   Mon Jun 13 08:00:42 GMT 2005
>Closed-Date:    Mon Sep 18 15:38:40 GMT 2006
>Last-Modified:  Mon Sep 18 15:38:40 GMT 2006
>Originator:     Stikheev Andrew
>Release:        FreeBSD 6.0-CURRENT i386
>Organization:
>Environment:
System: FreeBSD sand.zuzino.mipt.ru 6.0-CURRENT FreeBSD 6.0-CURRENT #0: Sun Jun 12 02:16:10 MSD 2005 sand@sand.zuzino.mipt.ru:/usr/obj/usr/src/sys/MYKERNEL i386


	
>Description:
On fec interface number of input bytes  == 2 * real input bytes.
On interfaces in a bundle input bytes are zero all time.
>How-To-Repeat:
	
>Fix:
--- ng_fec.c    Mon Jun 13 10:24:25 2005
+++ ng_fec.c.new        Mon Jun 13 11:01:31 2005
@@ -815,7 +815,7 @@ ng_fec_input(struct ifnet *ifp, struct m
        /* Convince the system that this is our frame. */
        m0->m_pkthdr.rcvif = bifp;
        bifp->if_ipackets++;
-       bifp->if_ibytes += m0->m_pkthdr.len + sizeof(struct ether_header);
+       ifp->if_ibytes += m0->m_pkthdr.len;
 
        (*bifp->if_input)(bifp, m0);

>Release-Note:
>Audit-Trail:
State-Changed-From-To: open->patched 
State-Changed-By: ru 
State-Changed-When: Fri Sep 15 20:14:27 UTC 2006 
State-Changed-Why:  
Patch applied, thanks! 


Responsible-Changed-From-To: freebsd-bugs->ru 
Responsible-Changed-By: ru 
Responsible-Changed-When: Fri Sep 15 20:14:27 UTC 2006 
Responsible-Changed-Why:  

http://www.freebsd.org/cgi/query-pr.cgi?pr=82189 

From: dfilter@FreeBSD.ORG (dfilter service)
To: bug-followup@FreeBSD.org
Cc:  
Subject: Re: kern/82189: commit references a PR
Date: Fri, 15 Sep 2006 20:18:01 +0000 (UTC)

 ru          2006-09-15 20:17:45 UTC
 
   FreeBSD src repository
 
   Modified files:
     sys/netgraph         ng_fec.c 
   Log:
   Fix input byte counting.  Now the sum of the ipackets/ibytes counters
   of individual interfaces should match the ipackets/ibytes counter of
   the aggregate (FEC) interface.
   
   PR:             kern/82189
   Submitted by:   Stikheev Andrew <sand AT zunet DOT ru>
   MFC after:      3 days
   
   Revision  Changes    Path
   1.29      +8 -2      src/sys/netgraph/ng_fec.c
 _______________________________________________
 cvs-all@freebsd.org mailing list
 http://lists.freebsd.org/mailman/listinfo/cvs-all
 To unsubscribe, send any mail to "cvs-all-unsubscribe@freebsd.org"
 
State-Changed-From-To: patched->closed 
State-Changed-By: ru 
State-Changed-When: Mon Sep 18 15:38:23 UTC 2006 
State-Changed-Why:  
Fixed in 6.2-PRERELEASE. 

http://www.freebsd.org/cgi/query-pr.cgi?pr=82189 
>Unformatted:
