From nobody@FreeBSD.org  Fri Jun 10 10:26:23 2005
Return-Path: <nobody@FreeBSD.org>
Received: from mx1.FreeBSD.org (mx1.freebsd.org [216.136.204.125])
	by hub.freebsd.org (Postfix) with ESMTP id 32A7716A41C
	for <freebsd-gnats-submit@FreeBSD.org>; Fri, 10 Jun 2005 10:26:23 +0000 (GMT)
	(envelope-from nobody@FreeBSD.org)
Received: from www.freebsd.org (www.freebsd.org [216.136.204.117])
	by mx1.FreeBSD.org (Postfix) with ESMTP id 151D943D55
	for <freebsd-gnats-submit@FreeBSD.org>; Fri, 10 Jun 2005 10:26:23 +0000 (GMT)
	(envelope-from nobody@FreeBSD.org)
Received: from www.freebsd.org (localhost [127.0.0.1])
	by www.freebsd.org (8.13.1/8.13.1) with ESMTP id j5AAQKiv088769
	for <freebsd-gnats-submit@FreeBSD.org>; Fri, 10 Jun 2005 10:26:20 GMT
	(envelope-from nobody@www.freebsd.org)
Received: (from nobody@localhost)
	by www.freebsd.org (8.13.1/8.13.1/Submit) id j5AAQKcW088766;
	Fri, 10 Jun 2005 10:26:20 GMT
	(envelope-from nobody)
Message-Id: <200506101026.j5AAQKcW088766@www.freebsd.org>
Date: Fri, 10 Jun 2005 10:26:20 GMT
From: "Johannes W." <hnaz@we-are-root.org>
To: freebsd-gnats-submit@FreeBSD.org
Subject: fm801.c fix
X-Send-Pr-Version: www-2.3

>Number:         82107
>Category:       kern
>Synopsis:       [patch] fm801.c fix
>Confidential:   no
>Severity:       non-critical
>Priority:       low
>Responsible:    sound
>State:          closed
>Quarter:        
>Keywords:       
>Date-Required:  
>Class:          sw-bug
>Submitter-Id:   current-users
>Arrival-Date:   Fri Jun 10 10:30:08 GMT 2005
>Closed-Date:    Sun Jun 26 20:52:37 GMT 2005
>Last-Modified:  Sun Jun 26 20:52:37 GMT 2005
>Originator:     Johannes W.
>Release:        5.4-RELEASE
>Organization:
>Environment:
FreeBSD neurogen.fuck.this.shit 5.4-RELEASE-p2 FreeBSD 5.4-RELEASE-p2 #1: Fri Jun 10 11:01:57 CEST 2005     root@neurogen.fuck.this.shit:/usr/src/sys/i386/compile/NEUROGEN  i386

>Description:
I have written a small patch so that the fortemedia driver 'fm801.c' supports all cards that use that driver. i have a card with ac97 codec and it is tunerless [at least i think that] and bus_space_read_1(st, sh, 0x28) returns not 0, but 0x80.
The patch simply checks for both results, cause on both returns the driver should be used.
>How-To-Repeat:
      
>Fix:
see patch
>Release-Note:
>Audit-Trail:

From: Johannes Weiner <hnaz@tutorialzone.de>
To: bug-followup@freebsd.org
Cc:  
Subject: Re: misc/82107: fm801.c fix
Date: Fri, 10 Jun 2005 12:40:41 +0200

 --0eh6TmSyL6TZE2Uz
 Content-Type: text/plain; charset=us-ascii
 Content-Disposition: inline
 
 Here the patch:
 
 ########################################
 --- fm801.c.old Fri Jun 10 10:37:52 2005
 +++ fm801.c     Fri Jun 10 10:37:29 2005
 @@ -737,7 +737,8 @@
                  * power-on value should be `0', while on AC97-less
                  * tuner
                  * card (SF64-PCR) it was 0x80.
                  */
 -               if (bus_space_read_1(st, sh, 0x28) == 0) {
 +               int busrres = bus_space_read_1(st, sh, 0x28);
 +               if (busrres == 0 || busrres == 0x80) {
                         device_set_desc(dev,
                             "Forte Media FM801 Audio Controller");
                         result = 0;
 
 ########################################
 
 Hope that helps. The list is expandable, i heard that more exitcodes are
 known like 128 instead of 0x80 or 0.
 
 Hannes.
 
 --0eh6TmSyL6TZE2Uz
 Content-Type: application/pgp-signature
 Content-Disposition: inline
 
 -----BEGIN PGP SIGNATURE-----
 Version: GnuPG v1.4.0 (FreeBSD)
 
 iD8DBQFCqW4o1heCLyOG8GcRAmyvAJ4p1DUWPuba4NEBqp4gaolCgOc6yACeLk57
 NEPhTWievAN1N/QIn5m2gHU=
 =6pwm
 -----END PGP SIGNATURE-----
 
 --0eh6TmSyL6TZE2Uz--
Responsible-Changed-From-To: freebsd-bugs->sound 
Responsible-Changed-By: linimon 
Responsible-Changed-When: Fri Jun 10 19:30:15 GMT 2005 
Responsible-Changed-Why:  
Fix up and assign. 

http://www.freebsd.org/cgi/query-pr.cgi?pr=82107 

From: Eric Anholt <eta@lclark.edu>
To: gnats <freebsd-gnats-submit@FreeBSD.ORG>
Cc:  
Subject: Re: kern/82107
Date: Thu, 23 Jun 2005 12:47:31 -0700

 --=-Mfbapxw6W2CzHY3gTaML
 Content-Type: text/plain
 Content-Transfer-Encoding: 7bit
 
 The patch at:
 http://people.freebsd.org/~anholt/fm801-mfc.diff
 and attached, is an MFC of revisions 1.24 and 1.25 of fm801.c in
 -current.  Could you apply and verify that they work for you?
 
 -- 
 Eric Anholt                                     eta@lclark.edu
 http://people.freebsd.org/~anholt/              anholt@FreeBSD.org
 
 --=-Mfbapxw6W2CzHY3gTaML
 Content-Disposition: attachment; filename=fm801-mfc.diff
 Content-Transfer-Encoding: base64
 Content-Type: text/x-patch; name=fm801-mfc.diff; charset=ISO-8859-1
 
 SW5kZXg6IGRldi9zb3VuZC9wY2kvZm04MDEuYw0KPT09PT09PT09PT09PT09PT09PT09PT09PT09
 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PQ0KUkNTIGZpbGU6IC9ob21l
 L25jdnMvc3JjL3N5cy9kZXYvc291bmQvcGNpL2ZtODAxLmMsdg0KcmV0cmlldmluZyByZXZpc2lv
 biAxLjIzLjIuMg0KZGlmZiAtdSAtcjEuMjMuMi4yIGZtODAxLmMNCi0tLSBkZXYvc291bmQvcGNp
 L2ZtODAxLmMJMzAgSmFuIDIwMDUgMDE6MDA6MDQgLTAwMDAJMS4yMy4yLjINCisrKyBkZXYvc291
 bmQvcGNpL2ZtODAxLmMJMjMgSnVuIDIwMDUgMTk6NDM6NDkgLTAwMDANCkBAIC03MDEsNDkgKzcw
 MSwxMSBAQA0KIHN0YXRpYyBpbnQNCiBmbTgwMV9wY2lfcHJvYmUoIGRldmljZV90IGRldiApDQog
 ew0KLQl1X2ludDMyX3QgZGF0YTsNCi0JaW50IGlkLCByZWd0eXBlLCByZWdpZCwgcmVzdWx0Ow0K
 LQlzdHJ1Y3QgcmVzb3VyY2UgKnJlZzsNCi0JYnVzX3NwYWNlX3RhZ190IHN0Ow0KLQlidXNfc3Bh
 Y2VfaGFuZGxlX3Qgc2g7DQorCWludCBpZDsNCiANCi0JcmVzdWx0ID0gRU5YSU87DQotCQ0KIAlp
 ZiAoKGlkID0gcGNpX2dldF9kZXZpZChkZXYpKSA9PSBQQ0lfREVWSUNFX0ZPUlRFTUVESUExICkg
 ew0KLQkJZGF0YSA9IHBjaV9yZWFkX2NvbmZpZyhkZXYsIFBDSVJfQ09NTUFORCwgMik7DQotCQlk
 YXRhIHw9IChQQ0lNX0NNRF9QT1JURU58UENJTV9DTURfQlVTTUFTVEVSRU4pOw0KLQkJcGNpX3dy
 aXRlX2NvbmZpZyhkZXYsIFBDSVJfQ09NTUFORCwgZGF0YSwgMik7DQotCQlkYXRhID0gcGNpX3Jl
 YWRfY29uZmlnKGRldiwgUENJUl9DT01NQU5ELCAyKTsNCi0NCi0JCXJlZ2lkID0gUENJUl9CQVIo
 MCk7DQotCQlyZWd0eXBlID0gU1lTX1JFU19JT1BPUlQ7DQotCQlyZWcgPSBidXNfYWxsb2NfcmVz
 b3VyY2VfYW55KGRldiwgcmVndHlwZSwgJnJlZ2lkLCBSRl9BQ1RJVkUpOw0KLQ0KLQkJaWYgKHJl
 ZyA9PSBOVUxMKQ0KLQkJCXJldHVybiBFTlhJTzsNCi0NCi0JCXN0ID0gcm1hbl9nZXRfYnVzdGFn
 KHJlZyk7DQotCQlzaCA9IHJtYW5fZ2V0X2J1c2hhbmRsZShyZWcpOw0KLQkJLyoNCi0JCSAqIFhY
 WDogcXVpY2sgY2hlY2sgdGhhdCBkZXZpY2UgYWN0dWFsbHkgaGFzIHNvdW5kIGNhcGFiaWxpdGll
 cy4NCi0JCSAqIFRoZSBwcm9ibGVtIGlzIHRoYXQgc29tZSBjYXJkcyBidWlsdCBhcm91bmQgRk04
 MDEgY2hpcCBvbmx5DQotCQkgKiBoYXZlIHJhZGlvIHR1bmVyIG9uYm9hcmQsIGJ1dCBubyBzb3Vu
 ZCBjYXBhYmlsaXRpZXMuIFRoZXJlDQotCQkgKiBpcyBubyAib2ZmaWNpYWwiIHdheSB0byBxdWlj
 a2x5IGNoZWNrIHRoaXMsIGJlY2F1c2UgYWxsDQotCQkgKiBJRHMgYXJlIGV4YWN0bHkgdGhlIHNh
 bWUuIFRoZSBvbmx5IGRpZmZlcmVuY2UgaXMgMHgyOA0KLQkJICogZGV2aWNlIGNvbnRyb2wgcmVn
 aXN0ZXIsIGRlc2NyaWJlZCBpbiBGTTgwMSBzcGVjaWZpY2F0aW9uDQotCQkgKiBhcyAiU1JDL01p
 eGVyIFRlc3QgQ29udHJvbC9ERkMgU3RhdHVzIiwgYnV0IHdpdGhvdXQNCi0JCSAqIGFueSBtb3Jl
 IGRldGFpbGVkIGV4cGxhbmF0aW9uLiBBY2NvcmRpbmcgdG8gc3BlY3MsIGFuZA0KLQkJICogYXZh
 aWxhYmxlIHNhbXBsZSBjYXJkcyAoU0YyNTYtUENQLVIgYW5kIFNGMjU2LVBDUy1SKSBpdHMNCi0J
 CSAqIHBvd2VyLW9uIHZhbHVlIHNob3VsZCBiZSBgMCcsIHdoaWxlIG9uIEFDOTctbGVzcyB0dW5l
 cg0KLQkJICogY2FyZCAoU0Y2NC1QQ1IpIGl0IHdhcyAweDgwLg0KLQkJICovDQotCQlpZiAoYnVz
 X3NwYWNlX3JlYWRfMShzdCwgc2gsIDB4MjgpID09IDApIHsNCi0JCQlkZXZpY2Vfc2V0X2Rlc2Mo
 ZGV2LA0KLQkJCSAgICAiRm9ydGUgTWVkaWEgRk04MDEgQXVkaW8gQ29udHJvbGxlciIpOw0KLQkJ
 CXJlc3VsdCA9IDA7DQotCQl9DQotDQotCQlidXNfcmVsZWFzZV9yZXNvdXJjZShkZXYsIHJlZ3R5
 cGUsIHJlZ2lkLCByZWcpOw0KKwkJZGV2aWNlX3NldF9kZXNjKGRldiwgIkZvcnRlIE1lZGlhIEZN
 ODAxIEF1ZGlvIENvbnRyb2xsZXIiKTsNCisJCXJldHVybiAwOw0KIAl9DQogLyoNCiAJaWYgKChp
 ZCA9IHBjaV9nZXRfZGV2aWQoZGV2KSkgPT0gUENJX0RFVklDRV9GT1JURU1FRElBMiApIHsNCkBA
 IC03NTEsNyArNzEzLDcgQEANCiAJCXJldHVybiBFTlhJTzsNCiAJfQ0KICovDQotCXJldHVybiAo
 cmVzdWx0KTsNCisJcmV0dXJuIEVOWElPOw0KIH0NCiANCiBzdGF0aWMgc3RydWN0IHJlc291cmNl
 ICoNCg==
 
 
 --=-Mfbapxw6W2CzHY3gTaML--

From: Eric Anholt <eta@lclark.edu>
To: gnats <freebsd-gnats-submit@FreeBSD.ORG>
Cc:  
Subject: Re: kern/82107
Date: Thu, 23 Jun 2005 13:07:17 -0700

 PRs kern/64118 and kern/69633 have been marked as duplicates of this
 one.
 
 -- 
 Eric Anholt                                     eta@lclark.edu
 http://people.freebsd.org/~anholt/              anholt@FreeBSD.org
State-Changed-From-To: open->feedback 
State-Changed-By: anholt 
State-Changed-When: Thu Jun 23 20:31:23 GMT 2005 
State-Changed-Why:  
New patch attached, waiting for feedback. 

http://www.freebsd.org/cgi/query-pr.cgi?pr=82107 
State-Changed-From-To: feedback->closed 
State-Changed-By: anholt 
State-Changed-When: Sun Jun 26 20:51:26 GMT 2005 
State-Changed-Why:  
The particular code backed out had been implicated in enough PRs that I went 
ahead and committed the MFC.  The problem should be fixed in 5-STABLE and 
6-CURRENT now, so I'm closing the PR. 

http://www.freebsd.org/cgi/query-pr.cgi?pr=82107 
>Unformatted:
