From davidt@yadt.co.uk  Sat May  7 17:48:09 2005
Return-Path: <davidt@yadt.co.uk>
Received: from mx1.FreeBSD.org (mx1.freebsd.org [216.136.204.125])
	by hub.freebsd.org (Postfix) with ESMTP id D03F216A4DB
	for <FreeBSD-gnats-submit@freebsd.org>; Sat,  7 May 2005 17:48:09 +0000 (GMT)
Received: from outcold.yadt.co.uk (outcold.yadt.co.uk [81.187.204.178])
	by mx1.FreeBSD.org (Postfix) with ESMTP id 40CA643DB1
	for <FreeBSD-gnats-submit@freebsd.org>; Sat,  7 May 2005 17:48:07 +0000 (GMT)
	(envelope-from davidt@yadt.co.uk)
Received: from localhost (localhost [127.0.0.1])
	by outcold.yadt.co.uk (Postfix) with ESMTP id BFB371DD573
	for <FreeBSD-gnats-submit@freebsd.org>; Sat,  7 May 2005 18:48:36 +0100 (BST)
Received: from outcold.yadt.co.uk ([127.0.0.1])
 by localhost (outcold.yadt.co.uk [127.0.0.1]) (amavisd-new, port 10024)
 with ESMTP id 27145-09 for <FreeBSD-gnats-submit@freebsd.org>;
 Sat,  7 May 2005 18:48:33 +0100 (BST)
Received: by outcold.yadt.co.uk (Postfix, from userid 1001)
	id 8A95E1DD571; Sat,  7 May 2005 18:48:33 +0100 (BST)
Message-Id: <20050507174833.8A95E1DD571@outcold.yadt.co.uk>
Date: Sat,  7 May 2005 18:48:33 +0100 (BST)
From: David Taylor <davidt-fbsd@yadt.co.uk>
Reply-To: David Taylor <davidt-fbsd@yadt.co.uk>
To: FreeBSD-gnats-submit@freebsd.org
Cc:
Subject: ppc_puc.c missing from amd64, ia64, alpha builds
X-Send-Pr-Version: 3.113
X-GNATS-Notify:

>Number:         80737
>Category:       kern
>Synopsis:       [patch] ppc_puc.c missing from amd64, ia64, alpha builds
>Confidential:   no
>Severity:       non-critical
>Priority:       low
>Responsible:    freebsd-bugs
>State:          closed
>Quarter:        
>Keywords:       
>Date-Required:  
>Class:          sw-bug
>Submitter-Id:   current-users
>Arrival-Date:   Sat May 07 17:50:01 GMT 2005
>Closed-Date:    Tue Jun 14 04:17:43 GMT 2005
>Last-Modified:  Tue Jun 14 04:17:43 GMT 2005
>Originator:     David Taylor
>Release:        FreeBSD 5.4-STABLE amd64
>Organization:
>Environment:
System: FreeBSD outcold.yadt.co.uk 5.4-STABLE FreeBSD 5.4-STABLE #3: Fri May 6 09:18:32 BST 2005 davidt@outcold.yadt.co.uk:/usr/obj/repo/FreeBSD/FreeBSD-5.x/src/sys/OUTCOLD amd64


>Description:

	puc(4) fails to attach to ppc cards on amd64, ia64, alpha machines.
	This is because ppc_puc.c is missing from
	sys/conf/files.{amd64,ia64,alpha}

>How-To-Repeat:

	Compile a kernel with device puc and device ppc on an
	amd64/ia64/alpha machine with a PCI based parallel port card.

	Note that a puc device is created, but no corresponding ppc
	device.

>Fix:

	Add dev/ppc/ppc_puc.c               optional        ppc puc pci

	To the appropriate files.* files.  Patch attached.

	This was tested only on amd64.  A working ppc device is created,
	although EPP/ECP support is not entirely functional (at least for
	my card).  I will investigate that further and send another PR...

Index: files.alpha
===================================================================
RCS file: /home/ncvs/src/sys/conf/files.alpha,v
retrieving revision 1.114
diff -u -r1.114 files.alpha
--- files.alpha	1 Aug 2004 11:40:51 -0000	1.114
+++ files.alpha	13 Apr 2005 11:21:43 -0000
@@ -183,6 +183,7 @@
 dev/kbd/kbd.c			optional	sc
 dev/kbd/kbd.c			optional	ukbd
 dev/ppc/ppc.c			optional        ppc
+dev/ppc/ppc_puc.c		optional	ppc puc pci
 dev/sio/sio.c			optional	sio
 dev/sio/sio_isa.c		optional	sio isa
 dev/syscons/schistory.c		optional	sc
Index: files.amd64
===================================================================
RCS file: /home/ncvs/src/sys/conf/files.amd64,v
retrieving revision 1.47.2.5
diff -u -r1.47.2.5 files.amd64
--- files.amd64	2 Apr 2005 16:37:57 -0000	1.47.2.5
+++ files.amd64	13 Apr 2005 11:21:53 -0000
@@ -133,6 +133,7 @@
 dev/kbd/kbd.c			optional	ukbd
 dev/mem/memutil.c		optional	mem
 dev/ppc/ppc.c			optional	ppc
+dev/ppc/ppc_puc.c		optional	ppc puc pci
 dev/sio/sio.c			optional	sio
 dev/sio/sio_isa.c		optional	sio isa
 dev/syscons/apm/apm_saver.c	optional	apm_saver apm
Index: files.ia64
===================================================================
RCS file: /home/ncvs/src/sys/conf/files.ia64,v
retrieving revision 1.72
diff -u -r1.72 files.ia64
--- files.ia64	16 Aug 2004 18:54:22 -0000	1.72
+++ files.ia64	13 Apr 2005 11:22:11 -0000
@@ -59,6 +59,7 @@
 dev/kbd/kbd.c			optional	sc
 dev/kbd/kbd.c			optional	ukbd
 dev/ppc/ppc.c			optional	ppc isa
+dev/ppc/ppc_puc.c		optional	ppc puc pci
 dev/syscons/schistory.c		optional	sc
 dev/syscons/scmouse.c		optional	sc
 dev/syscons/scterm-dumb.c	optional	sc
>Release-Note:
>Audit-Trail:
State-Changed-From-To: open->closed 
State-Changed-By: marcel 
State-Changed-When: Tue Jun 14 04:16:52 GMT 2005 
State-Changed-Why:  
Patch committed to -current. MFC to happen in 5 days. Thanks, 

http://www.freebsd.org/cgi/query-pr.cgi?pr=80737 
>Unformatted:
